From nobody Tue Feb 10 06:27:26 2026 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5622515747D for ; Sun, 26 Jan 2025 13:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737898167; cv=none; b=uJ8EAN6Z/Xyse/2bvDg8JNsv/aFqOvWg2S+LutpCsbnXEk/aUTQ5dT36qTmD//38ClISKxX55Fwe8ThXI2SQFVHOvN0oJe7eeZi/v2tRFYSMofaErMAKSkWztoMZoDI8xOjV5aKFEy0BQun77+NqrZJdBsUWrEjax6dKIud+ne0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737898167; c=relaxed/simple; bh=Bh587iD2fc71HoCxezk2yuAVtboO7fHMro855SCGYPU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Nxd8iLDdD31r7xii//jsZEdJ08r1kVFOwtom5mJkD2XDU/Q2MJ2rGOP4PlCggeRbFj57D45yW19Q+wgqs9zx35fknYLQAz/VhHdzDxp+E3qNrnEqLglSBs2SKByjd0HQ0sQB/0tWa4cApGgB7Z0D7JgYFwUm3Mo3lSKAPRht6ko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KYmBAA7G; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KYmBAA7G" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-543cc81ddebso2105063e87.1 for ; Sun, 26 Jan 2025 05:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737898163; x=1738502963; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=efhfp+4qW1iSmQeuDMr+e/8ImYQLWTnZeSHC6Pg4yQI=; b=KYmBAA7GEK7zn5pjeon9RuG0BxyIh7FC6rd4871SQ6r7K2W8SLeASXWN/1UvpoxvY8 fJit9nDY+J5YZQ9Zmjj3d+4nFNtSiV7WaToEFn+PbsbhvDDxBQhjU1OUws/CNk0PQhCC 839vun+b/kQ6J2+YnT5w7M9FjopPdWfW4lXMWIVYcZz0mPcAn+pgwa2ueQkm1w9uuAfI 1K29eKE6TLx2YGUkNplmg0BW8pDWwyQbYAl+z0pC4XwrzACsB4mRBTYZLsIbm/o2RlwG CQZbjaOGpKNCGPc+Gl/w1I/OHjjHVmc/lGYn9rf46YA5pKG+l52nkDzGT+4dcIHX72h6 v9LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737898163; x=1738502963; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=efhfp+4qW1iSmQeuDMr+e/8ImYQLWTnZeSHC6Pg4yQI=; b=l2iOLunkFLmCawHHoMpHw7VbRkdzN5cZUFNt4yD6f4HamHS28/qJ02qpAElTtyyHDN TELl3y/uQpDF4CiM+KOCuvlTHoJY0xUNR1FNE1XrJQXgE5ZNjeGLDsCnL21R0/PiEBYF 8FFxneETKM3sG0kM4gKNzO0H5QJ+jh9e1xbpufuiz7R3Bmiy9Vl3Lb1DyW0IlD87iagi 60sYhK5LfiRNFKUiVnvJ6XGsux2HRNRBJlC+Q8Zeq1P3uY8qQOxuFve+D8ZIdSrDxAPi airR7vJfoAZkO4Ru1VP+ptSvwiZnIVQKW6q5a+9pHijeMTd+3c+uW52F5X2QNZPCLPdp J/zQ== X-Forwarded-Encrypted: i=1; AJvYcCVGkT13ffQ+oNfTj2VFuk6hZ//DUbZSQSVP6Xha4HwRB6faCnf03ffOv/bDxulsV2/LX2AW3OkPLd10LXE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4Xlfp3qrBjmvW/hfYdGF+FEPVrDmzBUxiw/W9c1/wXPQJqRI4 0iTvEqfQvRP0ODTCZtlHAN6XhbX42GhKOJtGT0YbnSUOIV6GnLX372isEg+4iGc= X-Gm-Gg: ASbGncv5LtTb3X49MHq4HvwA+imrG/mcBEl4nIyadOFecdofFKJ/hxS4Pva8l8r0KIT 8jgVW3t2oUPnMC5wp+X9D7E9fiB8vBYGxinraiiBfUpLREC2JdL5W7u1/iqsM5ElUtGD7xQZwIg 4yDDmtnVY5C//idpWm/T1qnovpAQuGq3wdFfLWK9L071TKzYG8J9WgNxkbSLmnJ21FqHXKCe23V jeyZon3Tnz1/QkiGsxnGTxQOWiE8HuU3E6WgSeGAmneVqlEgmbNrGrLBGISiako7eG7cxHz776f riHQItOZB70o X-Google-Smtp-Source: AGHT+IGRFVavtCP2oHUG3cWkJln79H03XgQNclX1sBSU4i0U6FM+nxYetEFqwINGPmVUjLm2/ld5oQ== X-Received: by 2002:ac2:5497:0:b0:542:2a20:e699 with SMTP id 2adb3069b0e04-5439c21f31fmr9969294e87.9.1737898163506; Sun, 26 Jan 2025 05:29:23 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-543cbbd4cf8sm770488e87.201.2025.01.26.05.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2025 05:29:22 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 26 Jan 2025 15:29:11 +0200 Subject: [PATCH v3 06/10] drm/bridge: move private data to the end of the struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250126-drm-hdmi-connector-cec-v3-6-5b5b2d4956da@linaro.org> References: <20250126-drm-hdmi-connector-cec-v3-0-5b5b2d4956da@linaro.org> In-Reply-To: <20250126-drm-hdmi-connector-cec-v3-0-5b5b2d4956da@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1860; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=Bh587iD2fc71HoCxezk2yuAVtboO7fHMro855SCGYPU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnljikKPA9DA3frChDr5cC8Ud5cvJdTqCYznd+J 5AmlRoZ5Z2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ5Y4pAAKCRCLPIo+Aiko 1Sz/CACtnEd7Pc0822JrjUoq6+RwZyPotsnDptSEdfECF9jiRDPxncN19071vyguqmutGjgtUOH LeW+kdl82VIQJGyxkPUb49s3ZPRUHA5/Aqe1Wlr8xHagTq1K1iyCsi02KTMCk4fYBbe/E+OOnkK 1gPLYH/iOBu1vJd4PwvYVh4JNJeynmCet1a1Op1MuAwoUhNO31GgepazWzuRizxbjFxkuFXyqJW mGsaN2v2w2Rl/AlFopd6JnAjS6DuqRAkrJV6DFA3ea4xA7FS5XYl9XKIBisAUi+Px6p9FskRNNQ igUckx2Qk0mELpvZ7VkFw5x2inT9H89HhjT3/vuH3IsEUjUO X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A WHen adding HDMI fields I didn't notice the private: declaration for HPD fields. Move private fields to the end of the struct drm_bride to have clear distinction between private and public fields. Signed-off-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard --- include/drm/drm_bridge.h | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 1f1670e3c6aac39b8b891b0d5e7e91254eb0d3a1..348778f233b06265a6ae577762c= 6558e69cdb396 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -872,21 +872,6 @@ struct drm_bridge { * @ddc: Associated I2C adapter for DDC access, if any. */ struct i2c_adapter *ddc; - /** private: */ - /** - * @hpd_mutex: Protects the @hpd_cb and @hpd_data fields. - */ - struct mutex hpd_mutex; - /** - * @hpd_cb: Hot plug detection callback, registered with - * drm_bridge_hpd_enable(). - */ - void (*hpd_cb)(void *data, enum drm_connector_status status); - /** - * @hpd_data: Private data passed to the Hot plug detection callback - * @hpd_cb. - */ - void *hpd_data; =20 /** * @vendor: Vendor of the product to be used for the SPD InfoFrame @@ -938,6 +923,22 @@ struct drm_bridge { * @hdmi_cec_notifier: use this bridge to register a CEC notifier */ bool hdmi_cec_notifier; + + /** private: */ + /** + * @hpd_mutex: Protects the @hpd_cb and @hpd_data fields. + */ + struct mutex hpd_mutex; + /** + * @hpd_cb: Hot plug detection callback, registered with + * drm_bridge_hpd_enable(). + */ + void (*hpd_cb)(void *data, enum drm_connector_status status); + /** + * @hpd_data: Private data passed to the Hot plug detection callback + * @hpd_cb. + */ + void *hpd_data; }; =20 static inline struct drm_bridge * --=20 2.39.5