From nobody Mon Feb 9 16:45:31 2026 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 200222080D9 for ; Sat, 25 Jan 2025 06:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787606; cv=none; b=tvKVvNGvkdJgnDH8AYQWpZTbx+f5XE7ya1Eb+3uXyyTj7D7GrTc91rvskFqY7ao383on/mIRL1ycmxnggHtl9spDK3FcC9nTuriTz2sFoAsmKOl/nDPp01AbfaS8PquqkUyPfv37kuxTuzLF8x+4BCXd7us0ruh85ExB06Fm68U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787606; c=relaxed/simple; bh=MZv3bpfTSyCGgEqbsD5gzfkax2h9z5yPX7PR0S81+Co=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M64WuC/YMO821H5OqS2Yijq+u9T4zsv3Lng+8kzvaLeDE6/537dgOClphLCaXayG8MEzFoTj1jsID2LGa9KbxmMsBrpfCbHX86AGSzTQeWmM13aJ+BIRSL+1QyVD+aojCTkfhMCahDUb1uwBb7eh6jXCUc2jRhgbvKEXoh10Pt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZyunjDwe; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZyunjDwe" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-84cdb6fba9bso226652739f.2 for ; Fri, 24 Jan 2025 22:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787604; x=1738392404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gfV6PeTEsI0VgSdAZwuy1u+rsYeivbmD+1moBtyYi7s=; b=ZyunjDweUlb0DcobXh3gnCjA24F+Zy/Bn4gQIzPvyhJ7jnQHsPgZU/9ZzK8qyxg3X/ pm7V2ot7fCTkcqPCXfaHyeBl05FNUb4T4tJhdF27SBefkR0/6Vt0Hau9qZveT5+4UACD KNwaH+/n/aDRPQeakWWN/nWIMfBrSCweDIQH/lMQwLT29rmtWGQvEG1fnr4PASKB9/j9 i1dezyaxKnaMaB3M7i21HTlsGXG93AYjT0YbTD15HQvdexh0qVCE0vWRHxfvd7L05Tml hI/fRXABX9DSc0x0bzMKwSXioha9duMvqGVB7UZT+g7HaWSE+IMGLo7wfe9XxpAM5tVj He+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787604; x=1738392404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gfV6PeTEsI0VgSdAZwuy1u+rsYeivbmD+1moBtyYi7s=; b=mTKAKPNbDiQzAdlYXIZ9qxt3G8VlfdUMWt+vP5xhSvsyJFP+4BzUkoajb9IfUw86ob /nVMMvXZfwZZJxA/p5KSOJX+MLc0u0Cqg5RBvkRNvdz9xcKkI/2cTvINzkOafhEo3jF2 GP884E1MF44VeL/tOpbe95isPJosaMoTN53JY75dRrWtvVUgUVaGGaLOSwPd3OqntTv2 iAd5LzOsbic43QmhEPVLsVFnH8Gh1F/TqIZG2qk2B+wkaQzB7Z9yVWw76ldS8VLBFzGe RjN6DS9Drv1FDJci4dvhdT3aE2jVivnHnyfdSdItg6NFHvkksYYCn3T5UStxsbjkO7vK ZulQ== X-Gm-Message-State: AOJu0Yw1u5zLM+sgvC3MzRfZ+pzxeFjn6RLfsBA/rz4PUgpb2oTN5pRe NvTFJ+b5yr4FuYcRmBkbLshueYDcHX+Z2pdhpFkvYTTnvIqeEFGToRBuwQ== X-Gm-Gg: ASbGncu3xbwPZS8Wvr6jttxdbyXtxOL3L68BFKurrnpv9iSHzmEJgWCqbRdr9ZMC6/r PXZJbMoIcf2QPrfgwaE/1UjNzc10XdS3t98U+FaY88gvZlG2YJXAULoqtjXALCPXQBLhbJ5aUHG /kES9aNazsQ29jeDkn5leXZwOSvc6VlkDlPZeRePDBZhjssRRs9dM4SQZHlDZD6E9MDA21g92qJ mqvMJFio6mnbB9cfZY+6at3hIo5tenfTC/y5+xCiOt02+BylMkxlnWG4c3eMzZtM5U/3XupOFU7 4Xv9Ffwl7sMpaFx8z/kMjfYjsRgD56P8SQPQiNo+RGxonuFx X-Google-Smtp-Source: AGHT+IGNmawZ5H7p5nSdLzECedgsD/gX3TGGq70Fq+Pnwp8P7+wi2jDLWawGYzx5t0CkZCBiLMpQ1g== X-Received: by 2002:a05:6602:6c06:b0:84f:5634:8a1b with SMTP id ca18e2360f4ac-851b619f8f4mr2827044139f.2.1737787603950; Fri, 24 Jan 2025 22:46:43 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:46:43 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 07/63] dyndbg: split param_set_dyndbg_classes to _module & wrapper fns Date: Fri, 24 Jan 2025 23:45:21 -0700 Message-ID: <20250125064619.8305-8-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Split api-fn: param_set_dyndbg_classes(), adding modname param and passing NULL in from api-fn. The new arg allows caller to specify that only one module is affected by a prdbgs update. This selectivity will be used later to narrow the scope of changes made. no functional change. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- lib/dynamic_debug.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 8adb81e75a16..9adcb9fa7110 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -711,18 +711,9 @@ static int param_set_dyndbg_classnames(const char *ins= tr, const struct kernel_pa return 0; } =20 -/** - * param_set_dyndbg_classes - class FOO >control - * @instr: string echo>d to sysfs, input depends on map_type - * @kp: kp->arg has state: bits/lvl, map, map_type - * - * Enable/disable prdbgs by their class, as given in the arguments to - * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative - * levels by bitpos. - * - * Returns: 0 or <0 if error. - */ -int param_set_dyndbg_classes(const char *instr, const struct kernel_param = *kp) +static int param_set_dyndbg_module_classes(const char *instr, + const struct kernel_param *kp, + const char *modnm) { const struct ddebug_class_param *dcp =3D kp->arg; const struct ddebug_class_map *map =3D dcp->map; @@ -759,8 +750,8 @@ int param_set_dyndbg_classes(const char *instr, const s= truct kernel_param *kp) KP_NAME(kp), inrep, CLASSMAP_BITMASK(map->length)); inrep &=3D CLASSMAP_BITMASK(map->length); } - v2pr_info("bits:%lx > %s\n", inrep, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, NULL); + v2pr_info("bits:0x%lx > %s.%s\n", inrep, modnm ?: "*", KP_NAME(kp)); + totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, modnm); *dcp->bits =3D inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -773,7 +764,7 @@ int param_set_dyndbg_classes(const char *instr, const s= truct kernel_param *kp) old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); new_bits =3D CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, NULL); + totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, modnm); *dcp->lvl =3D inrep; break; default: @@ -782,6 +773,22 @@ int param_set_dyndbg_classes(const char *instr, const = struct kernel_param *kp) vpr_info("%s: total matches: %d\n", KP_NAME(kp), totct); return 0; } + +/** + * param_set_dyndbg_classes - class FOO >control + * @instr: string echo>d to sysfs, input depends on map_type + * @kp: kp->arg has state: bits/lvl, map, map_type + * + * Enable/disable prdbgs by their class, as given in the arguments to + * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative + * levels by bitpos. + * + * Returns: 0 or <0 if error. + */ +int param_set_dyndbg_classes(const char *instr, const struct kernel_param = *kp) +{ + return param_set_dyndbg_module_classes(instr, kp, NULL); +} EXPORT_SYMBOL(param_set_dyndbg_classes); =20 /** --=20 2.48.1