From nobody Mon Feb 9 16:45:34 2026 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDDFD2080C1 for ; Sat, 25 Jan 2025 06:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787605; cv=none; b=aMLw2jWgRl4ypM2hR4EDVYcSmemmUS1Js0a0K5ofvQraEqVeP4TiG/kjvO7nbXZogIi9Sf7JD5RAIyXrjZY2fWftZ3/nGMP2El2kJ27VPt6FNoD2ONdJe5miY+ZLqtA9bvidnQIVpBLT4hN2fATztgjsMdPvVlc8L6pUgF7AS5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787605; c=relaxed/simple; bh=Picx7G5c+bSoN2bXvLcIaJ2p+WmVCxdOBIdUNxnXsE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U7GJgHTONXggpgxORNf3WV2I4yk0rJoQz+B7n0pJj7/R6qwvKzglo5F1HqaKxWxF1X8S8FmFkYJW1iEH1y/xAWfdGufdE6hNOB3+IM50fxzo4PwLJp+h9hZYqSern0tPloFsQkJ+SP8c8GdocrPuxw9Pt6nYsUDNB/H14c8GZGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MYqP+10L; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MYqP+10L" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-84cdb6fba9bso226652339f.2 for ; Fri, 24 Jan 2025 22:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787603; x=1738392403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CqVpFbHHatr/2ING85ieH4d9rnOXpZNWBvi8gxx8k90=; b=MYqP+10Lbe1bcdxYx5Ma8BuPyKZuRILoIo689agPuxIlP29+nKjVJXH68fRJllRfEy Lm4Vghp2y7V0q9LgiuscE6gftR8iTiE50nVYic2IRhlAg2orue8LOPUUMd89AW6/l/lI jBHm65ks9tXxR2nKzcTzA2xIRn7THDMd0CLs+dlgyiaMS7r9ShmxMCbxUbDyUuh7/1pJ 0e6d3ZQkdn36O2uw7HPj5JO6m0Ord7y2N62U5iQ6X9pWUqgo7/BZ3OZxzJx1hMSYR+EL clrscloZlcmRZ852qwY4JhbEsLaPzef6h0b8s2Jqpk2rJ/9/o3klLQ/qn+lSGukDpK6K 6PzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787603; x=1738392403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CqVpFbHHatr/2ING85ieH4d9rnOXpZNWBvi8gxx8k90=; b=ttsH7d56uWUa0grqTZx8r9fmgtvnTGIAZCjZIuuOWXczOH4/IYXPggqwT8u1egc1xA fcqdlqdKt/kyC4uyGoKVeUvn/93vtC7rMqiZ6tXTMaMVhieLhEOpPq+XcsG0lvisOuc4 CL8Yn/VAmJsREY8bLGlucX/vndNFbJNva96PoZfsHGeUuon8RN7NCJcUHIKU+nmNo1fC Xim3KnkSqBdhjlr0R19Rm3sfnmgqi5WocvrzL0UwX1dRpd0uPfItgKllpbXr5+JSSiFB kiJu7Ma2JVagAAQLaanWrTJZO7BgYBQHSPI+XAjeeIQd+te4yfNCqi7BiYDIylqooo9f 51dw== X-Gm-Message-State: AOJu0Yx6UT9FUMtQn9aEYWm2HKLOsv3lxRbTUQ39nkcol2LK46OUhcdf /jPXUj6Sfj9k0GG9ioLpYcX87Y3/YHUS4uJyVW3F4sDYqh26SdBGnIi5Vw== X-Gm-Gg: ASbGncvMtiR+hazxtFvaYbcVnf6gbO+i2WUVcVNRpswtt2Fe42J98IaZM5FCrocoHL/ HE9PeyRyANmKeNicQF1l4XUKe/dY+0DGsBwUenjOUD7YgsNpz5Shh39nVxbQHPeS12kihGVZWUr FzrJr2kvaW/y1Y5fXMVloKCXQJg8nc27FPocrrHYiuP5fQRzzw4ORGNYGMS1B0hHo1M5WXBAV/f YtNCjuOgTHcrpsrQ6Cw83RR8tvr0uDUffd8qFsAjw279QiQ5+Aydwy7Z3EtG/7agoW6mIXbIu7g J0ooI6O/pZ6wNwvKGidoJA4zAcl9T6Czfmlj+w== X-Google-Smtp-Source: AGHT+IEG9pcmO7ys8hwr6eegaGLDGSEioGdLb+KAZBSau8bqMWNW5dSAy4HzShNFq1TzGgbki4fQoQ== X-Received: by 2002:a05:6602:4006:b0:847:560c:e7b7 with SMTP id ca18e2360f4ac-851b61f053bmr3495732039f.4.1737787602874; Fri, 24 Jan 2025 22:46:42 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:46:42 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 06/63] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Date: Fri, 24 Jan 2025 23:45:20 -0700 Message-ID: <20250125064619.8305-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add param: query_module to ddebug_apply_class_bitmap(), and pass it thru to _ddebug_queries(), replacing NULL with query_module. This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to each USEr as they're modprobed. No functional change. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- after `modprobe i915`, heres the module dependencies, though not all on drm.debug. bash-5.2# lsmod Module Size Used by i915 3133440 0 drm_buddy 20480 1 i915 ttm 90112 1 i915 i2c_algo_bit 16384 1 i915 video 61440 1 i915 wmi 32768 1 video drm_display_helper 200704 1 i915 drm_kms_helper 208896 2 drm_display_helper,i915 drm 606208 5 drm_kms_helper,drm_display_helper,drm_buddy= ,i915,ttm cec 57344 2 drm_display_helper,i915 --- lib/dynamic_debug.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 41cbaa96f83d..8adb81e75a16 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -605,7 +605,8 @@ static int ddebug_exec_queries(char *query, const char = *modname) =20 /* apply a new bitmap to the sys-knob's current bit-state */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits) + unsigned long *new_bits, unsigned long *old_bits, + const char *query_modname) { #define QUERY_SIZE 128 char query[QUERY_SIZE]; @@ -613,7 +614,8 @@ static int ddebug_apply_class_bitmap(const struct ddebu= g_class_param *dcp, int matches =3D 0; int bi, ct; =20 - v2pr_info("apply: 0x%lx to: 0x%lx\n", *new_bits, *old_bits); + v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, + query_modname ?: ""); =20 for (bi =3D 0; bi < map->length; bi++) { if (test_bit(bi, new_bits) =3D=3D test_bit(bi, old_bits)) @@ -622,12 +624,15 @@ static int ddebug_apply_class_bitmap(const struct dde= bug_class_param *dcp, snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], test_bit(bi, new_bits) ? '+' : '-', dcp->flags); =20 - ct =3D ddebug_exec_queries(query, NULL); + ct =3D ddebug_exec_queries(query, query_modname); matches +=3D ct; =20 v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } + v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bit= s, + query_modname ?: ""); + return matches; } =20 @@ -682,7 +687,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa continue; } curr_bits ^=3D BIT(cls_id); - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits, NULL); *dcp->bits =3D curr_bits; v2pr_info("%s: changed bit %d:%s\n", KP_NAME(kp), cls_id, map->class_names[cls_id]); @@ -692,7 +697,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); curr_bits =3D CLASSMAP_BITMASK(cls_id + (wanted ? 1 : 0 )); =20 - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits, NULL); *dcp->lvl =3D (cls_id + (wanted ? 1 : 0)); v2pr_info("%s: changed bit-%d: \"%s\" %lx->%lx\n", KP_NAME(kp), cls_id, map->class_names[cls_id], old_bits, curr_bits); @@ -755,7 +760,7 @@ int param_set_dyndbg_classes(const char *instr, const s= truct kernel_param *kp) inrep &=3D CLASSMAP_BITMASK(map->length); } v2pr_info("bits:%lx > %s\n", inrep, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, NULL); *dcp->bits =3D inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -768,7 +773,7 @@ int param_set_dyndbg_classes(const char *instr, const s= truct kernel_param *kp) old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); new_bits =3D CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, NULL); *dcp->lvl =3D inrep; break; default: --=20 2.48.1