From nobody Mon Feb 9 16:45:32 2026 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBA70207DE2 for ; Sat, 25 Jan 2025 06:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787603; cv=none; b=ly8GIwUhoHw+Y0CqVpt934e+ZsUP9rfQFnRUktniv6YINQ3t25VldNXNKdcwlB7ejJ+LzqZH0YqnJjWYiploElwxkoVZWoky9IuxclW1KEFvFFcz7KvuNsBEK+OekUlwLPkOBGXG61+kigldpwDw/3TuJo8FspLH5hPdiWuNSWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787603; c=relaxed/simple; bh=xBSBEQNBO39rbIFsNyyaVaUZyAazvXvcWuDuIXuvpNU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aFB4SUHYkqjpCY7eMCW1qWoFL/REsDtWDN6jUONphUcMxfpmYrmcztrAip4GA6bE2/GUcMddd92diq/AxxuVBWlm+N6iURfETu4enFpmt5fOdbdOj4WdvDYYvV1vSIKdCnqu8XwfXVC6VEGPAiknzV0y4O0r+Ia0rsw821Cvwoo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nbwObuyR; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nbwObuyR" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-844e394395aso80202539f.3 for ; Fri, 24 Jan 2025 22:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787600; x=1738392400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g9s7OD1sQ4+HufNRNHWDoATH13uKXMFeEAmrzFZExds=; b=nbwObuyRqJYBljOhlUvULUPgNGksKms6r2p8rOZzIWVuwMsxdjH7oGFzHjRHLJ9tM3 zoidPUtWuREIQa11T7AO27R3R87QxT4uHtB9kLfDpyTsXAImvABv4ZzdO/iyxNGaaW44 DEhWOzuohSq84fioAFlJ9tzGS91C037g1QfNkOlgkbOokfaI+tcO1BVi/vgKbg1ESFJG SCWM8VZcZ3KNcdRYrB3cOF8tee9atplN5NOHKft5yXlPfNyiJznFT53SToknrW9sWBGE 2p98D8XomhDCw6Lr7xiWGqLoqtCzqNyBqZVgiRoXZ7UWVQ+IP674DU+JpiD63dbrv1Kd Nwhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787600; x=1738392400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g9s7OD1sQ4+HufNRNHWDoATH13uKXMFeEAmrzFZExds=; b=gvPylGEiIRlYKwBA3322xvDfS2T+oG8SVXGetNs2fhDtygRSXezm7puhIuaV3GTOoU vbeqy/jmQrkXl/NoTmCrbbg0lAMxkvZh0/BNxoskLhAlsK5qEeyg4Q+wQKNaxHefeV22 qnsAipvTWuj/33bGazvOKf7p8rF3j/ixL4r7ZzoBNj3rxK1Eb+y35ogOk/uEaEkbxnD5 blpNbhGmz5vVVrn6IxfDhNtTtAWuccXrLcQ3vqNDQbV+WXyLU9jfS0bu4cLl++HBIoGd tcbe3X9Nl41dy/Qa26EQ1fMu/D1Omup6bxakgPhulwARBkuNGq5jMAxnmh9WaSFkkNAt Av9w== X-Gm-Message-State: AOJu0Yx0Ld90MpOZ/rpmHR8nmGoaf0D/hVgsD/PyOCOD9EW8PZqkKNwl Z09ml7AXjxXLo4awG6rvewZd4pkC5qB+dy7s6x6NyCQurvFGgKcjeaCb2Q== X-Gm-Gg: ASbGnctpsMPGtcj8lWLUOj9tL66khW7gr//o0CAKv37rYqzfBMMK1Cr2GJh7L7ky/dY NMeo8GcDJYFGtGkXJC8StLcxJS86omN7kzAOgoJa0ENcZmBPwJ9nCjL9gc1fYDzEcQcm6jAh10h yBWkYmenuWoQ7/njPC2+PMDyYEfmr+I5f7DEHvEOFpiKwTh56osh79UO/YplCcJ4S+cplwNVpmr vCjTyT1onFYNCYJ+fXg0imJtd3/m7g6ARbOhQVAdCoqZbfpdO9JEk/MD+8v+l9SJKchWoeVTuNk PpzOsb8OuFs2thWZzgE4qEBreV9qRA/MEoCK5w== X-Google-Smtp-Source: AGHT+IHgbpWAw3ToF51VNapcA24BXvqXwUUtA2PGPS4mT2XtqGWGo3JjVejPDRtbOWoXeUzU8vi6VA== X-Received: by 2002:a05:6e02:1381:b0:3cf:b7c0:8809 with SMTP id e9e14a558f8ab-3cfb7c08be4mr109840195ab.8.1737787600600; Fri, 24 Jan 2025 22:46:40 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:46:40 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 04/63] dyndbg: make ddebug_class_param union members same size Date: Fri, 24 Jan 2025 23:45:18 -0700 Message-ID: <20250125064619.8305-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index ff44ec346162..b9afc7731b7c 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -124,7 +124,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 147540c57154..55df35df093b 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -799,7 +799,7 @@ int param_get_dyndbg_classes(char *buffer, const struct= kernel_param *kp) =20 case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } --=20 2.48.1