From nobody Tue Feb 10 01:59:47 2026 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0067F207DF8 for ; Sat, 25 Jan 2025 06:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787638; cv=none; b=DRL7X+0lXgH0x2qMDrpJxEubOt5ecnnzKI1KTLD82yNWVyn7Uxeb1seGg7J7NJTf2ntEKM90iSU0Txphj/bimRk9Bv6jY5IODrLrE7CtLUgp//h7V0m7DvNJjld7vkADHnCIw/lpJthyWqUXeEspbuWd+OD+LUCjncLagxcPlWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787638; c=relaxed/simple; bh=NUKBLreV2V6Xt9VP/Iyf5gS27NIo/qOExsV4ApIKSkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kVJNkiQVldFG/M/2bLEgc2eMUsMYArZVqoE8BNrAiufTy24LZNYsIBJkCd5fKkTE4JqkBYXRn/fukinClkT32RwOfzaOvCen634+jLHwyXDTd79Y0Qz5l2KwBPCXmRh4Lg8heieK5LGvaJByBuFVHtXK/SDjI2bbxaFp3pbAGzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bjXcwN7l; arc=none smtp.client-ip=209.85.166.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bjXcwN7l" Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-3cfc934af74so14340695ab.2 for ; Fri, 24 Jan 2025 22:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787636; x=1738392436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jfhcWZrz83wYOYEIdNpEF1X0nPHND6LQ2XiKG1miCwc=; b=bjXcwN7lVWR8AkR1oA8jHv5wovVM1SFPEhGRq5eIHnSbF89aauwEAVFqsaReoL0agJ mpqqw+qt52ZAkYWqDiD6eK8bJAE6EPtceu4NNNFx1F2DuUmubU/jgoDyMin1v8ppW6tY V1mVBz95IPzUu7rpCV07odRqfqrbBtsg69zC0tf4EDwxMqf3t4Z7eruQeJzpGlrhwgFy UAEu6cEEXlZhXr3+MZU6X92tyCWSLqq/LwQs9Pmbz16fnGH1Vdwz1OX+hX2KqhcJEnYz T/J3y0gPsPHayyq42iw4TjoaT3DQoAdQsBjCBiVzaAqPFEinETw27s9iI2Otm0eafuv7 sSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787636; x=1738392436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jfhcWZrz83wYOYEIdNpEF1X0nPHND6LQ2XiKG1miCwc=; b=PIQ4KROPWRMmLKlaF0kCd0NPnLLKO/p4Ny6acUcU+fMitCVf6DTURvkqrlKr3r+7xl tfJmwOOWuLztwsF0Og/m/QNYQWDEJ1OqPa09B41FlWhWQoXiDXdx6tj30ZUyHZxiaQKy JlWpTt7GdgVnx6Qp5dp4DqlESe5n6ECKGEMzvoxB5gaunv9DWuGU8mkFfr2bR6R2iTMV zlPccNvAzNbtCYI+ekGBq3/jITu419qkCq5KIakDv51LNsLMich+Vvp6zBwk5HpNNq2k TLLFq3HraNTrPsk/vh+Ke+7svdkrg8O0ZD7xN8pc7fxfPBDYrJuNN2xWOxLPpTLPlixP HAxQ== X-Gm-Message-State: AOJu0YwFVVvP88r5BkYBOs+Um4hgRD1QAie8eCdIHpj0Tu6lZrbD/SAC VnnQJd1xnCL0TpdJ7WtCd5BxIHEG4eci0PvholD9Btwj4oJVzn8AVeg51g== X-Gm-Gg: ASbGncuSMc0UH1/vSwoKBi7VfNBC5mYA0S3AHFhFSzrLMQpQb4YOayfC51EZ11UUT/y zCjC4bpbY6C1KkOv/uJMLQ4tVmZCtiS+GyN8ZB5IullUN0EW7t3wBSlCQgj1TnHQumWVjCoC+IS j3xpKHpxLcsvUYyPGM78UE0iP+X0LA9wSuw04eLVTZBF31WskSbOhCN7+JZlJh6dJ6EDDTN5UCd +XA7IjpjDY3hcrO6jar0y7MM2It/qyLAXdq0mm7UmJ54U5Pb4RUZuleLRegbDxRQICAstJZXCc+ zpjijaQkJKZYSzZJqX41gwWLXhwh8+4C6kCEhg== X-Google-Smtp-Source: AGHT+IEOc8EmSIZbznFHHPXX84xuy1I6pZ+yKmSAQ2gwM3rRL/NYDxG3wxu+D0E1wbsVsa/ZJEfxwQ== X-Received: by 2002:a05:6e02:3f03:b0:3ce:87e3:c26c with SMTP id e9e14a558f8ab-3cf743df88amr329678565ab.5.1737787636061; Fri, 24 Jan 2025 22:47:16 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:47:15 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 36/63] docs/dyndbg: explain flags parse 1st Date: Fri, 24 Jan 2025 23:45:50 -0700 Message-ID: <20250125064619.8305-37-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When writing queries to >control, flags are parsed 1st, since they are the only required field, and they require specific compositions. So if the flags draw an error (on those specifics), then keyword errors aren't reported. This can be mildly confusing/annoying, so explain it instead. Signed-off-by: Jim Cromie --- Documentation/admin-guide/dynamic-debug-howto.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentat= ion/admin-guide/dynamic-debug-howto.rst index c3537f8689e6..89810ebaca8c 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -112,6 +112,16 @@ The match-spec's select *prdbgs* from the catalog, upo= n which to apply the flags-spec, all constraints are ANDed together. An absent keyword is the same as keyword "*". =20 +Note: because the match-spec can be empty, the flags are checked 1st, +then the pairs of keyword values. Flag errs will hide keyword errs: + + bash-5.2# ddcmd mod bar +foo + dyndbg: read 13 bytes from userspace + dyndbg: query 0: "mod bar +foo" mod:* + dyndbg: unknown flag 'o' + dyndbg: flags parse failed + dyndbg: processed 1 queries, with 0 matches, 1 errs + A match specification is a keyword, which selects the attribute of the callsite to be compared, and a value to compare against. Possible keywords are::: --=20 2.48.1