From nobody Tue Feb 10 01:59:55 2026 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF86820F978 for ; Sat, 25 Jan 2025 06:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787632; cv=none; b=QpfPErQaSLUNpgKHJU6PyCXjzrBz0gj59MnlgLcRZP3YHNY3dainaZcRoDXhQ10pyep6F1I9DNpHjfybshbinUMiuU5p65sVvyXYOzQFJTbqZnNgpoqWbA1f2N/fEUQ+NK6lY9WmRjHASEw6CaPMipJ0g4l6OjQUdNFA2L3gYy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787632; c=relaxed/simple; bh=8mBPJoTtZ1Z64e7ets6Lftpvv9xxyy6/HNCPnYxIfO4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GhFAdA53awpQjmyxjlpcRnAWgismLQCZ7Vuk+UvJPYEdySXbt/LRnqXstzkglDCVZ7/C0NPmOHI3LlvALNuCR0Xw6Z1Mk7nSt0tAmucurrfd91BwMQhhkp6W4nZpK3vSHc3tQE5mbqUuwhjHJyWqCFtfGM6ZzljbQvxeZdKynzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BZFPJFNu; arc=none smtp.client-ip=209.85.166.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BZFPJFNu" Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-844e394395aso80211639f.3 for ; Fri, 24 Jan 2025 22:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787630; x=1738392430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x11BZKBrVuF//4sDIzHDHCm/mRQ6/WwpO4x5frMPkhY=; b=BZFPJFNupu/1mPRylyXIwspCED9nsukc+IDfZZbQvTQf0mKN+FU5zvQDTG/lY0VkPD 9lVF9It+mNovdIgUL5+MY+GUi/pu/QmUnadr1T2VCGvnxqbi0z1c3XtQNAm3DYLDly3l ew2vBGtaGNodWTpJx8qR/rJyy7qbc+eYgeVJPDnHkcfeqPZuJvfvsPfYMPqmDP5CL/dz vMKHxCBnGDG7Kkc0mxzLp8LCqmb5UcXZULFcBtpv5x5cperBoa5JsRg1y0LhILJgr8ZU D2HG9real1pCLd8XQdMjdPdQHu867ABOrrj/6wdfBas5JjDBkccNhf0fZxbl7j/JSGKG sncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787630; x=1738392430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x11BZKBrVuF//4sDIzHDHCm/mRQ6/WwpO4x5frMPkhY=; b=RDGWyN573EGnhBfVnowB+YRTczN7/F8lpnAND90eBu6KPPgfuq+CCNHMV8dLBI49ll Mo5RWyZONFh7G4Kyi7mJdreF2iPQhi78bYiQyN3/pCBakO/0QFjQOhz30L+wT2McYYNq tL3heLv64qoLJplZ55fOT+CBAaS9g99tRZCob10NAOgVbUpVwuBtmhd7SzK8vFtv5D1H io09y0pIOhruVd5JhZac6U2cLhHW/F6YNOZQ0GZW16DtCMpHbnsiOzfI7TOAmGN+rcvN i4+P9CbLlXO4+zuVpEZwA9OFd2RSSZ3PxTs/sI3jseB1fZBL3OeRi2E40Ao9wDdz47II oL7w== X-Gm-Message-State: AOJu0YzDAGFUGOpMWYp6eUM0rxo9T7ljYSNPy0iqD5xgljlqLVO1eyyF Ax+korisL31BfI+rw2Pok0qgzk2MU/pmgG6YMw2XEBBx3BSOrlDvf0tbBw== X-Gm-Gg: ASbGncvegBwQhXgrTMh2Ncvq2AlIDh1eszy8h1kJt6n7D3kGkl7uVr01EKbffj3bdM3 yNao7uPeoRO5hiN4d3kbUlzmg5uq57W8ofaBV9ilQRUUZvZB9UIDnLPIg4meD2TXjkrARlq6pVm NkISfcITMoL6Uv7//iZQ+fZMz/FElI40EWOk5pIF5+RzKHRCPpPgwPveGbTAWI1OeCF3ewIPFk1 DwTAaf+rcthk0WsDj5ieecY5Gx5xQjFx3w48JhPKC2DOYJ3uXQbclMgwWx10OBE9Ij+cqE3FRFC R4OYbxWk9Pw+kY9G1KAJqGK2ewIe6F5QiirCCg== X-Google-Smtp-Source: AGHT+IEMjfj5KPBD+MY1YnSxoaWknOFxVXF7E1RjBZMpsyNcxNDm6LNROXUaKAR5kPzioEBH7zCauA== X-Received: by 2002:a05:6602:3e94:b0:843:e667:f196 with SMTP id ca18e2360f4ac-851b61ee917mr3363869739f.4.1737787629916; Fri, 24 Jan 2025 22:47:09 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:47:09 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 30/63] dyndbg: treat comma as a token separator Date: Fri, 24 Jan 2025 23:45:44 -0700 Message-ID: <20250125064619.8305-31-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Treat comma as a token terminator, just like a space. This allows a user to avoid quoting hassles when spaces are otherwise needed: :#> modprobe drm dyndbg=3Dclass,DRM_UT_CORE,+p\;class,DRM_UT_KMS,+p or as a boot arg: drm.dyndbg=3Dclass,DRM_UT_CORE,+p # todo: support multi-query here Given the many ways a boot-line +args can be assembled and then passed in/down/around shell based tools, this may allow side-stepping all sorts of quoting hassles thru those layers. existing query format: modprobe test_dynamic_debug dyndbg=3D"class D2_CORE +p" new format: modprobe test_dynamic_debug dyndbg=3Dclass,D2_CORE,+p Signed-off-by: Jim Cromie Co-developed-by: =C5=81ukasz Bartosik Signed-off-by: =C5=81ukasz Bartosik --- lib/dynamic_debug.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 9283f2866415..56e09e878f80 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -293,6 +293,14 @@ static int ddebug_change(const struct ddebug_query *qu= ery, struct flag_settings return nfound; } =20 +static char *skip_spaces_and_commas(const char *str) +{ + str =3D skip_spaces(str); + while (*str =3D=3D ',') + str =3D skip_spaces(++str); + return (char *)str; +} + /* * Split the buffer `buf' into space-separated words. * Handles simple " and ' quoting, i.e. without nested, @@ -306,8 +314,8 @@ static int ddebug_tokenize(char *buf, char *words[], in= t maxwords) while (*buf) { char *end; =20 - /* Skip leading whitespace */ - buf =3D skip_spaces(buf); + /* Skip leading whitespace and comma */ + buf =3D skip_spaces_and_commas(buf); if (!*buf) break; /* oh, it was trailing whitespace */ if (*buf =3D=3D '#') @@ -323,7 +331,7 @@ static int ddebug_tokenize(char *buf, char *words[], in= t maxwords) return -EINVAL; /* unclosed quote */ } } else { - for (end =3D buf; *end && !isspace(*end); end++) + for (end =3D buf; *end && !isspace(*end) && *end !=3D ','; end++) ; if (end =3D=3D buf) { pr_err("parse err after word:%d=3D%s\n", nwords, @@ -595,7 +603,8 @@ static int ddebug_exec_queries(char *query, const char = *modname) if (split) *split++ =3D '\0'; =20 - query =3D skip_spaces(query); + query =3D skip_spaces_and_commas(query); + if (!query || !*query || *query =3D=3D '#') continue; =20 --=20 2.48.1