From nobody Tue Feb 10 01:59:56 2026 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E7E120B1FB for ; Sat, 25 Jan 2025 06:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787625; cv=none; b=Tb4C5eL5tEa0QNikqX5xn54AcGI8ce2Qr5vn4yIVdIYe1KKwGNf33ZhbMwLajsMGqLL3eLjIg0BQ1H87Qh50/WDbLg5NN9i8Fxg3FKsuki/JWfLTkJnPgTLvdLLgZNYC48mUgqFiQOae8+vYgjdLTmCZOw8cA+WJVpx7gc/9KGI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787625; c=relaxed/simple; bh=NxfSJjjJ23lXPS6gLCCPFKsu1Gj1wtTyjN68aeks3sk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bi1sHA2PRGjfQtDpRvf9apVfzpRDHiFTFOJEyJ3YKscuN0O+vU1aPL9xEUaeX3dH+t7gWZXQYQS5TtWO0Xkp4fZyNJ6I8iJouAJ6xtrJlWOkg7Jz0BCn8gd1ydsvpEOgna0iP0EkTnj9tJwh089NbsLesP+xCfp2QNab97B2Lsw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X2FIvsCk; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X2FIvsCk" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-844e7bc6d84so90831739f.0 for ; Fri, 24 Jan 2025 22:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787623; x=1738392423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=93jbq4Mgsj9Dng6wtNKkyeLZVZqBaH1mnVoaGdt6ywk=; b=X2FIvsCkdf5c5+BBPYjUVokMje4SpZYCuWELRVemmn9WzCPU5O608nFO5/t4Jbah89 o6qECrHMS0JnrjEABjU5ueaqN1Hm0oororMCQvVpmutuToB4gUeEFPsnkLnq4Bv1D+nN XuAJXyvPPLS5g9F0KAoQMi6vWt4h5CgC2PAM/23vyUU77+8JYwWQ7PcV80rby+GVZfgF SJg6GDGIxxVuNAu58RbDgtx4tMrhmDkpeirMhlvTCDoX14kYNXLFPk3dDUntOsb660Yj ckskPdTY/Rn+98tTTVefuteLqgoa2eu47cfgiC6Cq9fz4FpHcbJh8DbLgBru1/mLJ/sc EGdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787623; x=1738392423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=93jbq4Mgsj9Dng6wtNKkyeLZVZqBaH1mnVoaGdt6ywk=; b=ZUONdgIPaWKJ4ifmMCEjX4lsnpUeMZOCbaVGEMr26BX1lbGldnhBREscgtS5+itxi8 sIF1VtCi8jR3jvwShl5Vco3I4iSZMOZsHCyQBeR7ZA14xQ/mQ4uZIAQAklsBE0S2ImHV VGz3BLOHfztTAz8BJN8iX1oqtRdJPZKceUO4O5lR7jCQyvZsJN+4gTRCiyJbPZ1OAEB2 bM2w/dgfYxEnAxVpMa90+FHFwAmOhm9B8xWGIyAuaqxfjYiSgxVr3l06dDcoXAPN4qEk znGEjiQ6sIbSFUjEnnA9c2Oy6fFwpy6N1RufwN9jCH6d3Aby87jxEwAc4VIb0b65WQfp Cv5Q== X-Gm-Message-State: AOJu0YxIuQ7SAI0EuPle/J/zbuhuvONZR5T2nfThOKHXHOuC0+gBR4Sj 3jAPiQCvXjo7P+jmmr5mPjkiEImlh7UJnnKVSgOgL5p4p/HdEDnUzQ7K9A== X-Gm-Gg: ASbGncvQDF/t1EBHn84LnyMEuQdKwB6k+N8UZoH/Ozpz+9jnQPVNmJATeWUVqOy/43n s7HPx93q/EbB0xyRlT6uv9ZC3c23DnX4oTw1l4aQMpJrAJfecMf11s15jPuCR/vMGAQADMJrhHb tY9S0z3xIKiSywhrmiko6B0Vnt7kyCG3MU0DbVPt5CKOg0a2W7kvo9kpqbLtxvqNe0WE+cN8pTU CUuNdVodODEhmqQ0TXhV7KoqNeAlQqw5EUTemajS9nAcxyYwUKXXUv1SjSHgLEMOvjxaqqtHqwR Iszp5IG7ijfiqkVQ1jq8BytskP+9Uwc7LcrtMA== X-Google-Smtp-Source: AGHT+IEzK3tgR4ZqscbrvwKIW94h8D8rsgISbYsYpT/OLj+GuVfcmbYBQtPSq2z1B//b7y/JBkE8aQ== X-Received: by 2002:a5e:d804:0:b0:82c:ec0f:a081 with SMTP id ca18e2360f4ac-8521e32b142mr475805639f.4.1737787623209; Fri, 24 Jan 2025 22:47:03 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:47:02 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 24/63] dyndbg: hoist the range-overlap checks Date: Fri, 24 Jan 2025 23:45:38 -0700 Message-ID: <20250125064619.8305-25-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hoist the classmaps range-check up to ddebug_add_module() from ddebug_module_apply_class*(). THis puts both copies of the task together, with the other semi-init work. this allows ddebug_module_apply_class*() to revert back to void return, but doesn't do that yet. this is a candidate for squashing back. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 8e1e087e07c3..e57c05c9fb0a 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1257,11 +1257,9 @@ static int ddebug_module_apply_class_maps(struct dde= bug_table *dt, struct ddebug_class_map *cm; int i; =20 - for_subvec(i, cm, &dt->info, maps) { - if (ddebug_class_range_overlap(cm, reserved_ids)) - return -EINVAL; + for_subvec(i, cm, &dt->info, maps) ddebug_apply_params(cm, cm->mod_name); - } + vpr_info("module:%s attached %d classmaps\n", dt->mod_name, dt->info.maps= .len); return 0; } @@ -1272,11 +1270,9 @@ static int ddebug_module_apply_class_users(struct dd= ebug_table *dt, struct ddebug_class_user *cli; int i; =20 - for_subvec(i, cli, &dt->info, users) { - if (ddebug_class_range_overlap(cli->map, reserved_ids)) - return -EINVAL; + for_subvec(i, cli, &dt->info, users) ddebug_apply_params(cli->map, cli->mod_name); - } + vpr_info("module:%s attached %d classmap uses\n", dt->mod_name, dt->info.= users.len); return 0; } @@ -1322,6 +1318,13 @@ static int ddebug_add_module(struct _ddebug_info *di= , const char *modname) dd_mark_vector_subrange(i, dt, cm, di, maps); dd_mark_vector_subrange(i, dt, cli, di, users); =20 + for_subvec(i, cm, &dt->info, maps) + if (ddebug_class_range_overlap(cm, &reserved_ids)) + return -EINVAL; + for_subvec(i, cli, &dt->info, users) + if (ddebug_class_range_overlap(cli->map, &reserved_ids)) + return -EINVAL; + if (dt->info.maps.len) { rc =3D ddebug_module_apply_class_maps(dt, &reserved_ids); if (rc) { --=20 2.48.1