From nobody Tue Feb 10 00:38:43 2026 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E94E0207DEA for ; Sat, 25 Jan 2025 06:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787621; cv=none; b=ZKYq/ia7lPcsTYxhTWriY/juuMsuXT7n8WHiAydiS0kx4o1bmejBow60lEtJs2z1+ZWx+BtFU/K7+G7pC9ucvxgK+On2S8DX2r1lX/HCDAAHaWEM5lrSraS6EEiCnFj+S4ADZQ3craMvQdRlrFH+rrtzin7gucJ9LtwwNzusmUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787621; c=relaxed/simple; bh=29B4VO048y6EFRoFiAtHkZj4lK5/0PhDBhKsvpFRSiU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PGPLS5izcJpDAB0aYi80rgNJO/t8gPTaEMR+uDmUN6Hk2eq4Lb3cPhTr6a9IP0kvc4DhK6BLZlMesesl/5QtD23e6+r8rHBUik3nJjs/b3xA+jKcaRIiKOqxjHZBI1tdL+zocTHqkLZ8I8K+8uZ49QQLbwpUWE7apVH4VaXfGPs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F9MZipVp; arc=none smtp.client-ip=209.85.166.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F9MZipVp" Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-3cf8c7b2dd5so8338915ab.0 for ; Fri, 24 Jan 2025 22:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787619; x=1738392419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AnDsc2vkEgs5Pp7pnDF60W8zrCwME0cZq6yzmPBvEV8=; b=F9MZipVpv5Y+BrpRPE9Cs6Ww7acGg7f0YSkjkBlztaMFR3RqxV6fpVCOcJVvw1qngJ wgNIuCLtlA8DabqtAMHhcXQU4lS9uyNZo5/g4EPpGcfGkihkxbgCoknRdL6Wjc+qlrpv OEZ23dMgkKu50RzH71iAwdmlkFJ9I2eDM+cg2as7GVcfN4bKCJrFfCWleymcaRZHHAPG KA+1iCtCHq2E70R9k0xPqT5lxbbjZI/NhE9GsR8UK8cR1OBuHgjytHa8YYRmUpghfLY1 c1bHZOfSkeSzxPj8ZJs6o25zcxG51ONaRWGP1CryaL7GF3a8kC18/KnU+TWMSfJsraBp 9Eiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787619; x=1738392419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AnDsc2vkEgs5Pp7pnDF60W8zrCwME0cZq6yzmPBvEV8=; b=o9Pw0AMJYlalpLx3Ieh0okCs6dxUF1RNwSSkSV2T4mIPMOvT0EYfDk5EM2d12q5OHj YUQkbOyqpj5vAHKr3c2ACrrTdybOao8C+OYu+8ps08xLzO/1otya+VZ/GtJkeEXFknCs m+HsCOCIN+dTb99+C3q1wMxwSw4hT+Annw3dzZzeNnYs1lk0IxgMWMSyrTZOJ+Kompt3 r6wKos1+mGWlzQ6IqmcugX9WGr8egXMDmy26Tc6ugcmK7uPJ0zs3sSEdE0wnfxZdWRbt KInjtBveC4ZJqO8oFqcXSvKOBj/Y/twErax12dD2Ec2B3VZKdtA1XAQ9qKL2t6pf5ykr +KMQ== X-Gm-Message-State: AOJu0YxUMROWDnNA/jYZVSU76io/3+BsttML6GtTXlBwiQZT0rTIGtzm XiMkkEjncNfNvfdOngLoqosSBbDdyOYVAQdkunH87Re1kVuNmG40ug2eyQ== X-Gm-Gg: ASbGncufX2LV341pRhI0l+FcmP3q2b+hN4T9mU15/0BgPt/Wh6dZw2ynHyNdPwc3DLR 4UCIG7QZYvK2TxxJ2EMcnT9hUX78n8YL3MYlSUudHhgNbv20IzJtJ0o6MHQ8FyvGNEi+wTF5v5R urzBQTljglZLcJlpgHPUeNcV1zR+sCUQ8bdDRLNrH1f1hA6K9tohKKZgqO6rXxsNBYTXRxOdbNk 79xk5sPYLx4jaqfC6hR2OAgAaVbTcPDEkdnmCexeso4Z44hGDuYH5404F3XSq2c9Np4kixMYkbB K3Yk0xvdePKoskGyezObpUnQKxS9nJVnaH1lcl1veU4tk+fC X-Google-Smtp-Source: AGHT+IFuXVplZTOidf6+FbrRWr0dJRuZPWucGNDLvhwgjrSV8lGvzy/PXtUkpXLhq4PmLDOpeMhA0A== X-Received: by 2002:a05:6602:3c3:b0:84a:78ff:1247 with SMTP id ca18e2360f4ac-851b6286c35mr3044417339f.9.1737787618790; Fri, 24 Jan 2025 22:46:58 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:46:58 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 20/63] dyndbg: drop premature optimization in ddebug_add_module Date: Fri, 24 Jan 2025 23:45:34 -0700 Message-ID: <20250125064619.8305-21-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The class_ct var was added to avoid 2 function calls, but to do this it loops over all the module's debug callsites to determine the count. But it doesn't really help, so remove it. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- lib/dynamic_debug.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 067db504dd1d..16c9b752822b 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1284,8 +1284,6 @@ static void ddebug_attach_user_module_classes(struct = ddebug_table *dt, static int ddebug_add_module(struct _ddebug_info *di, const char *modname) { struct ddebug_table *dt; - struct _ddebug *iter; - int i, class_ct =3D 0; =20 if (!di->descs.len) return 0; @@ -1308,18 +1306,14 @@ static int ddebug_add_module(struct _ddebug_info *d= i, const char *modname) =20 INIT_LIST_HEAD(&dt->link); =20 - for_subvec(i, iter, di, descs) - if (iter->class_id !=3D _DPRINTK_CLASS_DFLT) - class_ct++; - - if (class_ct && di->maps.len) + if (di->maps.len) ddebug_attach_module_classes(dt, di); =20 mutex_lock(&ddebug_lock); list_add_tail(&dt->link, &ddebug_tables); mutex_unlock(&ddebug_lock); =20 - if (class_ct && di->users.len) + if (di->users.len) ddebug_attach_user_module_classes(dt, di); =20 vpr_info("%3u debug prints in module %s\n", di->descs.len, modname); --=20 2.48.1