From nobody Tue Feb 10 03:44:57 2026 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99F3B20ADF1 for ; Sat, 25 Jan 2025 06:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787619; cv=none; b=S/VpbU0DauRzVn/9uT2sBGkPTObPmz6GafsMGDOpaQzu0QJqAYN9o2rN9O2QYExeEG8x9wx6wqVxTRy0AxEnHpuSGRBMSXvX7mK/L+XVrdu4jNrneaFBeJTfqq7suApIAc6P5415MKUI3/f2dbxrXMr4joz2/XSrssXcbQ8kSQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787619; c=relaxed/simple; bh=/mjj5vb73h1xa52yXHBUdaYr2Mt3vtwDdccGK4k6mus=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CQnz//iUyG7ZyHkOwnHnZ5XW5sb79kBHGuzHnMFmy03s4aUD6LdDc0nJyMxZmeQEC54oSqrWTMrX7NTJM38HlA8t7+7x7FS7zb6gIGbSPqkhB/1E6OhuztMiKTKZvprypTo7dpdjI016JYB1GGv6eaoyJyTvuzKx5qCMoDPLiEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JTRPC7Ho; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JTRPC7Ho" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-84cdacbc3dbso225267039f.2 for ; Fri, 24 Jan 2025 22:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787616; x=1738392416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4426qb3gIsTZka2SxcS2AqXLzVLPKaaERHnBDYOLWSA=; b=JTRPC7HodwZSpJ6D86nTlzNHk0lxF2Pv+JLxSJqIR9htMXWely2sL6TO8lvdSL+cqR dwOXmEiY+nn2yoCssDK+/+hb0TuAsNOiDEvR8Qw7U8ISYpf4+kc/rasEFXUmHMmfJOC8 iHSEE55yftkV0KmfMXLbr0ykxvLSvfOq/hg+GZZFHoW6B8RYheHONzwE4vFIgiuaJQwK QIUPiF3UHCZvHQgN6EMIWYWvCOmsqi8wHrn831wAm1wvsAGLzcriWmA7szXR/xyXMb2z VWOxYAE98HyhHoR6jd2KXAb/NfoLIKA8NECtfGxVXgDqkJXTC/nOJItjPq5kKFtOhBqR iLOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787616; x=1738392416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4426qb3gIsTZka2SxcS2AqXLzVLPKaaERHnBDYOLWSA=; b=waXCvnGKNeT3/GfQR8eGf0Wleznaz/7lSjS6+A+dmX3wYy8XPW36XxL7xpc+nlsxaW yfDzGbr/l3r3pB9HWRUHzqI2G6y/GYuhsWRD3ZlPv7KOzRGCVVWnu0kICTMgAUiIK7O6 xFPyvpSYCzGd/XN9UVJaH194WzQWVI1Ls7zN709dabJ7wuaVEBgya4WKq1N143H7QGx4 y1R9ZzR0iPN6Cl8s/QZR4NmPpL4IHCT3B/+xTvVb5cZGVNDFgpN6dwFJ6qORBtytgMzY tMZoMXZLpDOXoE0fe+c9hkvB3Nw6HEWG+I5SU7Vh+JENQRmjfb4Mg2kE67l1TIvIbCuk Nh/g== X-Gm-Message-State: AOJu0YzEDK9FVfANSRVJg3ejQnwagURTHidcp4jk34coY9hhmsebR2ei wvKCfe0Tk7hSdHtr0eojUJDU0k20Xh8IKukB7DrKCjvn5o+oq724C6L0BQ== X-Gm-Gg: ASbGncv8y0bpWpw957ouss9qnpEx9AW+ZWw5re9YJ9Vat2NMw5e/hOT9x1fVHUp9WrJ OCGxeWSHzmTzd6L4E3c2nWHMpgqNFf5Y1roPZQRxH0K/D+OX71C0lHQqNFrsXBqgriRfLYfvqSj hPc0UlXDaxycWTTXRwTTbiB4z/J20iPnIChztmsDuTcOrA/Mvym1G+rKiMPVhdMzkyKDBzkS+5t WVtei72VQ1Ui9t8SK5U7Im4pNbhmSfapy3334ivbD8dBKYsIq5mh252vnEbYIv+G9gKi1a9TuZO NLDlYZMn99JmkFFxlV8/lo8b6lb3GnsdFDJIKj5Lh2L6RLpw X-Google-Smtp-Source: AGHT+IHPcwCIcEeaDfvcsC8Y0hmazgAlIp69PtLu+D2gBA3Q65N9zrEn328wJ16fD3PoHPmaHxXlww== X-Received: by 2002:a05:6602:2d91:b0:835:4cb5:4fa7 with SMTP id ca18e2360f4ac-851b62b1c79mr3161173639f.12.1737787616655; Fri, 24 Jan 2025 22:46:56 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:46:56 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 18/63] dyndbg: add/use for_subvec() to reduce boilerplate Date: Fri, 24 Jan 2025 23:45:32 -0700 Message-ID: <20250125064619.8305-19-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" add for_subvec() macro to encapsulate a for-loop pattern thats used repeatedly to iterate over a boxed.vector of N elements. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- lib/dynamic_debug.c | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 6bca0c6727d4..08b6e4e7489f 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -158,20 +158,34 @@ static void vpr_info_dq(const struct ddebug_query *qu= ery, const char *msg) _dt->num_class_users); \ }) =20 +/* + * simplify a repeated for-loop pattern walking N steps in a T _vec + * member inside a struct _box. It expects int i and T *_sp to be + * declared in the caller. + * @_i: caller provided counter. + * @_sp: cursor into _vec, to examine each item. + * @_box: ptr to a struct containing @_vec member + * @_vec: name of a sub-struct member in _box, with array-ref and length + */ +#define for_subvec(_i, _sp, _box, _vec) \ + for ((_i) =3D 0, (_sp) =3D (_box)->_vec; \ + (_i) < (_box)->num_##_vec; \ + (_i)++, (_sp)++) + static int ddebug_find_valid_class(struct ddebug_table const *dt, const ch= ar *class_string) { struct ddebug_class_map *map; struct ddebug_class_user *cli; int i, idx; =20 - for (i =3D 0, map =3D dt->classes; i < dt->num_classes; i++, map++) { + for_subvec(i, map, dt, classes) { idx =3D match_string(map->class_names, map->length, class_string); if (idx >=3D 0) { vpr_dt_info(dt, "good-class: %s.%s ", map->mod_name, class_string); return idx + map->base; } } - for (i =3D 0, cli =3D dt->class_users; i < dt->num_class_users; i++, cli+= +) { + for_subvec(i, cli, dt, class_users) { idx =3D match_string(cli->map->class_names, cli->map->length, class_stri= ng); if (idx >=3D 0) { vpr_dt_info(dt, "class-ref: %s -> %s.%s ", @@ -1190,7 +1204,7 @@ static void ddebug_apply_params(const struct ddebug_c= lass_map *cm, const char *m if (cm->mod) { vpr_cm_info(cm, "loaded classmap: %s", modnm); /* ifdef protects the cm->mod->kp deref */ - for (i =3D 0, kp =3D cm->mod->kp; i < cm->mod->num_kp; i++, kp++) + for_subvec(i, kp, cm->mod, kp) ddebug_match_apply_kparam(kp, cm, modnm); } #endif @@ -1212,7 +1226,7 @@ static void ddebug_attach_module_classes(struct ddebu= g_table *dt, struct ddebug_class_map *cm; int i, nc =3D 0; =20 - for (i =3D 0, cm =3D di->classes; i < di->num_classes; i++, cm++) { + for_subvec(i, cm, di, classes) { if (!strcmp(cm->mod_name, dt->mod_name)) { vpr_cm_info(cm, "classes[%d]:", i); if (!nc++) @@ -1225,7 +1239,7 @@ static void ddebug_attach_module_classes(struct ddebu= g_table *dt, vpr_info("module:%s attached %d classes\n", dt->mod_name, nc); dt->num_classes =3D nc; =20 - for (i =3D 0, cm =3D dt->classes; i < dt->num_classes; i++, cm++) + for_subvec(i, cm, dt, classes) ddebug_apply_params(cm, cm->mod_name); } =20 @@ -1245,7 +1259,7 @@ static void ddebug_attach_user_module_classes(struct = ddebug_table *dt, * module's refs, save to dt. For loadables, this is the * whole array. */ - for (i =3D 0, cli =3D di->class_users; i < di->num_class_users; i++, cli+= +) { + for_subvec(i, cli, di, class_users) { if (WARN_ON_ONCE(!cli || !cli->map || !cli->mod_name)) continue; if (!strcmp(cli->mod_name, dt->mod_name)) { @@ -1261,7 +1275,7 @@ static void ddebug_attach_user_module_classes(struct = ddebug_table *dt, dt->num_class_users =3D nc; =20 /* now iterate dt */ - for (i =3D 0, cli =3D dt->class_users; i < dt->num_class_users; i++, cli+= +) + for_subvec(i, cli, di, class_users) ddebug_apply_params(cli->map, cli->mod_name); =20 vpr_dt_info(dt, "attach-client-module: "); @@ -1299,7 +1313,7 @@ static int ddebug_add_module(struct _ddebug_info *di,= const char *modname) =20 INIT_LIST_HEAD(&dt->link); =20 - for (i =3D 0, iter =3D di->descs; i < di->num_descs; i++, iter++) + for_subvec(i, iter, di, descs) if (iter->class_id !=3D _DPRINTK_CLASS_DFLT) class_ct++; =20 --=20 2.48.1