From nobody Tue Feb 10 03:44:57 2026 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 564B520766F for ; Sat, 25 Jan 2025 06:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787608; cv=none; b=FGwFAGywfEM7ffS22SFeG+GXEeDlin/vMRt+RRqwFv/Epy+wRllwel1o6yI5KfQL3oDAa6NT+aWwxs3SSjTeDGQzwkIh/0dfPyytqwgSwz3PtCZwmtVkWF1oZgB5CSZydNSC7nszR51Id1rMS7iPuyUU43JAfIIOH9pnKyIB5XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737787608; c=relaxed/simple; bh=+yNUQPcNx2B0khJfCLCdnontyBw4RL0qgAiYMHJUBHA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hPTt+ecONNCGiRgMBevXGpzKhlgEDvrKxpP0LyfY/vtDxHq5oB2ous4mA+JzNV8tsrm4DGRkmOd1OYIYd4+4vIlLkGo/Fj6/FIdudDRhQ0kxop7RZcFS8ZFiokzpPVI9SXDZSx2IoNeEx8HwMIcelLH1w0IXFXnKElRhWqC/Ubs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DMmwZfui; arc=none smtp.client-ip=209.85.166.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DMmwZfui" Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3ce6b289e43so25367675ab.3 for ; Fri, 24 Jan 2025 22:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737787606; x=1738392406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=crImgp1y7IRXSUD7oHrqvuelp6vlR0pAkEGBI4jI/u4=; b=DMmwZfuinXpd2HUSWh7D9EI+FH0Omd7Mz9IuAjDlIXcwHs69Y9Z72tOZMtnhsayhrF A5KLE7yT7au7Tbbdy7uNqyAdrhnZf4tOciWVSj9TFCFffS9lk7cHZKtfDjWiBFQheqTY vRi1Gg/XvlfzLYjZqjmEmHpOzsq6DBWYcpIQLc3wMp7tQeg4yYHEWhG80H05FcI8kstE G2pcTdSuK60tGUxJ5Ib5Ujt/VMyAWbhNGZB7wBSLke6k0kvvRhxJBsypB+7r7zSnKmfi BUOn8F3YrfqGV5TtMlIeqC+LKGoBUt8cgiy40faAX/+2KRJTYQmzKSWlnGin/Id+D4kv iZTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737787606; x=1738392406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=crImgp1y7IRXSUD7oHrqvuelp6vlR0pAkEGBI4jI/u4=; b=k+t9HrVgUUtwMI0Vq9BC5COtOnXRw3OEOHbAKE0ZgmBMgWo0/pPkTYo5jmBzzCofss bHjpSD5GitnTjwnT3li9tC3APGJbT4Hn42u4FI2Kk5KB40H3SolaT5uYmFKPdUZdUBXh oTsZxMG7SGJqBrHgUhAUDf7EXhlBsPLp0QL7hXQD/JLbh4VnXQv35DF9twrQpphNnzMU W4kyfDep/uQ/QIozSkNbwl/OW1FGI+UdhGzLo+hbdxnSunuXaMnXT8tRDFamnMC5Jw++ 8K6jdpS6H8BrxpBBnPt/Wvu3WsoYQt1z5kp7Kk6eRyg6Mr7Qu25n4t29F9v2u9Hyg9L5 t4hA== X-Gm-Message-State: AOJu0Yxa+PlodTDXauHpRfraAqHlF1Z/UQSpC0DhfN4KSw5D8gt/XMV/ wTSU9yzBtpaXm+AAHfNwK/ZgbimNIBx8mvhGWXYzjEmsQ5g8tAintpzeBQ== X-Gm-Gg: ASbGncvkiyNp3SE46QiAEAIP5AlxTdpOVr+/s4TQtXiklNYDu2tV9j1LyJKBp+8Rwoz wK8oWrBuQHLcVuHJwpegcIYyclc2RfJmhO/+HcXWTl1XlHj03CaVRrOHU/i4AaBG+Y4U/g43f3W XknblIrvIH5pg4A15KZpWr4EhbjoTUQM/3ss3vdHghVkLXiAEfrQxRV47zMylWO1OjZw2/jV/Yi BIMMZYI6Vr6GPzQL47E8myzWWyR15sVvWV+3ioNcmd8YAsb4x7MIwEPZyM4Qa+jCr/sYK5o9lUB awkfocz5M4W3tUZCGe7GzrXjWF+yaVHLg+B0PQ== X-Google-Smtp-Source: AGHT+IEjjwWoWaC2eqRVAIRwzEKW3d0rVEFuGJkXw2+P/hMoxb83M7t9s2BDslJJbs0hJxkgZgzZdQ== X-Received: by 2002:a05:6e02:fc5:b0:3cf:c558:3594 with SMTP id e9e14a558f8ab-3cfc558384emr50346105ab.2.1737787606321; Fri, 24 Jan 2025 22:46:46 -0800 (PST) Received: from gandalf.. (c-67-165-245-5.hsd1.co.comcast.net. [67.165.245.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4ec1da476fesm1174144173.58.2025.01.24.22.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 22:46:45 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, Jim Cromie Subject: [PATCH 09/63] dyndbg: reduce verbose/debug clutter Date: Fri, 24 Jan 2025 23:45:23 -0700 Message-ID: <20250125064619.8305-10-jim.cromie@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250125064619.8305-1-jim.cromie@gmail.com> References: <20250125064619.8305-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" currently, for verbose=3D3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' dyndbg: flags=3D0x1 dyndbg: *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: parsed: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0 c= lass=3D... dyndbg: no matches for query dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' flags=3D0x1 *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs no functional change. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- lib/dynamic_debug.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 9adcb9fa7110..1b2fb6502e61 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -266,9 +266,6 @@ static int ddebug_change(const struct ddebug_query *que= ry, } mutex_unlock(&ddebug_lock); =20 - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } =20 @@ -501,7 +498,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op=3D'%c'\n", op); =20 for (; *str ; ++str) { for (i =3D ARRAY_SIZE(opt_array) - 1; i >=3D 0; i--) { @@ -515,7 +511,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=3D0x%x\n", modifiers->flags); =20 /* calculate final flags, mask based upon op */ switch (op) { @@ -531,7 +526,7 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) modifiers->flags =3D 0; break; } - v3pr_info("*flagsp=3D0x%x *maskp=3D0x%x\n", modifiers->flags, modifiers->= mask); + v3pr_info("op=3D'%c' flags=3D0x%x maskp=3D0x%x\n", op, modifiers->flags, = modifiers->mask); =20 return 0; } @@ -541,7 +536,7 @@ static int ddebug_exec_query(char *query_string, const = char *modname) struct flag_settings modifiers =3D {}; struct ddebug_query query =3D {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; =20 nwords =3D ddebug_tokenize(query_string, words, MAXWORDS); @@ -559,10 +554,7 @@ static int ddebug_exec_query(char *query_string, const= char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound =3D ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } =20 /* handle multiple queries in query string, continue on error, return --=20 2.48.1