From nobody Mon Feb 9 07:56:33 2026 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4CD323B0 for ; Fri, 24 Jan 2025 17:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737738033; cv=none; b=exiWQv3qLU2h3AdtlNYHSqoa7F1Rw6zeC4q11J2iLS00Ydm6qPK1ZO/FvANzyOh9/Y2KY/Dl+UeV6A1PjjTDr/cB/cDdXU2BLNjRJL0JCaYv2I0HDHLz+GYyHIaQd5qey9iloVBGZ00xpV+6J1h28+8j06xoGeOb426hDetWzws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737738033; c=relaxed/simple; bh=+lPYEFvq4bDQAItyloIxHD7ZFAQQwsx+bcxN+XKbuuY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mFaZwAdMqm74rTmLwcSi+oOo4qtp0lDveNvCUgOVumm+5Ubm1WmtFYO52jNyvQUfUSJyLTwO+JBfCJ+LhHiaH1wj9tSd8bI1kI8OctXUHkvuqgye8FfPt/dLblTGAWYBpFcmUdTh5AduuKPXKhZwK1qeIU0DvYxLXcDrpQwGJjI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=qxO6VbNG; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="qxO6VbNG" Received: from ldvnode.intra.ispras.ru (unknown [10.10.2.153]) by mail.ispras.ru (Postfix) with ESMTPSA id E1DB340B2269; Fri, 24 Jan 2025 17:00:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru E1DB340B2269 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1737738028; bh=Hhj4Iw8Xku/8T4T+5kZ+uaePDuP74yZIrW5ImoLkSiM=; h=From:To:Cc:Subject:Date:From; b=qxO6VbNG+GkHkc0XpeGe3AxKClIKOYbtSG1Ak/6abMAzYLPFojlTTG3R08lwCxf4w HlVpdWgRpcmAK35tk+23HLTspqeTkSXB83OSnE5y0vxm9RMXdtn/t3T7hUcZpPD3lQ VlVtC2PYJZ2XEpXc76g/gaK1bCjXw1obVtnNG77E= From: Vitalii Mordan To: Andrzej Hajda Cc: Vitalii Mordan , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Sui Jingfeng , Aleksandr Mishin , Tomi Valkeinen , Quentin Schulz , Yuti Amonkar , Jyri Sarha , Swapnil Jakhade , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Fedor Pchelkin , Alexey Khoroshilov , Vadim Mutilin , lvc-project@linuxtesting.org Subject: [PATCH] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines Date: Fri, 24 Jan 2025 20:00:09 +0300 Message-Id: <20250124170009.2075175-1-mordan@ispras.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not be disabled in any path. Found by Linux Verification Center (linuxtesting.org) with Klever. Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP = bridge") Signed-off-by: Vitalii Mordan --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index d081850e3c03..3e923bcfb0bf 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -2504,7 +2504,11 @@ static int cdns_mhdp_probe(struct platform_device *p= dev) =20 mhdp->info =3D of_device_get_match_data(dev); =20 - clk_prepare_enable(clk); + ret =3D clk_prepare_enable(clk); + if (ret) { + dev_err(dev, "Failed to enable clk\n"); + return ret; + } =20 pm_runtime_enable(dev); ret =3D pm_runtime_resume_and_get(dev); --=20 2.25.1