From nobody Mon Feb 9 17:06:32 2026 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 759722010E1 for ; Thu, 23 Jan 2025 13:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737637478; cv=none; b=AR/Sw/rSx35lTjZQ435wXMdR6MxjDrbMvnyhpG3Z0AMQEGmMv5pJVycjgVbd3UbcKgmZW5vtiGbZUGzOeZfbVvZhzPa3lGiFzdfPSraHIWbpaGcV0yqa0zw+er7+kOYg91c3l7lEv73/rbjp5rb7hvoQYlh27mqh8XfPU3n8S3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737637478; c=relaxed/simple; bh=/35FndFEwMXImG68FaVoeYjyhiOzUw2D0zQACMlI2n8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=QBZW+qgrlVQrasI4JIE+VwmB8UmcaLaom2AUec2ZGktFgj8jCB0A6b1SEBDSArmA030dgAuJiSJxojJTimfu2MiSkXCz4mt/Miklr/dvUs279PsPH//sZUidhacf8ZIM6baGt0o1P3XdGLla7erOm/+ZxcaWTQ3c+9g/inu/PdY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=uHMgrnQG; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="uHMgrnQG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1737637474; bh=/35FndFEwMXImG68FaVoeYjyhiOzUw2D0zQACMlI2n8=; h=From:Date:Subject:To:Cc:From; b=uHMgrnQG08eg3z1P8n6qMIV3xLWia6/zVtlJAtt+uiJGM86cszWVxbPEkZK5HdvHj qMIcRCZwsClaD72L/BLnIGEI4fhmCX371sDOfxNbxS/OMLHoQko0s3Eil9Llz2SXTO rxhYr6kdHrvjB8IssXolk52IhcNb7R7GGdoIwA9U= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Thu, 23 Jan 2025 14:04:29 +0100 Subject: [PATCH] tools/nolibc: align signature of ioctl() with POSIX Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250123-nolibc-ioctl-v1-1-93f8bca99de5@weissschuh.net> X-B4-Tracking: v=1; b=H4sIAFw+kmcC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1MDQyNj3bz8nMykZN3M/OSSHF0D41QLs2QjAwMTy0QloJaCotS0zAqwcdG xtbUAeLOYdV4AAAA= X-Change-ID: 20250123-nolibc-ioctl-03e86c20049a To: Willy Tarreau Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1737637473; l=1593; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=/35FndFEwMXImG68FaVoeYjyhiOzUw2D0zQACMlI2n8=; b=toqHc2povNHow4DiVwA6d4DQohSmW379oI1D4zH+C7w8IDvSqHSAeoKFx7gc+YXPJ9LsFxaWe z3Ney9ZbXQtCrsj+ju/HNYGZ/GPc2ulvKtyLcSTGsl150+NevIKAUvU X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= POSIX defines the signature of ioctl() as follows, to allow passing a pointer or integer without casting: int ioctl(int fildes, int request, ... /* arg */); Nolibc ioctl() expects a pointer, forcing the user to manually cast. Using va_arg to make the signature more flexible would work but seems to prevent inlining of the function. Instead use a macro. "fd" and "req" will still be typechecked through sys_ioctl(). Signed-off-by: Thomas Wei=C3=9Fschuh --- tools/include/nolibc/sys.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/include/nolibc/sys.h b/tools/include/nolibc/sys.h index d4a5c2399a66b200ebf7ab249569cce2285481a5..5cb2c66cc8cccc4d4a1126acfd0= b30a6efc886c3 100644 --- a/tools/include/nolibc/sys.h +++ b/tools/include/nolibc/sys.h @@ -532,7 +532,7 @@ uid_t getuid(void) =20 =20 /* - * int ioctl(int fd, unsigned long req, void *value); + * int ioctl(int fd, unsigned long req, ... value); */ =20 static __attribute__((unused)) @@ -541,11 +541,7 @@ int sys_ioctl(int fd, unsigned long req, void *value) return my_syscall3(__NR_ioctl, fd, req, value); } =20 -static __attribute__((unused)) -int ioctl(int fd, unsigned long req, void *value) -{ - return __sysret(sys_ioctl(fd, req, value)); -} +#define ioctl(fd, req, value) __sysret(sys_ioctl(fd, req, (void *)(value))) =20 /* * int kill(pid_t pid, int signal); --- base-commit: 21266b8df5224c4f677acf9f353eecc9094731f0 change-id: 20250123-nolibc-ioctl-03e86c20049a Best regards, --=20 Thomas Wei=C3=9Fschuh