From nobody Fri Dec 19 21:51:33 2025 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2049.outbound.protection.outlook.com [40.107.96.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB4CB1FAA for ; Wed, 22 Jan 2025 09:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.96.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737536735; cv=fail; b=n9A9vOaekWSykqS/sJlk2QIGrtM/Q9ivknC2eVX6rLPI1BtUQZVA2TClwCj4IKcevMJOs+N7iHITqkLIEAmHj0z5q8BxiAj3jdBZqGDg7q3EJcIs7+UcPXeXrUlphXe41YkJdgwPcgB6LrtLIboR0BH6Jvg50g8ZSBu5b8sSMLk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737536735; c=relaxed/simple; bh=ndvsskHMjMsI9/f75SQAlVAvHq2f/bXxDNUvfbQ5ZM8=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=Z/8XPR/qJjFcdCXHeob8Zyudbdz7K6vKIHthNmZuzLzSY5TcrCjeuNurG22BNSI5ZS5wfYe0j3nTR/O+zgQXaUPGg9riWR10Arxc9jb0O5Cz8D6yzoQyvIAwmcB5pd9DBQ7dQerL7JNM6DQIvoVtl9DB8mJD8ppGSehKjEq74ls= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=F/FQfW23; arc=fail smtp.client-ip=40.107.96.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="F/FQfW23" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ewUGgafGKqNEuDujhmOTpN/fSZYmwpHxPe+mD8clROJ08ZA76HwSOnObywGrgMniidg0LLZhfaYABOM8NI72Y3T1J1sMVotf7ZMaT+gr16iLm+RBlSsY8DgBlUaeVjYdVaLTiSHwZe7QZBmvi5i5JYj3nBVYfPhpCS9NsJK5EREOg3MB3+qVcPwvPGlOy+dVedAGpIcAPmLYq6CKdMBYLuZgeM9d17y57aZ9f6mJ9Yg7ap6CJe8KLvErgqE2G9nOvhKpZ5H+3mV+MlvtNYGLVVUCmg1xZESnXaP/KwaVwDkyqLN5CiGt+5Z1ND5el6bpbv4OblcQ8mb69vx3GU9auw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XW/ZOtzZsAWFZBUuU26dbGohWs8WIIcAivh0qonoAYc=; b=y9cOzSXogsa7XVyO3UGY8nH8DDz1zu5lps3IXgH7nfIE7Medr/ksAWtx435sgCIBz2JfPknCgJ/2x3jkwAWyHz5endopAJjz9JCR/SWl+rGShHBgmd5bF68vOZlm8MPturdiYtQw+88r3WtwrO7rxdzw91kZNGILcV+ldjTwiAI41RY41frUULrxNfYUZsp1cTI+e0wXnu9cx3qSru9qgLhpZa+jhfiM7VCqux1MtrzfkB9WTmqCFr2Ygw6Ns68ym8cfZc8fdQs28XTCX+/gEki6yitIbYrFuMc8mJPEwlsWQHeugR7rjCbmDKj4hnNwYKCh6G/LvopXpLotjoDMZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XW/ZOtzZsAWFZBUuU26dbGohWs8WIIcAivh0qonoAYc=; b=F/FQfW23p1VTV4nV2ZwDevHOBl4/GTUNu3spBPgZR4f8VWPI0pKK1yBVYFr7Hqaq45Rg3M4BwLb3vRSRyVnR0SUeoll96XnICR0FrcTUEHLGb5w9/fjQ2LwhSql8K4G8Pvzdq2j7C3bqF8E4QLzM0bGI8PorAWsFv3BjfoJvhEUuW9IsSrweYj6PieGmC77EyzPfm82VTZh0Ox1S9MlQNfi5gV15l4poOIxsHKgMy3/ze8NTuEAQtrs77HS8R1+a9n5tSzO/t4Pf6q3YdlkKEKgswQ18tqRC0EsQ5wXmK6TJsb4m/Sn2lghbUO1/tgDaUgexYxYUmtDtFbX5I4tB+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) by BL3PR12MB6545.namprd12.prod.outlook.com (2603:10b6:208:38c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.22; Wed, 22 Jan 2025 09:05:30 +0000 Received: from CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5]) by CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5%3]) with mapi id 15.20.8356.020; Wed, 22 Jan 2025 09:05:30 +0000 From: Andrea Righi To: Tejun Heo , David Vernet , Changwoo Min Cc: linux-kernel@vger.kernel.org Subject: [PATCH sched_ext/for-6.14] sched_ext: Include task weight in the error state dump Date: Wed, 22 Jan 2025 10:05:25 +0100 Message-ID: <20250122090525.328698-1-arighi@nvidia.com> X-Mailer: git-send-email 2.48.1 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cc::13) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6405:EE_|BL3PR12MB6545:EE_ X-MS-Office365-Filtering-Correlation-Id: a172f614-a631-4484-7d89-08dd3ac3eb72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?31epPOPuP54je4Whg748lbk95eJTx0o5Ue47fhFHn0TDA1cZUnYkCPnXaNoP?= =?us-ascii?Q?C+eGQTsJiR60klhFWyBaaGHe9WVaL2Mm5A9yTVx0zsJs2tgmm7BPlXbuEVyk?= =?us-ascii?Q?TDDrhsbcWcLvnSC90BN21Pb6pxM5GSoNpbz4XW6dtkdX5cIPY/sNKJ+aWThG?= =?us-ascii?Q?w4SfkKh5N5ufqgm4nW5epF92TVC/jBOeHtUdb+XpDRYFQulTVUmuuN1aho2Q?= =?us-ascii?Q?szPIMVDHafX3Q6TcQ12q0izjTX2AOAdiPmEVgQS343kbW+8g9azmoRk7ekTi?= =?us-ascii?Q?0cuNY6RmLvH1UGLxH3lzQV/iXSB+85IvAVQUFsqjeT0jt1z7/66YLxP7Wmda?= =?us-ascii?Q?h3ES7uyC2OGiHbeD7BO0o+3CCXk6Se1DruubwnuVHLJllsEXvXmgQmLtTBBV?= =?us-ascii?Q?9J9BDL6PSGml0NfOAn8/pTFNywgtJzwHBEcdZshOeoUr+X0uaEpYZUG/Z4Hp?= =?us-ascii?Q?lMtayXw3+GDLmx1Vp1ow5SVo3wwLjS3tyNzJcjZrVKBvx9NqHJjsQO9y50oP?= =?us-ascii?Q?KSY5H3L29+VgYuT0FedtQxzNMbkZMS9qd5OnWcW2E4u1Nvq5Mi9+gjXXr7zk?= =?us-ascii?Q?aEFmWjROyQfO3iYIAq15E78YPzu71vaQQHwrJs4/2jWHTviaVHnW0aKnBjVa?= =?us-ascii?Q?RVNJBjcWuSz1uN4b9x3KNjCgh/tQuMJV5GGGiBlD9MpRfbecAEQbRuv04TPc?= =?us-ascii?Q?jCfmgJGpLeHygubWNilupdYeJGiPkJyLhMZH2RyaXp4s3DJv0fJOGP/OZBXM?= =?us-ascii?Q?36JB5ZbX93bs7Ve3rJduuulk4m6xTymUzQKdQPEpLEBoqf6JYQLLx1Hw/NNr?= =?us-ascii?Q?36Dl3/FufyEdnxOUeLG6aOyggf1rkNSgr9TbQFL/+peoo0vDjkiX7C5xKMK2?= =?us-ascii?Q?3q8fS0MI1Vau7l8OAsdMfZ4jHJWX9o8txVaJUzuYBecYvTspRSWEPRtKb61/?= =?us-ascii?Q?rczoIHtRD3H+7vV4ZajJqOoIx6R3IUp2pXumC5mepUx3O3YK1QbRj9/6v7WW?= =?us-ascii?Q?5Ta9PGmONLdwtiwhUEH24lPgbdl0NK7XuAwv9fmr2qQeDawy/dp90ErO5Vtn?= =?us-ascii?Q?JhBcSx2hbtpFRE4/YsHZonOSt2aDMG9Tdlx7cQREhP/BctoGBbwoA7z6Dgh2?= =?us-ascii?Q?fpbZXOyHzGE2Pj5lI5NivuOznUbesn4QmVJpAK4tVOTlUvIEGXXhDNOzIRne?= =?us-ascii?Q?uUflVwoMGUxXa3yP/mqhp3uqkPvbpGgTQ0C+dwVNBKAuNtTvm53Yme28WE0j?= =?us-ascii?Q?1cWmyYTXTB1hzKT7sTL6N0phBGVEfrT2gP2Hp31X9CecSqL2SgrXhXTrWpft?= =?us-ascii?Q?xXuHd0F8pxswhD+QEIQ+qQc4DbeR+lC5DDBnNyr1I7fU2Kxf9Ov8aRfu7Hx9?= =?us-ascii?Q?ND0aq0skfetYGQQeKfWzREqNWrG7?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6405.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r0eTSjEre5ViPmYRuu9jTmv0CX+NV1ofMRo6dCFHQz41wzUsyvY+z/WyGIIM?= =?us-ascii?Q?8xtX+rtz7jyrxN426JDny2Fr78sggeNUj6CUkIGMKDXdw4kU88nlbzk3VOuq?= =?us-ascii?Q?6OGvwT408yiPf9q1oASn0pm5vXeff/GEmfwfKwTjHqxJ1EEAY18snPwt3Mwb?= =?us-ascii?Q?sv0yBSRdOHueoqKCfBd3C28G4Wz6fl5Ggkh7JM7Lq7f8/nqxD/5Vya5/NsBJ?= =?us-ascii?Q?fnUdB47nPiTmQRrOzYB6z/sHcaqoTAo8WTzmnvfUXyShEWPdDYtW2UMv5aJL?= =?us-ascii?Q?4eCh0jru6y6xvrokzdwomcCFq3CnxfXY8VS6O7iu0YDoYcIQhILTdItcEPtl?= =?us-ascii?Q?ZQf3If9icO2HV9Bze2STixQGZ0JigaF7MJneRGzUfRCuKoAokNx3k8NcUPgs?= =?us-ascii?Q?kKWze0b81rFDm1IAMfrIizBrM4wcZPyU6YAHNAds005RCRGtm2ewM28F+AOR?= =?us-ascii?Q?/dcYWCDXXoFSiqQpx/BVmADmDyZFI3nXZfmqAwUTwNeCZRqdq/h8IvTKD/lq?= =?us-ascii?Q?eVZ1gPKEyuRuM6Insuq2QKY3kSndtGkWBw5QtUO0YVo9EGSUnIzG7TwEMMXA?= =?us-ascii?Q?OhLRp2HgNEEq7IXe872WZhojXVO+JkZnEtOUgZahG7Z1JgC/ouuKq4CQpQ5N?= =?us-ascii?Q?9TIlEVUt/NP0wdldRo5/Wut6oRkY172s1aw2s4aBhxKT8/iTtBIi+CKHuYfl?= =?us-ascii?Q?Q7lLT+bxlgL4OeRHm98EjENw1jlHLmv7yyBNcfCbuajaeBD3DgP5bBu1fHLK?= =?us-ascii?Q?3ZlBa10wHCiRS2PIrN/dEoYY2cpYAjc6wfCMrPOROPLbGLPSm283HA+xvFsI?= =?us-ascii?Q?y6fRLWQHcWeV7qYFZ546YgjijvasPsUD/zyiDLDZxeVBX5KKHlrpimUMpKGt?= =?us-ascii?Q?xr8udtPkKWcngAx0wELwiVTNj1PBhBn0h0IsDvmUVYH980W3oMPnHk/PBJqE?= =?us-ascii?Q?QnMmv8ygUG2JVxgJS6/M7TnT8LLDQtoNbXMnGxQ5WlVSVgVlL0htEvcUl6aU?= =?us-ascii?Q?CDl1TbMXYwUrYScJrVqN7EB6jedmzRHM3Ba2F+YGqE3bHOZy78mOKPqkDmce?= =?us-ascii?Q?bZpgbx9zK3z79iisU0qjmCHxlWHRq4gXR8tcLbl8WdAELLOHW/hYOxseoYmF?= =?us-ascii?Q?jj1bdFk6LgsXubl+F39tsrG4ubtbscDLemxU2Wl23iPE53HKTG7vuHn0aZs9?= =?us-ascii?Q?D6TLDLHour1nzAxCeDnvF8S0elIzu72HQtmytumb2eoaD89dMvFGu4LivF+a?= =?us-ascii?Q?iGIkTsN/e78kL4bQRqzo5BZjvwjHQPo/rYXSfUHjj9TXrK+Z6G7AMN4/YgAv?= =?us-ascii?Q?gTHKQkF/0GVyIhVUGZYBK3lcgpvYxuFeexpvQ/A+oxUiyaoL++5UWxvlI3nH?= =?us-ascii?Q?wdcCQUX3Ff5Qs3IOjsz4Agefh3+1TYH+7mytPHZHpSxlNl15GqAz+SO+PJnF?= =?us-ascii?Q?gacaRVyK0QR6QujebqCQRlPEymZvN3qMWR4cm83lkBrx3OXz4vJjKPLGIZ+A?= =?us-ascii?Q?roU6Ks2usZWziqyuC93dZkakvM+HJDM4VgFrdeY+aQhWOCSjKUMaBSGJQ9Cf?= =?us-ascii?Q?iYhZdckmb7jSH56Z2O3RPGYWOrnLEiINKa/pep8F?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a172f614-a631-4484-7d89-08dd3ac3eb72 X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2025 09:05:30.1991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6+1CBN+ZFSStPnrllyIXqtHPfubCAca4EwuIGREI0Wr1s6g3oc4wVaPtwT7GfK2GYe5kGsnHEes0PjyGBAGxWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6545 Content-Type: text/plain; charset="utf-8" Report the task weight when dumping the task state during an error exit. Moreover, adjust the output format to display dsq_vtime, slice, and weight on the same line. This can help identify whether certain tasks were excessively prioritized or de-prioritized due to large niceness gaps. Signed-off-by: Andrea Righi --- kernel/sched/ext.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 64967d28da7f..99179aa6f7dd 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -5230,9 +5230,10 @@ static void scx_dump_task(struct seq_buf *s, struct = scx_dump_ctx *dctx, scx_get_task_state(p), p->scx.flags & ~SCX_TASK_STATE_MASK, p->scx.dsq_flags, ops_state & SCX_OPSS_STATE_MASK, ops_state >> SCX_OPSS_QSEQ_SHIFT); - dump_line(s, " sticky/holding_cpu=3D%d/%d dsq_id=3D%s dsq_vtime=3D%l= lu slice=3D%llu", - p->scx.sticky_cpu, p->scx.holding_cpu, dsq_id_buf, - p->scx.dsq_vtime, p->scx.slice); + dump_line(s, " sticky/holding_cpu=3D%d/%d dsq_id=3D%s", + p->scx.sticky_cpu, p->scx.holding_cpu, dsq_id_buf); + dump_line(s, " dsq_vtime=3D%llu slice=3D%llu weight=3D%u", + p->scx.dsq_vtime, p->scx.slice, p->scx.weight); dump_line(s, " cpus=3D%*pb", cpumask_pr_args(p->cpus_ptr)); =20 if (SCX_HAS_OP(dump_task)) { --=20 2.48.1