From nobody Fri Dec 19 20:14:14 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782EC18C936 for ; Wed, 22 Jan 2025 06:52:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737528774; cv=none; b=h/IsOhzScIomYARLwHZQ6w4qTSNpMiggrofDjmCbHby4vpNKRWJCx3PpzhvSZhpEBdnylQ+KMMXYs2GlewJMJmY2BJktesNxuceDnfkXfc3LVt7SIpe5NObmIwUlm5/1A7/xwWo1D5u7Opb41pP66XSHQArtHTE+tHDA798Lwi0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737528774; c=relaxed/simple; bh=I763Oa/eMnsSlbkfcMXLpMoWKkAVbmdkHlpluk14S2U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=d7pJ11LhwWXwpyRjk3PKtGjX2GtItHXGGMXN8/co8N8qmh0Cw8uyfyYB5lJffPqINDf2jAvcbzaIIGwHWtQ2igYztG5PK9x4xm2mketj31DGE7nbvQwc1N70t5Mx2E1GliVv+2mhCkO5OB04Jih3bj/SBmnErR9n2OGxDEeMb5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sd47wlCr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sd47wlCr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA25EC4CED6; Wed, 22 Jan 2025 06:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737528773; bh=I763Oa/eMnsSlbkfcMXLpMoWKkAVbmdkHlpluk14S2U=; h=From:To:Cc:Subject:Date:From; b=sd47wlCr0vdUjmjxCSegDkO6VOc07MkgL79bE+w0NKECtY4aPCZU1g6CFGTqdfuAe SZvfwqXvGbdY7cIUSA9/Zo0ckUg+QJb0kxFnh2dCqPfejKLCvCn5HeHbXqdhZDMq87 hD/fdQEGdoy1R5SadPhaNhHtTdTpvj162AaYvXh0uxRnKYUWldWKfRx8sysLUF60Fh PQNPV0F334lhpPeC041/0hnii0Y4G2AkwdwOFjsQuSYYBdbyx3ZNdvHeW9W9eF2D0M P7Z5EBHKMyq5jqZpZQofY8ELXCc4tdPCGw6SibbxjD41Tovte4uJhocGIhYFjDuurH empItcXx2e4gA== From: Arnd Bergmann To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Arnd Bergmann Cc: Cristian Ciocaltea , Zhang Yubing , Sebastian Reichel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] phy: rockchip: fix Kconfig dependency more Date: Wed, 22 Jan 2025 07:52:44 +0100 Message-Id: <20250122065249.1390081-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann A previous patch ensured that USB Type C connector support is enabled, but it is still possible to build the phy driver without enabling CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and in that case the common helper functions are unavailable: aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `r= k_udphy_probe': phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum= _speed' Select CONFIG_USB_COMMON directly here, like we do in some other phy drivers, to make sure this is available even when actual USB support is disabled or in a loadable module that cannot be reached from a built-in phy driver. Fixes: 9c79b779643e ("phy: rockchip: fix CONFIG_TYPEC dependency") Signed-off-by: Arnd Bergmann Reviewed-by: Heiko Stuebner Reviewed-by: Sebastian Reichel --- drivers/phy/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index 2f7a05f21dc5..dcb8e1628632 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP depends on ARCH_ROCKCHIP && OF depends on TYPEC select GENERIC_PHY + select USB_COMMON help Enable this to support the Rockchip USB3.0/DP combo PHY with Samsung IP block. This is required for USB3 support on RK3588. --=20 2.39.5