From nobody Fri Dec 19 21:54:39 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE7141C245C for ; Wed, 22 Jan 2025 05:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737525576; cv=none; b=ALwmcjIwwnNLd14mf+eOdqaj/uYWLV9gVVSqirAhLZ7N3Jdo5v7S56pgmfTlZ3jyax0oR7LLIu6i3NoQrjHu/EiPqhS9EwRJCCsq8iQ2+ozPV3C2OfXVVnPrDoND2DGCnkUr2GqMx5+AxpDgKMQtjcizz9mEzUE4yT1nnbDQs3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737525576; c=relaxed/simple; bh=tok1d+KJY2StErY9HkGjxI08FBgkFYfzv69eQcR1YNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V0uLdt0XfgImZ3fOrFU9hVN9KdgqSBHfmJvTOgsPbGTzUbVzMH41Jh3f/+6mfD2aKi+aIxVDA81RAW34c5K38tVrSatbnKSTH5OeWGl+eMMGGBkWFXifvHnSAqYA8DOIHr6gT/Bsz4WlYQrmWJJX624s3l415IfZfJjom5nZsYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=gljiHlU2; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gljiHlU2" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-216281bc30fso148861705ad.0 for ; Tue, 21 Jan 2025 21:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737525574; x=1738130374; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BvDi8LZx+/IWsVw6XTpR4rzD/goHjjTNwP1dgLi65OA=; b=gljiHlU2W8aGL3x/jhvmIAqCJJiLBVU3NCmRxL3ctENtvjwIlGUnTEVDzZroTDmfbX 36vTPCKxH7hg0v6sjLGwSl2bhG3xpJ6Xj8gkN4RkKsNnmItjbrT0fX4mIKzRrB6wAgMn PTbJ6m0dZ65KMkY2M23bO1m78ac6sNMYqoPiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737525574; x=1738130374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BvDi8LZx+/IWsVw6XTpR4rzD/goHjjTNwP1dgLi65OA=; b=n4FqM4ELjdOPXtXoWuAA7TDrTwrm+GBOOcgdMiQIJnkjqeCSHKn8K1pl9fspQKJ5s0 BYfacrdMVVRPS94uPcGUA8bMmSg1FPEYqsqEzuT79kSZXLf2ul5RYbj8FqcG12gNDuZM FItLTNa9doPopWPZJjogdiVCFOx1yzCg5h6lGVPa3QOcvQVRoWuNr5t3Q2zQJhwj787t 7rO+olsnpDGRIRk1jYWLIf9+WoJOe3weBt4GnLKShEHpK9qoKRGTEZSVpOroa4xbQHYR hCLbv7b6PKaBV/3gNYoLNP9aVQHKLvfWeHp7s8IvgNKoI4DMqsGEbTnEeU4kWg5IPUE6 oZZg== X-Forwarded-Encrypted: i=1; AJvYcCVDuFZrxZ7HHmx0cvDmUqCRAQXj16WX+ZuefjIx6VgsyYl3UsXxYBck+i4rTG3gYy6zrudufYRfzs3bLW4=@vger.kernel.org X-Gm-Message-State: AOJu0YxS/dHBhImmaMeWTckEdNcDOdZiqH8ghmRUhD4eX5A8ogO6Z0co uhxDEUA6WHVst7W064XcnSNLddW72/bMxAKXVTCTKHhSKGTpVxccOC+cxs6t8A== X-Gm-Gg: ASbGncskC8IBjflue2jK/GAJZnItvEXa3kmiKX2xPue7nRtej5y2dp4ygmk9UxfDb3G jAuUaW8Hvvq+68k+K5FD3V0qj9k3/xyJnUOkryOlrNlnItTdtpwlLudAoOWnL+TPqCAATK3ca2x w8EUpx1FEOlpJ0nqle2Mf3DsQoX7v0ISLPAiuL2hJeAKingvst0d05dvN2a2TqQqQVcB7CasL24 amAUHX/AnfgBu+ZEasvXekJBVwMFWIzu2ECrA48UAS713zQQXz3IoTtpZcBsbbEHs3jAoSK X-Google-Smtp-Source: AGHT+IF5DI4LMRdnglCGj0EuJR+qLfX7sRa9uFUVFiVN11N888cUyl0GHxvq1Dybvd7Sp+FVeBy9+g== X-Received: by 2002:a17:902:ea05:b0:216:3d72:1712 with SMTP id d9443c01a7336-21c3579359cmr340704225ad.48.1737525574148; Tue, 21 Jan 2025 21:59:34 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:2902:8f0f:12b3:c251]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21c2d4027fcsm87386355ad.214.2025.01.21.21.59.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 21:59:33 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCH 6/7] zram: remove writestall zram_stats member Date: Wed, 22 Jan 2025 14:57:44 +0900 Message-ID: <20250122055831.3341175-7-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.0.rc2.279.g1de40edade-goog In-Reply-To: <20250122055831.3341175-1-senozhatsky@chromium.org> References: <20250122055831.3341175-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is no zsmalloc handle allocation slow path now and writestall is not possible any longer. Remove it from zram_stats. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +-- drivers/block/zram/zram_drv.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index faccf9923391..d516f968321e 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1443,9 +1443,8 @@ static ssize_t debug_stat_show(struct device *dev, =20 down_read(&zram->init_lock); ret =3D scnprintf(buf, PAGE_SIZE, - "version: %d\n%8llu %8llu\n", + "version: %d\n0 %8llu\n", version, - (u64)atomic64_read(&zram->stats.writestall), (u64)atomic64_read(&zram->stats.miss_free)); up_read(&zram->init_lock); =20 diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index b272ede404b0..4f707dabed12 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -85,7 +85,6 @@ struct zram_stats { atomic64_t huge_pages_since; /* no. of huge pages since zram set up */ atomic64_t pages_stored; /* no. of pages currently stored */ atomic_long_t max_used_pages; /* no. of maximum pages stored */ - atomic64_t writestall; /* no. of write slow paths */ atomic64_t miss_free; /* no. of missed free */ #ifdef CONFIG_ZRAM_WRITEBACK atomic64_t bd_count; /* no. of pages in backing device */ --=20 2.48.0.rc2.279.g1de40edade-goog