From nobody Fri Dec 19 21:54:31 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89BF71C1F34 for ; Wed, 22 Jan 2025 05:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737525572; cv=none; b=QtLcWIkldj6saV+VGyqyeMnylI/FfYup5KRM9v7UHlrW6m4mi3vFWyIxd9LVw8+0P44I8rtNd7owv4KSAxnSDuS6cyZG3njv2ISGKi0a/dLHFegv7Xf65qw+aUr4KNK+ySDhZNsrc8xEeUntkhXDIjJmR8Sw/6a7Y8fPp6myETc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737525572; c=relaxed/simple; bh=ceWVhzDBOJXXfnRl/1ShOrscDweY68PDMYI5sXiAuUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AAWUgyFu52mwZXnPHuDCiKydWYC3wo74vjlTMt/kxMFeJSwWFkuluXfoR6aGckL1ejF4Bd4aV3oj3xghSxTMX+BuOjX6kUOGCsbdWz79rjx5EmZsxlCpA30wSdyoLrsr1Pk228X7P2X/UeVtQoxw06D9i/keRmrB96lD7v55qz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ICtAsZoR; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ICtAsZoR" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21a7ed0155cso104689015ad.3 for ; Tue, 21 Jan 2025 21:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737525570; x=1738130370; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RlO1kRVQLX8+VpLXbuNkwAyTGyYAX3nxybEwBuf8gq8=; b=ICtAsZoRSMI4ZNNIgX9HAfQjwjviqsL0+p60kev8dqwOIHkWYTVTyei2NIz/SVImMS vpkV7+ZY2oCSGTxeTyhxdDZkJ/QBrnmSlXFclaEu19YmiW+0gYm76/MvBK2deaHhMAMM NUZs2eFGf5D3+wBXUlwgd7meNvg3A36Kl6c3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737525570; x=1738130370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RlO1kRVQLX8+VpLXbuNkwAyTGyYAX3nxybEwBuf8gq8=; b=Gv4kQzbF+dQvDCoitdgYwJr4ON60dwnhvm3i0CNqw18wqVsczEiNel8tfMXEBY2aUD JRAL8/GCMAP8COqCjVX68UdpV9exbkV8EpcLXuc3etLM8XhehzqUwEh7MJDmpIFIusa1 aSsDeQhFvhvLck8/blhuhQpKqdZj91XsHhNdLreGglTLL5+5uIkzPrVVGr7P+IaeDlEd ikHb9MaYNitGxEBGmEEi4pN/ThbRwLMIt3ibJtArp+UJWkpNQL1K9eQsIpZCcQIU0nll VQfuk8wY/IJY44PwTgsrMZYhtZcqwQkI22sOcQXwKDuUNMETR9d34IryddR61IlaWCmr xS9w== X-Forwarded-Encrypted: i=1; AJvYcCXyA0Mfrv/xa/FwKbUJHfyJ37b/B7isgxtG1B+Ojl63OslR9D5MOoxOA6TE/COFWqxtSs6qszAQG8U2ZLU=@vger.kernel.org X-Gm-Message-State: AOJu0YyCmaTn1zee/6vKQxFnjo0f/ASKv+AV7JGmWd1aGfVP03YH7D+H XeXMuJbszUaOkUI1YGr6d5b6r2nZRhHKAFFDFBaJDWSpU9NV9nLbxnveX2fcZA== X-Gm-Gg: ASbGnctRq3B5UqeC4+k4F9rlvOkinHEV/zbBW5rEO+z6azmvwqLO1ZjCcLV9yYbdSXc oayb03b4JGCfxxb3Z0JQGys/oW33mKgNeq5fyLLyC0MLTPzgIvA2WPph5J31lXn6BnWMJBCyjMJ s8nJPDBYiypifksKaTcE093qaWgUMfJcNUflpEVr5aZvcOro5GgqXhbVtmvJolJmJA7KIvk4NRf PrrHG1ZGjlw+kX7hBmXRfSeidGODw36wVJmWapIWnNnZxu9l+Bf2swWoZ7dcZl4EmozcQwH X-Google-Smtp-Source: AGHT+IFDdKEw/ZLrD/5ATxrQr6EltWEOuPwzfWGcOrPfuy+nWB9ln8JMINNEvYbVGHeZ24N0e5vrbA== X-Received: by 2002:a17:902:f644:b0:211:8404:a957 with SMTP id d9443c01a7336-21c355f6aa9mr356031145ad.41.1737525569847; Tue, 21 Jan 2025 21:59:29 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:2902:8f0f:12b3:c251]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21d6217cd6fsm20187155ad.189.2025.01.21.21.59.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 21:59:29 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCH 5/7] zram: permit reclaim in recompression handle allocation Date: Wed, 22 Jan 2025 14:57:43 +0900 Message-ID: <20250122055831.3341175-6-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.0.rc2.279.g1de40edade-goog In-Reply-To: <20250122055831.3341175-1-senozhatsky@chromium.org> References: <20250122055831.3341175-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Recompression path can now permit direct reclaim during new zs_handle allocation, because it's not atomic anymore. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 8029e0fe864a..faccf9923391 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -2005,17 +2005,11 @@ static int recompress_slot(struct zram *zram, u32 i= ndex, struct page *page, return 0; =20 /* - * No direct reclaim (slow path) for handle allocation and no - * re-compression attempt (unlike in zram_write_bvec()) since - * we already have stored that object in zsmalloc. If we cannot - * alloc memory for recompressed object then we bail out and - * simply keep the old (existing) object in zsmalloc. + * If we cannot alloc memory for recompressed object then we bail out + * and simply keep the old (existing) object in zsmalloc. */ handle_new =3D zs_malloc(zram->mem_pool, comp_len_new, - __GFP_KSWAPD_RECLAIM | - __GFP_NOWARN | - __GFP_HIGHMEM | - __GFP_MOVABLE); + GFP_NOIO | __GFP_HIGHMEM | __GFP_MOVABLE); if (IS_ERR_VALUE(handle_new)) { zcomp_stream_put(zram->comps[prio], zstrm); return PTR_ERR((void *)handle_new); --=20 2.48.0.rc2.279.g1de40edade-goog