From nobody Sat Feb 7 04:02:10 2026 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BD591C3C1A for ; Wed, 22 Jan 2025 23:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737587825; cv=none; b=fRJ4WGTAQgqPYknjLVGBW4np44VVw1Ud9a0/NWv/Kkfh6XBMWt9lAv7jg8lKav5SEMoqyVky62XHOc1cqzK4tzUUx2CqptsesiftJRlmvHN+Qx2CouoapOiyOSUnYVaY0ib3rwB8Zq8nPxWRGxW0kIOKKDxwjWLTNfWW16HFn2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737587825; c=relaxed/simple; bh=TtjQPNl6OTM2K4k/jF1u5iijij0z3buUzutigKl/igQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=r2FtPrhvp6ndFSuM2VpWrEfQjZKakruf+ioagPrkvSHcP4VhrfoWNsLANyD4bXj94p7OVZ+9Z/QB07S6yECTcAkdB18fWg76oXhSXwy9b6a6XJ4KExJ5J+J+TyR3rlM7qQWuK6m2ssxpamuN0ZcC8lvX3486QP8nBk6c1zi4LnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=keWhp8L5; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="keWhp8L5" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-71e157a79c8so85760a34.2 for ; Wed, 22 Jan 2025 15:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1737587822; x=1738192622; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=2OOlg6tjFXngIhlnbIWgClW+e5dHMMirNsQSGx5x/aw=; b=keWhp8L5NPj5NqeCWcIIqlvT/xsv1253t+pgVnuxPA1GXjcPufzTp91dzp2R9eXLEc HTlq2pxmzGMSXiBAfuQlwD9uRIrnqTm+SvJ4yIGqvfWWEt3412h8Ru0BrjPRZE8Matv+ e5GFW2oHPusqGlhEu3tt9kfXF38wxd/I0pJbmQIeNhqOBMV4rPs37Ll1WjfrRp4IhLF0 +7fXTSS/+gqYnohAD8kOvuRD8TsXRtBE/+HdvKOum55xpgyV4Vo6tfNml7A9sbp+eMgS WusGlAYgjLXGHhEBcUGheElwXaSFdzcuxD5eWIGaTNYdDMdxZ7YXo6RePqtkYZMO8nvR DwZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737587822; x=1738192622; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2OOlg6tjFXngIhlnbIWgClW+e5dHMMirNsQSGx5x/aw=; b=w1HrTrHRiaf85hsJy25XRQj0ZThc++G3XRW0EaQ9O0Ecj/eYigHTcoZZaK7FIt076g oWKD9555JTz5GQS3Vse2PTq3nuEBI/jOvLh9Ms37XVNRA4bCm5/AyuJRfVXc4naNb33j k7VD8pP79xezRog7zDIN+z30rOZ3q5jsda2zYQ/QpJQ8Dekr0nydY2AAsC+yb+cgrRRO 7UY2eMlXtSQsSlj4OR3dtO+UDLgf5NQbkH8NfIbQayUgG6Kl3/ExBnO1W2dTYdom21xR /bQohT4TEw5wyPVyUeGo6+IOIaiQ7VTi7EXn48+tffCm4MdGZs+olP357+M8oG6i/n2C sgow== X-Forwarded-Encrypted: i=1; AJvYcCXFy599PZRzoz3MIa2iAHg8MBOHwCJcx1WqFyyaYK6zCE57o3V+CFe5TdV/KBI1CX0u/QKeAevb8KWxeoM=@vger.kernel.org X-Gm-Message-State: AOJu0YzX1gNi5U+H+MwloSSzB4IMuEvjz7SZQ3ZIBzg8DwaVr2sv/FuW +UUxiI8kLC1tB1VxKxGdnLyS8cZX2iD9ZR9Op0hyI0BEekicHoqfHLRuPrJdHq4= X-Gm-Gg: ASbGncuVhf26718uOTKIeztrctLMPW/C8IR3XcB27pflh5KT5VwaWcMvh2stEl8P2WO I4rOrVDKDxeCifjPCRQBdbZ7MMSNe+alr79HDlKGrAdDd0Q2/IaDKNZwEM2C2JDWUGTOSBXCXnh DjKVnXLiOimwOJeOJTUkKMdzaLYtA+gy/pIWlljIp8dT7RDCmm0rtebTrt2YLYKhZL/u4J6jKzi r63oNzdqIf84pP3/lWK46D9ZnY3JhLhdH/JFcYH02b0Y2TOykB/O/C+3sYdeU7IglY2A1txm4hi iWS4rIwR6XaNA1EJ6et8CNGPkQ== X-Google-Smtp-Source: AGHT+IH1ycSRvH/KUUZxKDaSg/P17Bp455wQqA6ceWssIHmrDmYc01otoqmk94pQfARNXb9Y0kev4w== X-Received: by 2002:a05:6830:6087:b0:723:28c2:aa84 with SMTP id 46e09a7af769-7249da89f3bmr15927621a34.13.1737587822582; Wed, 22 Jan 2025 15:17:02 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5fa35fe0819sm3731819eaf.27.2025.01.22.15.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2025 15:17:01 -0800 (PST) From: David Lechner Date: Wed, 22 Jan 2025 17:16:59 -0600 Subject: [PATCH] iio: dac: ad5791: fix storage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250122-iio-dac-ad5791-fix-storagebits-v1-1-53746e0f25cd@baylibre.com> X-B4-Tracking: v=1; b=H4sIAGp8kWcC/x2NSQqAMAwAvyI5G2gLrl8RD6lNNRcrjYgg/t3ic WCYeUA5CyuM1QOZL1FJewFbV7BstK+MEgqDM64x1jkUSRhoQQpNN1iMcqOeKdPKXk7FIfYtRzI deQ8lcmQuyj+Y5vf9AESkOcVwAAAA X-Change-ID: 20250122-iio-dac-ad5791-fix-storagebits-9f86efa07abb To: Michael Hennerich , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 IIO uses "natural" alignment so storagebits should always be a power of 2. Change storagebits to 32 since that is the natural size to store 24 bits of data. The ad5791 driver currently doesn't use this field anywhere and doesn't support buffered writes, so this does not change anything. We just don't want anyone to think that it is OK to have storagebits =3D 24 in other drivers. Signed-off-by: David Lechner Reviewed-by: Nuno S=C3=A1 --- Since this is purely cosmetic, I didn't bother with a fixes flag. --- drivers/iio/dac/ad5791.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c index 57374f78f6b885e1d4f2fb452ac0563b85fc222e..034228a7c059f136cdecfb46832= 28d0be4c37477 100644 --- a/drivers/iio/dac/ad5791.c +++ b/drivers/iio/dac/ad5791.c @@ -294,7 +294,7 @@ static const struct ad5791_chip_info _name##_chip_info = =3D { \ .scan_type =3D { \ .sign =3D 'u', \ .realbits =3D (bits), \ - .storagebits =3D 24, \ + .storagebits =3D 32, \ .shift =3D (_shift), \ }, \ .ext_info =3D ad5791_ext_info, \ --- base-commit: 012b8276f08a67b9f2e2fd0f35363ae4a75e5267 change-id: 20250122-iio-dac-ad5791-fix-storagebits-9f86efa07abb Best regards, --=20 David Lechner