From nobody Sat Feb 7 08:16:08 2026 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAAB41F12EF for ; Tue, 21 Jan 2025 11:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737458535; cv=none; b=Q/RpvtHZKt6ijTvqBTNqw8CI9seVetDf9LQ7ua14QpMUgNJGLJZoWfwLReGguAMQb68HR058n4I4ZOexibGTOBwJT9SYM1O0BOvPAs3mNQJ6VblOcrXCAMhOwj5c/cF6n889DkYOo9Gl2AnhhtiZbCI8pdU5SByucKo+gw1/gWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737458535; c=relaxed/simple; bh=9DbZbqnyxkcJKuwsY5jXw5wmG03s0ufb3catY8T+SO4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fsg62yCAEMXNxpjQzSOz9tpweCZw2MVCw4mOZgnyXGDXZltRn6EKAVE+SX/rESvdsEyngrml0uWCepmbthSYH7pt3khyalNj4PPKnQnsNwHR15sBB5Rc07G7G2OLB41LcSN5bowYqGndfqst6o6pvECjdqpQa8DjBurPAHFPFq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=RHao/XzJ; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="RHao/XzJ" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ab30614c1d6so107227066b.1 for ; Tue, 21 Jan 2025 03:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737458532; x=1738063332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cBGCejyyGRZofPEXo0GzRmqQZ9v4Xi5rLOBAzs3B77k=; b=RHao/XzJoWBXkea7IN3RjiSAjBdH60eBQMl4z372k275WxS0k+qbixkA5LJAYnFIi+ W1Ms+o0ajpo1OgzS+bn8x8b/701ikYOt3BTdMRbrb3sSjuOb3rQZr86u5NZbL2QLxJKF F2tqf3hbbMnuHZlAehKBxXo+Ja33AANhUVllrhbU8FPrUR2HDzhgLLOhytSRDVAzF0Po YNSSJtdkFGmrTdCq7V7EqaHlFSFvw/Wt6no89FDDQ0sbXDsYTaz38J/MkxdrXvBtbGR3 TXTgc0ZISbZdHDclKUOKLdCdZuj4xtAErfEamxcbkRLvkrxcVLN2EeI7wzUiAH3BH3jO ELqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737458532; x=1738063332; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cBGCejyyGRZofPEXo0GzRmqQZ9v4Xi5rLOBAzs3B77k=; b=psljMi+WVyebpbTgW3OuMQlgfAwi4Uq9wz+PhSXPxcJMTqpJ6Dt0cmfkBsNPMb0bue gYt/TUZhiVT/sW0YzEFKuuKzTIVfkOa3yLpTn9/1MmEntwHS6VJxhL5X8tL4UysxpO7H LbcP6IQdpMWyJnqPS2SblWNW3mxIkka1nzw1ZHVi3SIXLboCv2dbnDQogz5d/Yhtu2yn lZ9nsW0KLDj9v16UIKwd05P8aLMsMMzkYgHPBspeg9zo/kzrkbnPISEoSYqR7G1sIWbT rj4VdHJaeUCaRG/AmjfTqkIayySGLa022iyB3HIEZvLBjpyMbq6cWSd6qyCpGjfMT/WI Pu8w== X-Forwarded-Encrypted: i=1; AJvYcCV4pk4G1Apr7tI9SoeifsKKGpGqcQXQMR9Wvxs6EuXIOSrUvHFs4lTRqzRbM/zBR8cWrnpwSBswOLNDUn0=@vger.kernel.org X-Gm-Message-State: AOJu0YwwTyS7KrqYr6d26+5P0BcBNHhnQzgCLfQh3buQU2PedPmmOewK JYZMe6OiYuCnIYHYf+6sU6fKDdG4qhwo7esimRGjIXeqKHP60JlWvmRUoSxqHSo= X-Gm-Gg: ASbGnctn3MEaduc36d3Ofsz6pba8+Sq49eDb7mTHTci9GKCpvlLACJczOtYcIKBGUnI Xg+HCRrRwkFztGiPK3kqZOJVtmGKHQu6yCOAmJXUAKGD+edLIxIESc6t66uMCXr83GTtkzEkDhO VXEXYve7jlleVex3oRPHUipfe7lNW1hqGml0HY4ATzloJovQ4BfrQ9vuNiZGBsJQBfJM5b0IR37 34y8eHRmH1lp0rDLtguXQRfbI5PlUpRh5oD7ixjlZEx1lXs+nJslUbOmVE0a1eC5lTOragNE7zm tQAl5fw+ X-Google-Smtp-Source: AGHT+IGLwTAv5U1MMduS4C/su64NdVIk3C/9u5AE7dcHcadMDWlbORhBGQtX1XfJMUxiDD6/JZitDg== X-Received: by 2002:a17:907:86a3:b0:aac:619:6411 with SMTP id a640c23a62f3a-ab38b4e1a7amr657600666b.11.1737458530466; Tue, 21 Jan 2025 03:22:10 -0800 (PST) Received: from localhost.localdomain ([202.127.77.110]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f72c15bf82sm12701665a91.7.2025.01.21.03.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 03:22:09 -0800 (PST) From: Heming Zhao To: joseph.qi@linux.alibaba.com Cc: Heming Zhao , ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] ocfs2: Fix incorrect CPU endianness conversion causing mount failure Date: Tue, 21 Jan 2025 19:22:03 +0800 Message-ID: <20250121112204.12834-1-heming.zhao@suse.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 23aab037106d ("ocfs2: fix UBSAN warning in ocfs2_verify_volume()") introduced a regression bug. The blksz_bits value is already converted to CPU endian in the previous code; therefore, the code shouldn't use le32_to_cpu() anymore. Fixes: 23aab037106d ("ocfs2: fix UBSAN warning in ocfs2_verify_volume()") Signed-off-by: Heming Zhao Reviewed-by: Joseph Qi --- fs/ocfs2/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index c79b4291777f..1e87554f6f41 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -2340,7 +2340,7 @@ static int ocfs2_verify_volume(struct ocfs2_dinode *d= i, mlog(ML_ERROR, "found superblock with incorrect block " "size bits: found %u, should be 9, 10, 11, or 12\n", blksz_bits); - } else if ((1 << le32_to_cpu(blksz_bits)) !=3D blksz) { + } else if ((1 << blksz_bits) !=3D blksz) { mlog(ML_ERROR, "found superblock with incorrect block " "size: found %u, should be %u\n", 1 << blksz_bits, blksz); } else if (le16_to_cpu(di->id2.i_super.s_major_rev_level) !=3D --=20 2.43.0