From nobody Sun Feb 8 10:58:54 2026 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9E28479 for ; Mon, 20 Jan 2025 19:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737400047; cv=none; b=poVdl+MeZzhrI7P8IsHe5MBqIEj8JVoInXQZu8Z8hfGdobUvGmxgU2u7PMoiDNYkhROMgfW/l6NGV61nh1Ov5yZofUxe55m9BC6EnmA6QvaM+HmS6RNO34reQgPiMv4tMvQ2YAXSvqQ911MmcxbxJapO+vuJGqedhC6BMZM1DO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737400047; c=relaxed/simple; bh=Hbp4GEgjQIxFuApGvP9sRi/wgozlpX3lNWtkmwrDRcY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=SEMrKHUjjo7IvTvR1IWBRWVQ4Ey3F/OiZL1aZlB8yRUejR3PNNboW5gyaQRt0TUjW6j+Un8bROULz8MNhHhyP2D31x4JN+9gFwaYynNZ+yGdIBgsv376dzrUd4LSWT+Q8twaPXZFXdztFiNWPfumB3qRKoX83wbPbZwC9ez/QD4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N7yf6zxI; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N7yf6zxI" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-467ab37b46dso3575421cf.3 for ; Mon, 20 Jan 2025 11:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737400044; x=1738004844; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9/QL/bMO79U8hdMRcJV69+inffs6/MVIFrMRRCI0iJM=; b=N7yf6zxIvQXJ7kBiwHz6oE85xFh3VpHsP7SGF/FAff15f1sTBpgZTwrvRmAdpRuVNu yh6/99QY0NVl18m9i8F2PuyuEAZMly4hrmz/RISweMm+rBAC21N2PZLVCP6k2x9mlL4L PafviJ5Lplc+afrvd4VRLVj7kSzrrzkNvM8J92X4EcnERwQBDup3o1Mibfqj6RHC7eSq LKPRmJO4+nrlzrgx4WROBLY0FfwSLaicQUiTfewjCRLLLOc7DN24f0BLyMVbi3SfTg8F Hite2wyma3YzKpH/4Rxzt20jyKfMJt0RIJXUOoqoli7WLg1ceq1LweuxIaQq9gRBSypp /vZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737400044; x=1738004844; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9/QL/bMO79U8hdMRcJV69+inffs6/MVIFrMRRCI0iJM=; b=BBNl1YG8PLsI6YyvCgrqUkdFIWJha4oUeWaJpPgqVyPS7Z420q99oAKk+Y0NNxGD87 PmP43XVfY41mCgmCFPMTLe9sg/ilvdc/Ujm/FelUVfosy9oxfJFpebmDjEfZ7OSr2DhT Ru01vgZAkQES/Rh070tn94zJVfeZ8/NYtpK7ZkGkyt+6znmny6OmtY+03fcs9EIEr7wp Tu2AsSle7fE3iBSSpLuFvn6QG1lGUYEGgIV6Cm4sFX0JfspeObUTvteZYpjVy7yi7Mzc jBBXeoznWun5inJ44WLCnf8YO4X4QN8GBO9pPlXA9ET7+7Is9VLg7Z6hsIvOngOMZctF PweA== X-Gm-Message-State: AOJu0YxG9KIJnZjUf9FhlJ8DwRcg4DfRLJthCDVUk5hHBobO8pZcCrSc V9ezfveHpWFlAMc4f3nqfYEP3tJQMRhNU60v5BARvbzL2gGguY8= X-Gm-Gg: ASbGncvNs8BdiDhOj4lU6UMAwBC+s+syf9XrJE2N3L8O8c3TCRQ1rUe8mjn+IfP7GwI KHDLopVkIBHwJoxQqsN3sHCpND/aZTW8EMnvb2YuxZIqOtTUfc2nqJW5nDrxLGhbwCMQW37zduo 4PrpxWvyhPRsphrOwjYmd3ciiojoTLOCN30+VYTY3tMD1XmVOrnSREWStKE/eV9i79lCeQDz6FF oFfanE5jS9nHkk/rPQPAITaOrRaNcaHESoKynjQeUpedZvDqqlZZBruS5SgTkRszBA= X-Google-Smtp-Source: AGHT+IEsZDH0Nfbx8sdJ+4hpC+wlF2zy3ZPeoEMzVztxd5Lu6jxkB2eNvp0BN1YFn3FqJZv830uvZg== X-Received: by 2002:ac8:5d0e:0:b0:467:79fc:b009 with SMTP id d75a77b69052e-46e12b68106mr80672591cf.11.1737400044513; Mon, 20 Jan 2025 11:07:24 -0800 (PST) Received: from ise-alpha.. ([2620:0:e00:550a:642:1aff:fee8:511b]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46e102ec6cfsm45539921cf.3.2025.01.20.11.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 11:07:23 -0800 (PST) From: Chenyuan Yang To: lee@kernel.org, lkundrak@v3.sk Cc: linux-kernel@vger.kernel.org, zijie98@gmail.com, Chenyuan Yang Subject: [PATCH] mfd: ene-kb3930: Fix potential NULL pointer dereference Date: Mon, 20 Jan 2025 13:07:20 -0600 Message-Id: <20250120190720.322926-1-chenyuan0y@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The off_gpios could be NULL. Add missing check in the kb3930_probe(). This is similar to the issue fixed in commit b1ba8bcb2d1ffce11b308ce166c9cc28d989e3b9 ("backlight: hx8357:Fix potential = NULL pointer dereference"). Fixes: ede6b2d1dfc0 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded C= ontroller") Signed-off-by: Chenyuan Yang --- drivers/mfd/ene-kb3930.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c index fa0ad2f14a39..60824d847bf0 100644 --- a/drivers/mfd/ene-kb3930.c +++ b/drivers/mfd/ene-kb3930.c @@ -162,6 +162,8 @@ static int kb3930_probe(struct i2c_client *client) devm_gpiod_get_array_optional(dev, "off", GPIOD_IN); if (IS_ERR(ddata->off_gpios)) return PTR_ERR(ddata->off_gpios); + if (!ddata->off_gpios) + return -ENOMEM; if (ddata->off_gpios->ndescs < 2) { dev_err(dev, "invalid off-gpios property\n"); return -EINVAL; --=20 2.34.1