From nobody Sat Feb 7 18:24:54 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAC281E3DE3 for ; Mon, 20 Jan 2025 14:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737384778; cv=none; b=VkcqubxrDMlFwGBaDlbV52R3Re2EaJgtMr/z5AaHfEmVHrRsowoAzkmfsKBdRlRRprWwYyJCkg99wgoGzg3K/ZAJoKHuvGZbggcYpn4Bf4sSFe5fMA0P1Ssh+AtzMfW9Fd7JBn8IIpzjeGqfjVrqHmLMXPL9sC3c5PTieIHy8gw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737384778; c=relaxed/simple; bh=QDc8x9r37GU/iPsqZdSzA4IMotb1DbSARr1kdyfx6wc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WoYHRnijen9OSBvntyvoAKLBCd5/ZIt4astQcuqv9AU09IoBUFzOc3tOYha2EEtq7bYrWIQtRVlexlPV9anSzK3gufgPLfky4fUQrN9tNt1MSuZcgqeO5XIuOeSbHPTCAT6DsBPUhMnHv9TXKyzJdjibnQk+LyE4xPjPHXZxUCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gYVaKmrQ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gYVaKmrQ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43634b570c1so32752705e9.0 for ; Mon, 20 Jan 2025 06:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737384775; x=1737989575; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=luZW0ROky4WuRwlQ5C5hlO70LT6nQT/pOM86+71SSCc=; b=gYVaKmrQeRypGxQed/LhH1/quucBMASzQCLXy8B8cMxBaHDsmvGEm5Klo1/NtkqZSp GsCqLeLLaXl2apgzLSoNh/sQoUcLtWvBQp2b+psF5BOtOXKt391iIfmIwC1VPMuNC+IB fvp41a6PeQwELNFDiOrLlME/UdrgJg+6SWEDeDpq0mcQDDJr0TiZ1a3kqLehN0Ng9W+r CYl82zcN59j4Bk2q4RD735q9qEQIs5aUnIDbhcQNPZhNWY6jHUqftgz7Ec+EzDNC79le QX/tvZT1zsOhGdSTzAAQzd1vh0lkRyav4IwYAaH5MZBAgY+giatWLqjRnW7uJT4tiEk8 TTRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737384775; x=1737989575; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=luZW0ROky4WuRwlQ5C5hlO70LT6nQT/pOM86+71SSCc=; b=ChShkvJ2Vapk7bChLBw8aG8XeG0OE3JV3Cqx1dUKQ/u6Pp5EUik6EiHdMRRP6y4S4c /XhPzY/ip/Sy2FWCwPJMJPPl9V6QvAC8Cb7/+bdyzx1Nbz/TlnPgD/CYaZKLC9NJA+Ef yy3xh/hPyRxRfGGRkhwmi9fsbpt/g/BXJ7W+ToJnki+qF64jS1LGssJPpuVw5SHhnkVb LWsNve+yYR+RnpIxN11pbT4YhKCcDs/WXJK2xaEOBwpXvcps4XJqlbalIV+nL8ZvcYU9 StITr+xfyKvBjd6k1afT5EBq7YNJZE8qn+kyfliujli2H6jHkYLl2f0lNr95MTk/80Yx ezjw== X-Forwarded-Encrypted: i=1; AJvYcCXoO6ND2hIluyj9hkp1C7LUrOx2i7knDtFztmH4fI11hkrHzklUSpE7ivJ2im2kRlWGjtuuF+kuUKH0r40=@vger.kernel.org X-Gm-Message-State: AOJu0YzZGREAm9jeb0SVwcI4dqvBRB++6ccfdtWYexKSxXMhdubXDEHN FpbDoybExt4GzzcAHlFAooBa9qTdLnZGy0sXGyB2qJSYzNsiVv8P X-Gm-Gg: ASbGnctA/2avDqMRbzaK+gpTsmI8kP5KwtO26bi8/PA/YTcM8CXN8GjiDK5fnj2KJL9 AJ8x53BzRIi39IP4HIEGQ1xSNVjXHCidYeKMhJckKQnUyoi2XEvkL7Q0uMVdo+A1IVwqToamKUD gy9dIRbv3PZLRLIGDRuqKoNiTOvU9RNMMaHf+7AnREzJai5zqOF4mj3JoJ5xALhnhl2CNzzmQKW uiEthRz4Azy84HQtQPOYV7Cx/MQTpLyYOX7leLjwrf6zbLP56iHkLOVINKbrZg89Yb7JA2Nlvya I1AhPtAHNGuKtpj0RrWvdgPHcH3tgXb1RoHuO9Zu X-Google-Smtp-Source: AGHT+IFCNOU0S2uUlzM7p8bBbP2OVjzPxPn0kPkEMd4xPgltgn7EOZwMgGDQJm71NLT8Lg5hVF1fig== X-Received: by 2002:a05:600c:4ece:b0:434:f609:1afa with SMTP id 5b1f17b1804b1-438913c6787mr123435635e9.4.1737384773263; Mon, 20 Jan 2025 06:52:53 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3275562sm10925841f8f.66.2025.01.20.06.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 06:52:52 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler , kernel test robot , Julia Lawall Subject: [PATCH] staging: gpib: Use min for calculating transfer length Date: Mon, 20 Jan 2025 15:50:30 +0100 Message-ID: <20250120145030.29684-1-dpenkler@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the accel read and write functions the transfer length was being calculated by an if statement setting it to the lesser of the remaining bytes to read/write and the fifo size. Replace both instances with min() which is clearer and more compact. Reported-by: kernel test robot Reported-by: Julia Lawall Closes: https://lore.kernel.org/r/202501182153.qHfL4Fbc-lkp@intel.com/ Signed-off-by: Dave Penkler --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 3f4f95b7fe34..0ba592dc9849 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -66,10 +66,7 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8= _t *buffer, size_t lengt int j; int count; =20 - if (num_fifo_bytes - i < agilent_82350b_fifo_size) - block_size =3D num_fifo_bytes - i; - else - block_size =3D agilent_82350b_fifo_size; + block_size =3D min(num_fifo_bytes - i, agilent_82350b_fifo_size); set_transfer_counter(a_priv, block_size); writeb(ENABLE_TI_TO_SRAM | DIRECTION_GPIB_TO_HOST, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG); @@ -200,10 +197,7 @@ int agilent_82350b_accel_write(gpib_board_t *board, ui= nt8_t *buffer, size_t leng for (i =3D 1; i < fifotransferlength;) { clear_bit(WRITE_READY_BN, &tms_priv->state); =20 - if (fifotransferlength - i < agilent_82350b_fifo_size) - block_size =3D fifotransferlength - i; - else - block_size =3D agilent_82350b_fifo_size; + block_size =3D min(fifotransferlength - i, agilent_82350b_fifo_size); set_transfer_counter(a_priv, block_size); for (j =3D 0; j < block_size; ++j, ++i) { // load data into board's sram --=20 2.47.1