From nobody Sun Feb 8 14:40:33 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0397B18BBAE for ; Mon, 20 Jan 2025 14:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737382001; cv=none; b=pUIaNNVoyOuCmA0IRYVvLoRhksJXd9iXPgtz9xjxo8yGXxUwqrfWsCA8ytzrlZnFXYrHNKWAc2olIlvwAybBR+TXXSpxTClA4wYwMobR1uq1nSlu03FNATCZh+YQHV5h4+H0jOpYmzxQoCPz3FlPlxl15a7xnviLdN4Zvh+LHSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737382001; c=relaxed/simple; bh=kjgZ+f0h/F+kfr7GN+JUT5FIfkXzooBUO3hDVQ085To=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LcmyQ4qJfuzBeJW7hLX2UTJYubsKxv9YfztBM+ZwNoWtL0xTQAgVZd4WuVAHazwA4U5giCBNRxa9qCDrd9wh9AsSy2TXLQb/D1X6hIAf125E7NiXa3lSCw9sbAokVVFXoWQX64OOAY6gPEv8wKFx6hZvTdmnoMiaCkqHxfFR8ho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [220.197.230.167]) by APP-03 (Coremail) with SMTP id rQCowABHLjFkWI5nI0xpCA--.47582S2; Mon, 20 Jan 2025 22:06:31 +0800 (CST) From: Wentao Liang To: gregkh@linuxfoundation.org Cc: elder@kernel.org, johan@kernel.org, ayush@beagleboard.org, lee@kernel.org, francesco.dolcini@toradex.com, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, Wentao Liang Subject: [PATCH] greybus: gb-beagleplay: Add error handling for gb_greybus_init Date: Mon, 20 Jan 2025 22:05:47 +0800 Message-ID: <20250120140547.1460-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.42.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowABHLjFkWI5nI0xpCA--.47582S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GF4DCF4kJF48WF4xXr1xGrg_yoWkAFg_uF 48Zr9xWryqkayDA34jk3yfZrZavayjvFn2gwsrt3Wa934Sya13G34Y9rnrJFy5Gr4jvFWU Ar4Dua13AwnxCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb48FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r1q 6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbGQ6JUUUU U== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAcIA2eOJZ50PwAAsZ Content-Type: text/plain; charset="utf-8" Add error handling for the gb_greybus_init(bg) function call during the firmware reflash process to maintain consistency in error handling throughout the codebase. If initialization fails, log an error and return FW_UPLOAD_ERR_RW_ERROR. Fixes: 0cf7befa3ea2 ("greybus: gb-beagleplay: Add firmware upload API") Signed-off-by: Wentao Liang Reviewed-by: Ayush Singh --- drivers/greybus/gb-beagleplay.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/greybus/gb-beagleplay.c b/drivers/greybus/gb-beaglepla= y.c index 473ac3f2d382..da31f1131afc 100644 --- a/drivers/greybus/gb-beagleplay.c +++ b/drivers/greybus/gb-beagleplay.c @@ -912,7 +912,9 @@ static enum fw_upload_err cc1352_prepare(struct fw_uplo= ad *fw_upload, cc1352_bootloader_reset(bg); WRITE_ONCE(bg->flashing_mode, false); msleep(200); - gb_greybus_init(bg); + if (gb_greybus_init(bg) < 0) + return dev_err_probe(&bg->sd->dev, FW_UPLOAD_ERR_RW_ERROR, + "Failed to initialize greybus"); gb_beagleplay_start_svc(bg); return FW_UPLOAD_ERR_FW_INVALID; } --=20 2.42.0.windows.2