From nobody Sun Feb 8 08:48:25 2026 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73738149DF0 for ; Mon, 20 Jan 2025 08:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737361910; cv=none; b=iY6vqbbJhl7Z4D5oH2Hic7C/DYwZ8zxXYsLmGpI94IJVY75YaEPRg7nWUpnItqonSjsK7ZW6emBxwDdbwObFaWoBwfkrWc48zPyCIngReZVqGzhGKpACughKQTkcyNeMmjcbgtF//2/FGGM7uePIKfGgtN3B9M5lO4F7rjdBmWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737361910; c=relaxed/simple; bh=8MNARZeKLOoo7KEQ5eojMTG7Q31WgJLxJNh9rxOYJYI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: References; b=mRF10E8mSJsbEhlb/lQpp9MkFxba5SczCsKxzkV1lNT4MZMlbeRrAM4ErLcOHgTe1C39oQCHjXKplqDxwJr5i8YuAgdwWK4n5Q3hJQ+JhQpXdC4TA4FiZCJYPtvwXZMSkLp5Uy9aD/qm4Z4hbxIuUl57bQ/UegZFnQNryb9PIeY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=QMU+CwKV; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="QMU+CwKV" Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250120083146epoutp01684baf4e27b3d1b5f6109ae2d5b2a8ce~cWXLXrcH72969329693epoutp01D for ; Mon, 20 Jan 2025 08:31:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250120083146epoutp01684baf4e27b3d1b5f6109ae2d5b2a8ce~cWXLXrcH72969329693epoutp01D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1737361906; bh=PFtg831O7vXcEYWfi+aXWoG6moV9NaIl5fziBougHAc=; h=From:To:Cc:Subject:Date:References:From; b=QMU+CwKV8WKAfMWzsf+8knZWn4OSyfL7+yd2Pljc8JUDehsvDybGsPtARvZouhCx8 0oyvgbouVhBD+gJyaNA/xPwhMedMMxiKOvcjjWP2yMy9Nb4sX3pQz2wykYQd7C0qCH oG/T/h5Fv/bu67CeTCIkxayOQN0GyEU+iMy9oD+w= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p3.samsung.com (KnoxPortal) with ESMTP id 20250120083145epcas2p36218ee70b5aca7842c6bd91969e64794~cWXK11iFq2158221582epcas2p3r; Mon, 20 Jan 2025 08:31:45 +0000 (GMT) Received: from epsmges2p2.samsung.com (unknown [182.195.36.88]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4Yc3Tr6bGQz4x9QJ; Mon, 20 Jan 2025 08:31:44 +0000 (GMT) Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p2.samsung.com (Symantec Messaging Gateway) with SMTP id A9.32.22094.0F90E876; Mon, 20 Jan 2025 17:31:44 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20250120083144epcas2p369584af764b617c3d2cb2a0568a45d6c~cWXJ55rpR2157021570epcas2p3j; Mon, 20 Jan 2025 08:31:44 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250120083144epsmtrp1e3007458702c6e51180a2dd370ea4c02~cWXJ5EqI82137421374epsmtrp1K; Mon, 20 Jan 2025 08:31:44 +0000 (GMT) X-AuditID: b6c32a46-48c3a7000000564e-8d-678e09f0ae98 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 57.38.18949.0F90E876; Mon, 20 Jan 2025 17:31:44 +0900 (KST) Received: from localhost.localdomain (unknown [10.229.95.142]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250120083144epsmtip2c6c62e91c9931fc9935f7718dfade1b9~cWXJmMgyF0879408794epsmtip21; Mon, 20 Jan 2025 08:31:44 +0000 (GMT) From: Hyesoo Yu To: Cc: janghyuck.kim@samsung.com, Hyesoo Yu , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: slub: Print the broken data before restoring slub. Date: Mon, 20 Jan 2025 17:30:21 +0900 Message-ID: <20250120083023.4162932-1-hyesoo.yu@samsung.com> X-Mailer: git-send-email 2.48.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMJsWRmVeSWpSXmKPExsWy7bCmme4Hzr50g+MNJhYTewws5qxfw2Zx /dsbRou/nRdYLVZ2N7NZbJ5TbHF51xw2i3tr/rNatH3+BySWbGSymLhG1GJ2Yx+jA4/Hzll3 2T0WbCr12LSqk81j06dJ7B5db68weZyY8ZvF48mV6UweCxumMnv0bVnF6HFmwRF2j8+b5AK4 o7JtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4AuV1Io S8wpBQoFJBYXK+nb2RTll5akKmTkF5fYKqUWpOQUmBfoFSfmFpfmpevlpZZYGRoYGJkCFSZk Z0y7cY65YDtHxZNd51kaGH+ydTFyckgImEh8/32BvYuRi0NIYAejxIKH8xkhnE+MEtMPH4bK fGOUWL35GDNMy/rLH6ESexklLjXPYoJwPjNKXJh9CKyKTUBd4sSWZYwgtogAi8TK799ZQGxm gVXMEr0vzEFsYQF3iS8t78HqWQRUJZY+6gar4RWwkZj24gU7xDZ5idtrTkLFBSVOznwCNUde onnrbGaQxRICUzkkvt++CNXgIrF84RVWCFtY4tXxLVBxKYmX/W1QdrHEtsWHmSCaGxglNnfc h/rNWGLWs3agqzmANmhKrN+lD2JKCChLHLkFtZdPouPwX3aIMK9ER5sQRKOyxP5l81ggbEmJ R2vboS7wkOibOQtsq5BArMSCxX9ZJzDKz0LyzSwk38xC2LuAkXkVo1hqQXFuemqxUYERPFaT 83M3MYJTr5bbDsYpbz/oHWJk4mA8xCjBwawkwiv6oSddiDclsbIqtSg/vqg0J7X4EKMpMHwn MkuJJucDk39eSbyhiaWBiZmZobmRqYG5kjhv9Y6WdCGB9MSS1OzU1ILUIpg+Jg5OqQam/iny Hi0uiuwnV0te+zZ/fZftEt4fVdde3uC/vS1ix0PnCJFNJ/5dMBdMXthbtt+BPdrWO0Uubn7z 7t/PjM6zXnNyrDtqGVRpLmxlVerpra0icVHobqd2aef/pQVbl0VZf1fqPjPtat2+v1rGdTK/ uKyM9Zc+dnt1MPC50gbrhtUNBe4vlW7yblN3k/RNmyNaI7Y4ymvd1BksF+QdTzEEukjfPSOZ PbE80ltoQ4qoZl9a66erzn/L/Vfs+Kq+4JZ7YmJwM0u+xMlD71vexBzYpb1B7oBvzqINGnbP t0x/Hf6jwVyEqTx7gyRbp6qaSujboJvd+9uFEsXfvIm5uf/A8UUd5WwubqyMv6KStJVYijMS DbWYi4oTASgNClNGBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsWy7bCSvO4Hzr50g49nhCwm9hhYzFm/hs3i +rc3jBZ/Oy+wWqzsbmaz2Dyn2OLyrjlsFvfW/Ge1aPv8D0gs2chkMXGNqMXsxj5GBx6PnbPu snss2FTqsWlVJ5vHpk+T2D263l5h8jgx4zeLx5Mr05k8FjZMZfbo27KK0ePMgiPsHp83yQVw R3HZpKTmZJalFunbJXBlTLtxjrlgO0fFk13nWRoYf7J1MXJySAiYSKy//JG9i5GLQ0hgN6PE nz+bmSASkhKzPp+EsoUl7rccYQWxhQQ+Mko86DAEsdkE1CVObFnGCGKLCLBIrPz+nQVkELPA NmaJGwfngW0QFnCX+NLynhnEZhFQlVj6qJsFxOYVsJGY9uIFO8QCeYnba05CxQUlTs58AmYz A8Wbt85mnsDINwtJahaS1AJGplWMkqkFxbnpucWGBUZ5qeV6xYm5xaV56XrJ+bmbGMHRoKW1 g3HPqg96hxiZOBgPMUpwMCuJ8Ip+6EkX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzvvtdW+KkEB6 YklqdmpqQWoRTJaJg1OqgSn80Pw6X9F1KkohNakGJs///nvkXDgri//rrTCt69al6sfYrhyr 9Dgg3nnDqvj7XzX/yItc3GbWix4u3h7lZZ6ZvGjZ3IJ0wSM8zWz/b7gnrAmOyTz/xGPKh6/G F/d/2PNWT3cbqwPPfKNEu7fiEgrp+g9iA/ocHz4tEY9M2PrfwtHR+cCklz1f1Q/0Vsl9cHWc bZq659K3udYTTc9tVF2cr6jdc8I/SPTNeyb5K5ouTT+vSitLz3zHdzGt1bpA67dI0y79iy0T q3hXGptI8GRfFFIUc7K1O3BS9oCfRNWMlS7CBQob418LXbo9pSCFqZt9nsAMd/PJLpvqnTue iK0+GL7o5aao7ymHe8I3KbEUZyQaajEXFScCAEoxo1D1AgAA X-CMS-MailID: 20250120083144epcas2p369584af764b617c3d2cb2a0568a45d6c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250120083144epcas2p369584af764b617c3d2cb2a0568a45d6c References: Previously, the restore occured after printing the object in slub. After commit 47d911b ("slab: make check_object() more consistent"), the bytes are printed after the restore. This information about the bytes before the restore is highly valuable for debugging purpose. For instance, in a event of cache issue, it displays byte patterns by breaking them down into 64-bytes units. Without this information, we can only speculate on how it was broken. Hence the corrupted regions are printed prior to the restoration process. Signed-off-by: Hyesoo Yu Change-Id: Iac1df0526808edc2318f9988c757cdc3e40ae4b2 --- mm/slub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/slub.c b/mm/slub.c index c2151c9fee22..48cefc969480 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1207,6 +1207,7 @@ check_bytes_and_report(struct kmem_cache *s, struct s= lab *slab, fault[0], value); =20 skip_bug_print: + print_section(KERN_ERR, "Corrupt ", fault, end - fault); restore_bytes(s, what, value, fault, end); return 0; } --=20 2.48.0