From nobody Wed Dec 17 14:20:40 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70FB97E76D for ; Mon, 20 Jan 2025 03:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737344138; cv=none; b=cdm9MeZy/UOLxwd632bTtZAnQmyTINBQn2aiWNU4bznAnBpXaQ7A55DWGmhoNKPu19buxyXA7Td7cMUY4f+Wbyrr2AbfK/wIp+q88H20j0+9g5A4mXEODiyySXCGPqXwNftPkGU6s5LLYpgTvO9H6adtNg/BRFhTaPWqxbY5TaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737344138; c=relaxed/simple; bh=+zgJeiahRYhOewDI4lhi7m6DU4J3ga4hUeXcPfIztsc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Agiwd/Wf32IVCIPj6YfIGZSwt6NZL3UiM0wl5OPdLSTHUWVXE7QJs9Wsaa6YIYdxexfA0LEbRPOK/DHuxGCvw2kCn1c2f5AjrkkJmqHX8bZhSpAYnnDvNcOgD4Rs1dZtUedBjkH5gsh+SQssIRCJSz5VI3gL7C1FaMsvkrlChbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YAf0d85W; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YAf0d85W" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21636268e43so91307245ad.2 for ; Sun, 19 Jan 2025 19:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737344135; x=1737948935; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=I9SAvhC/1O9xhOgEJgltjPIiKB+jL/KUsbTgQGFrTOI=; b=YAf0d85WvMlw5k4QWLuTLDkNXRFFcVC5zvT/UI4E0RovlByRxk1KeXQCbMOMvr44Rc abB5l+FJVzyeC5EKGlZOLIlwJGZ5YDvc1wGahU8x6XMUTBQLMeFYwpUOvNri8CbsHGbP S5cEE3XUXHLuhc2E0AL2dATWK1EM7c6el3RbY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737344135; x=1737948935; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I9SAvhC/1O9xhOgEJgltjPIiKB+jL/KUsbTgQGFrTOI=; b=LKCs7miloEECmjbSrpHZ7w4LqTacTqujOBzS5oxG2p2wYkgXxeTgsrfb2liDnyTijC srpJkrMNdD1Y/b6RQ5vlITHmIUy3d6p9KLWSewlD40UFc3NV+RLrJejOHenASXab7jF7 ua8t/A0ZXWp/DZbFAMvChhogW+mq/JuUKRCZV/cSVxS1LIqKM9rQPJAd3YUrqW7PNG7F eHJ7aYVExTiIXGbtPoy1up9Y6T7Dqwfz/Z7+Vr1hPTC7oSHeJjMfKv36C2b66Wukvg3q +NH5ffxuhN1ImY14D09PnfQrRKW/y3ByAXz2lGFlUmJzgKWjezadBNV0CsuptC8mxJYC JpKg== X-Forwarded-Encrypted: i=1; AJvYcCWdL6G9o4QoXw0WpDQ0MciMWJZTLh34qgfIKEh1wjN40uYc+Lz3i8q6pKVTyJiJQ2JcQHv1uEhiBRuNlk4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6W3jjFB3x4Ys5natol7peiBh+kEu7rPBtKaOCNKZxn0UjYXCg zfKgrrnQQv3Ak8J38b7BhZoeNIYRqP57muTyN02HVz5SyWnPOe1yGTQZC3c0qg== X-Gm-Gg: ASbGncuMAI0Do7Sq+ep/jyyVkcTOF0PWcO3rk6cdkl2Mu8pYezT7wLsN+DJNnWxAS2Z NnqTPWYfM2eKxuTnIjRYs8qDl6HTurbYo2CTNvQuEyasthW+/vY7kza6aumdHtXgfUtnrM+aF3l S2+7tnAp4TPwz1cKs+THXlQ2gZBJcclFHux/pQltd311uu6i7hVEP/f4hYE8U7aKWul1nyKZujX BFrZhy7/9B3kjATLpmK62nB5LlUmYXgAN0N7NsJuXD59mXZU8HH4rFTgdrHdi+ZqUdaZEXc2zm0 rNe6gixFD+UZ6ff/ZX/x/HMSuKeMJ2XAnRHWY2uXjdLZA2OMatrr9O1jkBTk X-Google-Smtp-Source: AGHT+IHoRnpouPTg9I2Td3asAfewVxkgQF59sVedTc1vZI0Q7LF6MuUmo+EelqKGuxFWOIGciJakbg== X-Received: by 2002:a17:902:e74c:b0:21c:fb6:7c50 with SMTP id d9443c01a7336-21c3558fc36mr180974915ad.31.1737344135597; Sun, 19 Jan 2025 19:35:35 -0800 (PST) Received: from yuanhsinte.c.googlers.com (176.220.194.35.bc.googleusercontent.com. [35.194.220.176]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d3a91cesm51473855ad.133.2025.01.19.19.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 19:35:35 -0800 (PST) From: Hsin-Te Yuan Date: Mon, 20 Jan 2025 03:35:29 +0000 Subject: [PATCH RESEND v3] arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250120-post-reset-v3-1-8f394bb25c8f@chromium.org> X-B4-Tracking: v=1; b=H4sIAIDEjWcC/3XNPw+CMBAF8K9COlvT61n+ODnI6qCjcQB6SAcoa ZFoCN/dhsVocHzv8ns3MU/OkGf7aGKORuON7ULATcSqpujuxI0OmUkhdyAg5b31A3fkaeBFFce lQAUxIAugd1Sb5zJ2Zef8kp+O7Bb6xvjButfyY4TlujY3AhdcFYUuE6WEwORQNc625tFurbsvS 6P8r2XQMtUKM51kBOmKxo+WgF8aOXCqUOg6KzNM4UfP8/wGs95tuisBAAA= X-Change-ID: 20241018-post-reset-ac66b0351613 To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Hsin-Yi Wang , Benjamin Tissoires , Hans de Goede Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.15-dev-7be4f After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of"), the i2c-hid-of driver used by some mt8183 devices resets the touchscreen without having enough post-reset delay. This makes those touchscreen fail to get probed. Switch to Elan touchscreen driver, which has enough post-reset delay. Fixes: 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of= ") Signed-off-by: Hsin-Te Yuan --- After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to i2c-hid-of"), i2c-hid-of driver resets the touchscreen without having proper post-reset delay on OF platform. From the commit message of that commit, not to decribe poset-reset delay in device tree is intended. Instead, describing the delay in platform data and changing to use specialized driver is more preferable solution. --- Changes in v3: - Remove patches related to the race condition of pinctrl since they are not needed anymore. - Link to v2: https://lore.kernel.org/r/20241018-post-reset-v2-0-28d539d79e= 18@chromium.org Changes in v2: - Add second source touchscreen patches since they should based on the first patch of this series. - Link to v1: https://lore.kernel.org/r/20241018-post-reset-v1-0-5aadb75500= 37@chromium.org --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts | 9 +++--= ---- .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 8 ++---= --- .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts | 8 ++---= --- .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts | 8 ++---= --- 4 files changed, 9 insertions(+), 24 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts b/a= rch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts index 65860b33c01fe832f3a4b2e21d24ea6b4f0cba2b..b226dfee22669d596e5b45a7cc0= 2133ee4aaa828 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts @@ -14,16 +14,13 @@ / { }; =20 &touchscreen { - status =3D "okay"; + compatible =3D "elan,ekth6a12nay"; =20 - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&touchscreen_pins>; =20 - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; + vccio-supply =3D <&pp1800_alw>; }; =20 &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts index 72852b7600383972d98d9b0edd40b6e99e34a85b..863f3e403de8577da41b17b144c= db17c578b2027 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts @@ -27,16 +27,12 @@ &cros_ec_pwm { }; =20 &touchscreen { - status =3D "okay"; + compatible =3D "elan,ekth6a12nay"; =20 - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&touchscreen_pins>; =20 - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; }; =20 &qca_wifi { diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts index 757d0afd14fb064fc1de4608e65eb1a561c4dfa6..e0a583ce4a0bb18095a77d23ab8= 409bb80898979 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts @@ -14,16 +14,12 @@ / { }; =20 &touchscreen { - status =3D "okay"; + compatible =3D "elan,ekth6a12nay"; =20 - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&touchscreen_pins>; =20 - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; }; =20 =20 diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts index 6641b087e7c5f3a957e43ac985137dfd84ac7878..7874c9a20e124c65ace3f90e2ec= 5bcaf59b69c40 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts @@ -14,16 +14,12 @@ / { }; =20 &touchscreen { - status =3D "okay"; + compatible =3D "elan,ekth6a12nay"; =20 - compatible =3D "hid-over-i2c"; - reg =3D <0x10>; - interrupts-extended =3D <&pio 155 IRQ_TYPE_LEVEL_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&touchscreen_pins>; =20 - post-power-on-delay-ms =3D <10>; - hid-descr-addr =3D <0x0001>; + vcc33-supply =3D <&pp3300_alw>; }; =20 =20 --- base-commit: eefa7a9c069908412f8f5d15833901d1b46ae1b2 change-id: 20241018-post-reset-ac66b0351613 Best regards, --=20 Hsin-Te Yuan