From nobody Mon Feb 9 10:53:17 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04801192D97 for ; Sat, 18 Jan 2025 16:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737216411; cv=none; b=Xpp6Poqp2Vf1tXX+KEZIzCaqe4G259WNaT2D5rOQs2Q33bBsuYLuATMk+gJysp9whrQ/nhy6YX4iYxqGePCsCO/FrySVYY/nRZkPaYtOr9agnaNglnq5lqHi+/TJ+S1XCrNwUdWlPGNaY1wUg99ZNLReS2l1eWhPh1NQfTJ/h0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737216411; c=relaxed/simple; bh=PyTcByFh1ldqoKGLS1bOfbG6mR8/FvgcbUmeA19Z0Rs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eBg2WPPlAJImmMhoYogvJuC3ow0t+ItIwuZqy3LcGl8r/GRGhrF+8pyQjGCru4esSo/ASOmwjjItNok/Y/yW2VaA6Pm4uHv5bYTQ5Sr2epzZy7dZiFsGRM8+R3dA/pzxQfbZGcpJW4eNx8pjth0EL26HQr6LQVGvTz8s76t013Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZaAp4Tvv; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZaAp4Tvv" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4363298fff2so4304575e9.3 for ; Sat, 18 Jan 2025 08:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737216408; x=1737821208; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vwdCXA8clqNZfv6cNEYqxDS+Or4qZ1J1EVJqPwpo/9c=; b=ZaAp4Tvv3xNpUxhqHmVuFsfGQjJXOltilaCYfKcVzDI9riWe2cgbKmsW4Rs5AcLnhQ N1vb0aA2I8G8Wu1bjrd2thvybjfgKYIpc+AGrlCqaCAZQifog5v7TcRgMeoMW8AgZ8gw 4lvKUIczwXqFcGYs6c7WXCxojdZEbNzm87P3bIy/N/QB6rRBXwI50jo1r0wh34XILxHj jxNm3TSogkwnqbOAdyxl9t3tMuqp8vA9vxX4C/rMiMEBk9PU6Us8MoGErUkbnr3x3yYJ DUlkT124cTBHoCaLW/NX0+BkCt2SPKnWz/u7KtGsUMYl9G1yxlFSDqZl7f20rjdkY3wx JWbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737216408; x=1737821208; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vwdCXA8clqNZfv6cNEYqxDS+Or4qZ1J1EVJqPwpo/9c=; b=Vzvgys1C+PaVPFSp47U7kZgGXia7NxMuy+YSlkP6DtWUYBTPmEDcFjNCDF10wgxF+z Kdn92mLDJoq4FUzKpaABZ/+uZ/lSCUBvgT/aA0hmHsRtQtGF0mJ5KzePBfz+wQhag5aI +KgeKUrNTc1KwA3wpt3tNVQuuQUW6pV2SpwA+ZcSBsvGtzosg9c3GR7hbcRltiOzWseh UMl9mwvmrc8Ucx6tuxwk2CLXnd18DDXwb8xS6ZVXrNffXEdGF3ZaebkXzICLeD8xAcs3 xWmVFd0vAf6Y1LPGp7Dxtu5HNlFyy43gCirOHwo7Xahs9kzj/BzoQdbovZzEs5oE6ruN Dffw== X-Forwarded-Encrypted: i=1; AJvYcCVsDBPPEKY8X++982LXQKPBYCIVG5NMKVY5IPS9uILDSp4Ahzm8FtWWd7m+eF4d6IzlFN1uzC/T+rkV+zA=@vger.kernel.org X-Gm-Message-State: AOJu0YyNA7y95mbQyLqqrTrBSZb7c+cksD84p1AwixM0Kz24NhL8lTj8 jGNn6FZtneWo7kAxX9c8UBTpfEdCVgN0xu6ULGJ47tx2I4JKd4Rfn0e8s6lmwek= X-Gm-Gg: ASbGncvoVW1RTIZR23emlQGh0KXbnDEzLuY/Z0HKFWnshPF2IWS/n62jvtNQ77cUcW7 XzviEvUsVIs0lNSXdMaARxO0QyH69mAbOXiF5tPd0Rk5HhcU1oKizpEYHnVJV3SnK+eaxA51NNh ESKudIknJ5UM7we7CHL8rv3fxHt13ilYmVMQHrzkAfwh2TpUqyUhbg/HXtTVmOVtToPhmMOG3Ut 5qJCCNCnVA8NRUH3JsV1Pnwqn6dAG1393yFY9ELTZUr0H2RwtcbwN+2RYtCm/iXpADsjljN89VK 24eyz3fV X-Google-Smtp-Source: AGHT+IFMVBWg/sRcSunUViba7PAtliDqmSrFRcKnOLFwmE1beALCtPs34+Tkf+oAZ7uLqe5eQ56YKw== X-Received: by 2002:a05:600c:510b:b0:436:fb10:d595 with SMTP id 5b1f17b1804b1-438913bff64mr26793385e9.1.1737216408218; Sat, 18 Jan 2025 08:06:48 -0800 (PST) Received: from krzk-bin.. ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74c475csm133966725e9.20.2025.01.18.08.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 08:06:47 -0800 (PST) From: Krzysztof Kozlowski To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH] drm/panfrost: Drop redundant Mediatek driver data Date: Sat, 18 Jan 2025 17:06:45 +0100 Message-ID: <20250118160645.78473-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mediatek_mt8192_supplies are exactly the same as mediatek_mt8183_b_supplies. mediatek_mt8188_data is exactly the same as &mediatek_mt8183_b_data. There is never point in duplicating all these structures - it only raises questions or encourages bugs when someone updates one variant without changing the other. Drop duplicated code. Signed-off-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panfrost/panfrost_drv.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panf= rost/panfrost_drv.c index 0f3935556ac7..12ccc5a11c0e 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -817,21 +817,11 @@ static const struct panfrost_compatible mediatek_mt81= 86_data =3D { .pm_features =3D BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), }; =20 -/* MT8188 uses the same power domains and power supplies as MT8183 */ -static const struct panfrost_compatible mediatek_mt8188_data =3D { - .num_supplies =3D ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1, - .supply_names =3D mediatek_mt8183_b_supplies, - .num_pm_domains =3D ARRAY_SIZE(mediatek_mt8183_pm_domains), - .pm_domain_names =3D mediatek_mt8183_pm_domains, - .pm_features =3D BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), -}; - -static const char * const mediatek_mt8192_supplies[] =3D { "mali", NULL }; static const char * const mediatek_mt8192_pm_domains[] =3D { "core0", "cor= e1", "core2", "core3", "core4" }; static const struct panfrost_compatible mediatek_mt8192_data =3D { - .num_supplies =3D ARRAY_SIZE(mediatek_mt8192_supplies) - 1, - .supply_names =3D mediatek_mt8192_supplies, + .num_supplies =3D ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1, + .supply_names =3D mediatek_mt8183_b_supplies, .num_pm_domains =3D ARRAY_SIZE(mediatek_mt8192_pm_domains), .pm_domain_names =3D mediatek_mt8192_pm_domains, .pm_features =3D BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), @@ -857,7 +847,7 @@ static const struct of_device_id dt_match[] =3D { { .compatible =3D "mediatek,mt8183-mali", .data =3D &mediatek_mt8183_data= }, { .compatible =3D "mediatek,mt8183b-mali", .data =3D &mediatek_mt8183_b_d= ata }, { .compatible =3D "mediatek,mt8186-mali", .data =3D &mediatek_mt8186_data= }, - { .compatible =3D "mediatek,mt8188-mali", .data =3D &mediatek_mt8188_data= }, + { .compatible =3D "mediatek,mt8188-mali", .data =3D &mediatek_mt8183_b_da= ta }, { .compatible =3D "mediatek,mt8192-mali", .data =3D &mediatek_mt8192_data= }, {} }; --=20 2.43.0