From nobody Sun Feb 8 08:22:21 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E47C118FDBD for ; Sat, 18 Jan 2025 14:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737211865; cv=none; b=QeoZA69r0DSTvRaNIM2B0lez7BAqR4de6iRErviENvnzFay9Fh1HJKxITFDfOkNgOs0jKW0ERt8UfP3lY1ohjkST8OzTJtlBEVeEhZNl/cOhYcwLuoSEiRNrTnFs1wsx/MW28JgNethbE0H5B/nV6Eh79jaG0IRowL8P1/pb0Vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737211865; c=relaxed/simple; bh=CEBNE5aqF58645wo8cHthYPuUfVRK/7AczWCqYZ6Flc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t98X1F1ockcECapk9EoPvXtjtXCHSC6YZCGQIAsc7jXD5qRPOdUSP5p7VkwpgefJyNBXtCU04TmPvTxHO2E1d6rIFtQ66DYrsUiYIvJloH4OkBIefvxQfCRBGTtrzUYkHNYVfqQKCQ7S41lfi7mSCfmKPDEIrxnqXfvh41Olp+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DFuObGTq; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DFuObGTq" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43624b2d453so32076005e9.2 for ; Sat, 18 Jan 2025 06:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737211862; x=1737816662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1UV4T0AyhTiydD8vQiYizGE0EyIbVgUsUfJj0/tNcZk=; b=DFuObGTqGlB5B5wWuIXYaXhSiOxnklOxzyb6dzWTEFGgMVdkEkH9qUmV4n1FjXIxHs QsHxZoCQxhQrREeD8i/kDHD03iserdwHZfKGAMoGPfD6hNOaS3Btoi43YodZxpEyouee HDY8rxwrRdICX3qXwtMmvdplbMPbHqZRjKWEv/VDOafby1i5uJOeTjxQ3hgp+j80XbMH S++UYXqrt33dHP1d54QJCQY/Ry8CozkCNSqmlCecNnLXMNmrUVx+1hnXq6KUCZew0dJO 8vZm0OzB5iM7H/3x6cOCz6tTRbIiplA/uKhQOH9UezpytRgUF0wSFUTEEEsKJRN4afOb VVCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737211862; x=1737816662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1UV4T0AyhTiydD8vQiYizGE0EyIbVgUsUfJj0/tNcZk=; b=qBKq4jt2MYBnCI9LHfPENefbNFxbDdjSDEQzF+TmrYGstIUU75ogI/OAhXSmcrcZ2+ FK5vzqh4+WEwjD2y+QrmVb7Vw2dbN4Bcl5jd12LBiA4sroRHvDSRaf/psbgOVPu2maQB bS7mNPvecisHQJZNGd3s5hqAoK3YfaI3JVuXQoTF7QtSEzlEv/A1wEFQ/3EJCbdL4H5M irvmC6hggcLJdx9ZRoOrlb8o368NzN5DLJXMFT4zU1nRwndmwhqIxNvHJDYGtY/QhTNf ZebqUtMWufVElCKNZV5qk7Vk2SV9ce+DY3XljJx3gWJFcI5KGLzse0yOdwcTpdP0AxR9 B+Kg== X-Forwarded-Encrypted: i=1; AJvYcCXIXyBu+dAisWeGTEgHxNpklNht2noQXbcDlnGlhkGPkVV/Bc/84VWmktpDFhbK5NJexchw+sFWKVIPd00=@vger.kernel.org X-Gm-Message-State: AOJu0YwYIW8/x31fDVxh6+x1bdCMxRebq4FDiBSlQqCvVOjngtWQScy4 45brjAfDokdMj670ujTOCAdK1fAy4CvZyl5jgu02f0lfLVv5z3k0 X-Gm-Gg: ASbGnct56m9mnDyTsl9FaniVmH1doCXEetc2A+o0tfwDc+zG0ATIRE2t8khuCX/04co 8iOp+0JFz8xEInZf+386QVRZ+JTWrBtXDAjyoXb2Kynp97jatYMqgkw221MMZlgKRe3E0SVRGWM 0suLJ04SQViAFksq4YeVDcNs/R1G02107wyUX39qqp6sOqcTfbdN/XwdSXCZ6NFDEI6FV0/Qh9l fy4NHrvakuSdc+g7v7Gu5w0p8CPzQY5+4foigi4hDshSPdcV/K8UQPUhmmxNdZfCKoliRVD5804 nH8eS4ErMk/RK3ASNF+U2jyEXfs9hw== X-Google-Smtp-Source: AGHT+IFprDQmQq1Ux5LjJhPX1ZQwUvRsHWEBK4lQQbtL259/eEmbL6vlcbnz4lL3fKQuoQIm5IErEA== X-Received: by 2002:a05:6000:1a85:b0:38a:88f8:aac6 with SMTP id ffacd0b85a97d-38bf57a77c7mr6364687f8f.41.1737211860466; Sat, 18 Jan 2025 06:51:00 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c103f0afsm74701735e9.2.2025.01.18.06.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 06:50:59 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler Subject: [PATCH 1/2] staging: gpib: Fix NULL pointer dereference in detach Date: Sat, 18 Jan 2025 15:50:45 +0100 Message-ID: <20250118145046.12181-2-dpenkler@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250118145046.12181-1-dpenkler@gmail.com> References: <20250118145046.12181-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the detach function is called after a failed attach the usb_dev initialization can cause a NULL pointer dereference. This happens when the usb device is not found in the attach procedure. Remove the usb_dev variable and initialization and change the dev in the dev_info message from the usb_dev to the gpib_dev. Fixes: fbae7090f30c ("staging: gpib: Update messaging and usb_device refs i= n agilent_usb") Signed-off-by: Dave Penkler --- drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index 34d85a1bdb37..2aaccebc3c7b 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1442,12 +1442,10 @@ static int agilent_82357a_go_idle(gpib_board_t *boa= rd) static void agilent_82357a_detach(gpib_board_t *board) { struct agilent_82357a_priv *a_priv; - struct usb_device *usb_dev; =20 mutex_lock(&agilent_82357a_hotplug_lock); =20 a_priv =3D board->private_data; - usb_dev =3D interface_to_usbdev(a_priv->bus_interface); if (a_priv) { if (a_priv->bus_interface) { agilent_82357a_go_idle(board); @@ -1459,7 +1457,7 @@ static void agilent_82357a_detach(gpib_board_t *board) agilent_82357a_cleanup_urbs(a_priv); agilent_82357a_free_private(a_priv); } - dev_info(&usb_dev->dev, "%s: detached\n", __func__); + dev_info(board->gpib_dev, "%s: detached\n", __func__); mutex_unlock(&agilent_82357a_hotplug_lock); } =20 --=20 2.47.1