From nobody Sun Feb 8 05:41:53 2026 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93A4158870 for ; Fri, 17 Jan 2025 14:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737125555; cv=none; b=NCjBUqA1wsY8dP3hnkmAgHC8MNuyjl21VZT5TrIi/ZtsFQHIHasTA5XL2ueggTG98O6SLXSzy1QEp6E5QlX7MXbOmeYThM2erFMJUAyIpYnipqgg6teaDd36F1Ysf2seoim9Pg6F/POcWoDL+6JV4iQOLL6t93MVLGEqFL4NYAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737125555; c=relaxed/simple; bh=5J4AZvRQtd0jwQned4Psju+UWQ21Z5vmi0SkZhwO7Hk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IVuL2duNvyYXjsgxAqH4qynbfKoWn8AIuFL0NN7R6vczXNtVuUULTGy+NOeVyzh7fEHwSfHMGyAVX3nxDHe4UQvgdE1j1hbYYpKpVSTOFTL+7MtgQMfQmK3/8lpVePyiZHcIToLkgsRBYuVQ5muHJrUB+NOKM29Vvl0m1TkyNhE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hf8xgHR9; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hf8xgHR9" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737125551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vSPcSIZctdkIAxs36t1OM73yFNJbU7uHr4OcuGpSKo4=; b=hf8xgHR9JxIcbG3Jm2aNg2RHwTO2SYhs0Eo3/Lu2Mt43B5AuGds5AonBN1obg5KRzsQbRj iLZtoz0eLXCq32PYGHRGAGl6enFkJNvy8otWqrT2mCUxoXpWFZPD3D9WQRK6IQebX+pFBI FvmA4qlToo2D7bI4hQPPab3rQBCMH3Q= From: Thorsten Blum To: Miklos Szeredi , Amir Goldstein Cc: Thorsten Blum , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] ovl: Use str_on_off() helper in ovl_show_options() Date: Fri, 17 Jan 2025 15:51:57 +0100 Message-ID: <20250117145155.171969-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Remove hard-coded strings by using the str_on_off() helper function. Signed-off-by: Thorsten Blum Acked-by: Amir Goldstein --- fs/overlayfs/params.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c index 1115c22deca0..8a8bb336b40f 100644 --- a/fs/overlayfs/params.c +++ b/fs/overlayfs/params.c @@ -1053,17 +1053,16 @@ int ovl_show_options(struct seq_file *m, struct den= try *dentry) seq_printf(m, ",redirect_dir=3D%s", ovl_redirect_mode(&ofs->config)); if (ofs->config.index !=3D ovl_index_def) - seq_printf(m, ",index=3D%s", ofs->config.index ? "on" : "off"); + seq_printf(m, ",index=3D%s", str_on_off(ofs->config.index)); if (ofs->config.uuid !=3D ovl_uuid_def()) seq_printf(m, ",uuid=3D%s", ovl_uuid_mode(&ofs->config)); if (ofs->config.nfs_export !=3D ovl_nfs_export_def) - seq_printf(m, ",nfs_export=3D%s", ofs->config.nfs_export ? - "on" : "off"); + seq_printf(m, ",nfs_export=3D%s", + str_on_off(ofs->config.nfs_export)); if (ofs->config.xino !=3D ovl_xino_def() && !ovl_same_fs(ofs)) seq_printf(m, ",xino=3D%s", ovl_xino_mode(&ofs->config)); if (ofs->config.metacopy !=3D ovl_metacopy_def) - seq_printf(m, ",metacopy=3D%s", - ofs->config.metacopy ? "on" : "off"); + seq_printf(m, ",metacopy=3D%s", str_on_off(ofs->config.metacopy)); if (ofs->config.ovl_volatile) seq_puts(m, ",volatile"); if (ofs->config.userxattr) --=20 2.48.0