From nobody Sun Feb 8 18:39:19 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A9E26AF3 for ; Thu, 16 Jan 2025 22:46:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737067569; cv=none; b=e+tDuRdv0D4ZnJtUWGjMFO26BzUNEJVpg26giosFHweNiocyqeZCLSO+bKbeLf7DH4/2r08njegtk8/3DUX30JCYqRnzy6PzTvP+ztVGuktBCLYzq5jSU3OVWLtmXS7YXA8aAswD0tnqFhYyaQVbux/z8kGVVWyMCdfkrj4Y34k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737067569; c=relaxed/simple; bh=c+HBWu687+WEKdvLXDm3514Q8jhP5/R+MI5dYLs7opk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ISpzGv0Nc6qCOMSMFFt8RMAjWPbeeM9ZhiL/7PY5C710RrpGAlNLAaVfWz50JNJU5xG3+zl7kvT1VS+cjaNx5DFRsZbzVddLG5dCHtGi5bnQcaQk+cZFvvt/a7/GUPGnCB2xOzN6r5r5T90BW4iFbqptjz29b/5mgzPlGQuzmW8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=btL1FThx; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="btL1FThx" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2162c0f6a39so51036855ad.0 for ; Thu, 16 Jan 2025 14:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737067567; x=1737672367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vNXzWEgJPL/lLJ3+6ZDIxk33qGNZqwz3zDtaJT4T8wU=; b=btL1FThxM3NzSqueZVIGIwJL2VSqxbluFy/wQoFEqO0+HyAvO8q5SWNjkwerwN7Ipp W0ScVah36p08uzmzpjv0X/mo+OEydgQcOb4clJt08DGtgFQnQD8mQhXrlGMR4IIYZSCJ 7Mfjf4vjH1sfST8CeS0+1zOkiV+rlawpIu/9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737067567; x=1737672367; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vNXzWEgJPL/lLJ3+6ZDIxk33qGNZqwz3zDtaJT4T8wU=; b=r4KkaECK8jDfgbx/7FjCzb42E1sz3czKvqjz50SooHuLm8z42JmCT9pCL1i+POK6mr fsS9isTkwaPpoc+reT4sKBxTquQli1Cz6etqI9aC34jkIjuH/3gOoYTtqBBeM+362lNg F5XuNQSUr0JGdVYXus3KDch5EN1K/cD2jGVvw6b7ycbhHQAnYPjurCXnFDplU3fFvfNX j3CcLxh0UfGFiKmBMeypE3C2mRi8VIBCZ1CMKWESk+JW+ZFxslp6/qfgQ98aQeCjbR0X 6jCvCEGLhQR60ZaXb0oXouK/TqPkAdt/QHDmcD+lyaPcnRJahttL9Md24gtwkQ5BgOps wMpQ== X-Gm-Message-State: AOJu0YxeQX+Nod2ghdUF0vXxXiNN3h2ULdZT5RJ3FHOLQOUdqKhUfwjX 2aT6pJKGX7DkRKJcT7WzUWvgKS3sx4OUbHAgTMmo1hdul79+7PhhJ98qGBlfEA== X-Gm-Gg: ASbGncuMOiP0ewaQ1CFq8zzsYuccg2b6T6rF4jwqkwNWV5MNKKPYjKyskEtLgw6yZcA wmpK4ehXbpouH1a0kcjA/ymwXdN6i5gXIrtDw2OLz9lRhS2AF/9t2ibDQ6jRib58ee84UWsUgyL SOa8ZYbQgH5JlefjnRuZlEsFex+M13gZItw4cco9XWqIV3/iTJQvnf4HVNTIt7Z1fWRG9uvXywM cPFY31ZBVCTeKhd0LuPoJhfQr/IlReTz3cPXV7WT/Nv6VdeFHlj6cqOMCgW5m6hRJ59srJax9k+ eEILxwPAPFFymhp9tAN3YLqi+qC0mk0J0w== X-Google-Smtp-Source: AGHT+IEEcYdDNcwVDoUsZ04wTmaoY1a9RQqIAv+Dv/a9lgAS+MG7jy1BOJNtfWL+Yj7Uawd1h3v+9w== X-Received: by 2002:a05:6a00:1d12:b0:728:15fd:dabb with SMTP id d2e1a72fcca58-72db1c5d820mr509975b3a.8.1737067567088; Thu, 16 Jan 2025 14:46:07 -0800 (PST) Received: from localhost (129.135.125.34.bc.googleusercontent.com. [34.125.135.129]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-72dab7f07b9sm536780b3a.3.2025.01.16.14.46.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 14:46:06 -0800 (PST) From: Stephen Boyd To: Wim Van Sebroeck , Guenter Roeck Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, linux-watchdog@vger.kernel.org, Lukasz Majczak , Benson Leung Subject: [PATCH] watchdog: cros-ec: Add newlines to printks Date: Thu, 16 Jan 2025 14:46:04 -0800 Message-ID: <20250116224605.110870-1-swboyd@chromium.org> X-Mailer: git-send-email 2.48.0.rc2.279.g1de40edade-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add newlines to printk messages so that the next record is more easily readable. Cc: Lukasz Majczak Cc: Benson Leung Signed-off-by: Stephen Boyd Reviewed-by: Benson Leung Reviewed-by: Guenter Roeck --- drivers/watchdog/cros_ec_wdt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c index ba045e29f9a5..716c23f4388c 100644 --- a/drivers/watchdog/cros_ec_wdt.c +++ b/drivers/watchdog/cros_ec_wdt.c @@ -58,7 +58,7 @@ static int cros_ec_wdt_ping(struct watchdog_device *wdd) arg.req.command =3D EC_HANG_DETECT_CMD_RELOAD; ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); if (ret < 0) - dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret); + dev_dbg(wdd->parent, "Failed to ping watchdog (%d)\n", ret); =20 return ret; } @@ -74,7 +74,7 @@ static int cros_ec_wdt_start(struct watchdog_device *wdd) arg.req.reboot_timeout_sec =3D wdd->timeout; ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); if (ret < 0) - dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret); + dev_dbg(wdd->parent, "Failed to start watchdog (%d)\n", ret); =20 return ret; } @@ -88,7 +88,7 @@ static int cros_ec_wdt_stop(struct watchdog_device *wdd) arg.req.command =3D EC_HANG_DETECT_CMD_CANCEL; ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); if (ret < 0) - dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret); + dev_dbg(wdd->parent, "Failed to stop watchdog (%d)\n", ret); =20 return ret; } @@ -136,7 +136,7 @@ static int cros_ec_wdt_probe(struct platform_device *pd= ev) arg.req.command =3D EC_HANG_DETECT_CMD_GET_STATUS; ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); if (ret < 0) - return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus"); + return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus\n"); =20 wdd->parent =3D &pdev->dev; wdd->info =3D &cros_ec_wdt_ident; @@ -150,7 +150,7 @@ static int cros_ec_wdt_probe(struct platform_device *pd= ev) arg.req.command =3D EC_HANG_DETECT_CMD_CLEAR_STATUS; ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); if (ret < 0) - return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus"); + return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus\n"); =20 watchdog_stop_on_reboot(wdd); watchdog_stop_on_unregister(wdd); base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532 --=20 https://chromeos.dev