From nobody Sun Feb 8 05:43:05 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10F521F37B0 for ; Thu, 16 Jan 2025 19:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737056164; cv=none; b=NMXNEmjyHVUyUO/PhUY0VDG97PWm+GQBYIMTx+c1Kkf6S2wZG/jjvjKR5Qr6OW7vMZwuNVK0+jbrraylYvHt3IexKxeUN2y+3YH3BfWoHUMkko3MWxLxMTat+VHjMu2aseBgxqgZPQ7vce30hv0P57IUK7Zpuu66ltP9NWETRC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737056164; c=relaxed/simple; bh=5bBIXOQHU72XekxGOpNyCTpS1E+gW4CTDZHw1O8AGOA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=r8a/DI8qUsVPin967BI3KRHBuZJsD6si45b4O06xrGmc7CIc3ryBzizyp3NGJwtEZpfJVw2QwuddVI3fJtFhof3/7DE2wy3M5WQpe4Oar/uwaRhIUA5IW/LdvAUF01vopGqut3DJgzoL0BYb0TyortCFXa1Gm//4NwNU/a/6so8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m1G/NWjQ; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m1G/NWjQ" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2ee74291415so1902683a91.3 for ; Thu, 16 Jan 2025 11:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737056162; x=1737660962; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=G4wAbBZBj0+zOetxiX42LWCqugc0wnUTNgzvXQ7kF3w=; b=m1G/NWjQZDs4FdnsV4ifzVhBqUQJ4e5ILKvQ1bTK4Oxp67xlG6GZ6G9Ne8Cg+FUnIG hkcFjSgJna7ZH9kTcXUz+ase+4iEBt3HtQn65uOvilhXUossgF+y90eyy4fabr+qqeMo L+BaFii9tmgQzdNSAOyzcdBv/uBlsZ4v6MRkWdxGgQf+d6q1MwKLWpAiqG4K1JhFoVbt YxWkkOeBqy6KzvrIXwGZ4Bgzc5yzfQJrmvv16F9CPcnuNBzIa+10n+l4L7GQ+/ejGC6W pkjeVq9YA1oWsLXiW5OF3xWPo6b0wEft+/kRbGZHr9/mQ/LToUGqmQ445sRc9eW4n5io JUkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737056162; x=1737660962; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G4wAbBZBj0+zOetxiX42LWCqugc0wnUTNgzvXQ7kF3w=; b=UN40gwv5j73Ks7ZAFVQ5WXAUqEBhi+cFU/SomEd3X8hr+eceqi31LdogF0rBVH3+fK QEO0lWGFXhVt39RmEJ7VlE6xWBWm0zh0wbgsz7Mx7fx9+o0d+Adx+YRw3BbHjIVG0Mnz sXY0EzHkH281cJfQbVJlLyGDAiPebeQUoc7atz8o4lJiq4uBZGZX9W2TsYacBcRiqtH+ GL+dFecl2wnwhVXGR3RE/wb6PQhzIzS/5GtLdzMr0SSM0ze1w+zADUw+K+rnjmAuD93E wCCLE7bgdqhDwzvsRq+X9TV5Uw2EEi2n3LHukbeE0plzpzmhKq5Ccf+IQqFVoVzVCWN+ lwxA== X-Forwarded-Encrypted: i=1; AJvYcCWGixkggD3I5hI0NARqAXRi9tr/exxM7jhNmV0dn9x7Jj2hjd9UShlL/fyGe4cxnJGjxjlg6uw7jeDgXkQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc96XimL8ycR8A6ByW7XGI07us6cMIY14UTU63zEyjt+f8h+LD WiWKZxU5mcsPW5OSncLwvmGeVAKWTRyOBXy7Dn4XOXjLYdQyCugw X-Gm-Gg: ASbGnctenXBGy6YpQGrSfZ5xFnHuSx9U1zQ0phqljCRUo/uiJt96HC1j4Wx8iIj7/uT sROocIz4fJMci/tScbSE/kNVEedhXE/JojyDyKs6c5XL3IeAUhCWGJWHym+9bC0urUiRcDQNpTj kZ79gip/+QjIb0qIrFoSYk9rqg1X6OMIRIg+qLmWBqUE3nEcAE7oefP/+zk5JIY6d8d8j1FZKdP hpFzaMHNaByiboAyXHYoDIpqAzfh9sIx9ilq/eNHCsxNpvH+V/q9w== X-Google-Smtp-Source: AGHT+IHOks7Ljvfrn/txdOGnk7iIRaBRwVXW8ePCTztJtOA5ASCttWU7RdhY4xhczGSz52UqQcsNDw== X-Received: by 2002:a17:90b:248b:b0:2f6:dcc9:38e0 with SMTP id 98e67ed59e1d1-2f6dcc93935mr33225257a91.0.1737056162343; Thu, 16 Jan 2025 11:36:02 -0800 (PST) Received: from s2lab02.. ([114.70.9.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f72c1511b2sm3993897a91.3.2025.01.16.11.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 11:36:02 -0800 (PST) From: Ingyu Jang To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter Cc: Ingyu Jang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915/gt: Handle INTEL_WAKEREF_DEF return value in gen8_ggtt_bind_get_ce Date: Fri, 17 Jan 2025 04:35:28 +0900 Message-Id: <20250116193528.2297487-1-ingyujang25@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function 'gen8_ggtt_bind_get_ce' previously did not handle the case where 'intel_gt_pm_get_if_awake()' returns 'INTEL_WAKEREF_DEF'. This value is returned when the 'intel_ref_tracker_alloc()' call within 'intel_gt_pm_get_if_awake()' fails to allocate due to memory pressure or other constraints. 'intel_ref_tracker_alloc()' uses 'ref_tracker_alloc()' with the 'GFP_NOWAIT' flag, which can return 'NULL' if allocation fails. In this case, the function explicitly returns 'INTEL_WAKEREF_DEF'. This patch adds a check for 'INTEL_WAKEREF_DEF' in 'gen8_ggtt_bind_get_ce' to ensure that such errors are properly handled. If 'INTEL_WAKEREF_DEF' is returned, the function returns 'NULL' . Signed-off-by: Ingyu Jang --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt= /intel_ggtt.c index d60a6ca0cae5..8d22d8f2243d 100644 --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c @@ -311,7 +311,7 @@ static struct intel_context *gen8_ggtt_bind_get_ce(stru= ct i915_ggtt *ggtt, intel * doing rpm_resume(). */ *wakeref =3D intel_gt_pm_get_if_awake(gt); - if (!*wakeref) + if (!*wakeref || *wakeref =3D=3D INTEL_WAKEREF_DEF) return NULL; =20 intel_engine_pm_get(ce->engine); --=20 2.34.1