From nobody Wed Feb 5 19:07:38 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 124EA1DE4E9 for ; Thu, 16 Jan 2025 11:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737025223; cv=none; b=YZ5s26SfKBAKlpLw+XBIP1o4/nx0P9uG/ZKoqBGwb720l3oAR/uNhCvFZ1yX2uwqqLWVxFCl+voM1pE2DXl+rtfJmBwXMdlE+Jhbzn6qnueufQDGYvPJFH0dZ7D9MSj7gJKcPiwWoSzq41t0WxWvn3HHUlccvqbZNm9brCgpvxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737025223; c=relaxed/simple; bh=ipM0MPZeXPihT5seNO+NiqYgP2E6p8/nfHYby3sp6dw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JQuSZD+25QlmehmGpLK5V0Yp6uH81cZ2e4rfvDokIznBzlGTDzlfZsKSiA0T305DwDrlwpmTqvmKeoEft9F1Qrypw4eoYiKEkjXPAs52Xs942V5ypeobGyPdhf+6zzB++2dB4Qyl7A6LO1l1i+t/Ipy46IK1wu/xhq1Bf2ipHlw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wj09Y1n2; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wj09Y1n2" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-385deda28b3so547659f8f.0 for ; Thu, 16 Jan 2025 03:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737025219; x=1737630019; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xepS2fu3cKrz8LIIOVhyaQuv0/xz6GPrtahTWM5I9dw=; b=Wj09Y1n2glgvDEzdd1TyvFt43NUdFCZaqAzaYdJO6h7EUrVMvpqmIYbQL/68HUeb7D zcPekiR5ygit6vcfb21vzczUnQlkzrjKIGqtWCHzXKM8SWIuzg/vSmHbNDzBuIIZs251 PA/VVbURhldbu30nh5yx3XKDvQSJAXLBEagmlKUkSEjoohGZy6uJPvIDOz+qdAJyd1R0 M2U+VoIQdsQ/DPZiqnx/2qqDvjojBIyPS6mlz5gThpbDXzm3+DLSMS5OmETR0q3B3+Xp SXV1YFy1rYlx209F4MlnXNHGCEkfsf4Lc7Gj6J2GNVd8rCsgUz7KEbZrN1TcCrez5lx1 g+NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737025219; x=1737630019; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xepS2fu3cKrz8LIIOVhyaQuv0/xz6GPrtahTWM5I9dw=; b=on9aL6FKcYK0OWzTTpgJP2popFvLRLCeyr4xUr1JimCY84pnLnr3m5JGa+TsdKtEot d54ovaY0AMKDZ81bJpDipOAOZzQjIXdcq5nJl0v97ewTG86tmN5Kt+Uhpk0uXpCptzIx RJpCpOpDJ4Sasz9wtWm/ymkjz6D78Z4yPeA/towJVwL1cxz34HLBIHECmI/LnLmXgFvp c5W6PcWE/XUM5AdFfDgXKS30pWs5qxCoZw4SxiKigNIOoH9B7wXe4hbwjXVscZCttH+G IxmtrJykTr400JtfFJ+cKYxOC/EdszuL/OKuMhURFXYMY8IzfYatlU4z555WHshR/bAe 8trg== X-Forwarded-Encrypted: i=1; AJvYcCX4aqUb5enIkWCwcRnm+3OjVeyo2rHiybbODqoubGFUAoPaVxmAY8kbeBISa32JyEN1Eajpq89IneIOrns=@vger.kernel.org X-Gm-Message-State: AOJu0YxRnQBbvsBEX80IPuoXtUwr154D8sNUOMLyU4/14Rcdqtw33Sjo Tl9Ck72dimhTX2Ii8nXrRegb8RPmLGEritk3AW5+qQeYOatD+McEsT4g5Lps X-Gm-Gg: ASbGnctmEuac/3q9f8TUBg5SIJmnKxsnG7sCDQN84acsi1Ixz+3dWnHNcyIo49o3xkf g2ofsb1jOdkOJ6D2itMAUKU4IvXs4Xva2SDmMMGELb7pfwFDVHexxOdt1dpxeRm6noAKADQfu7E qEIuee0VBiynBiakILeXUgo8LLGatYUNKA8ybP/1jYRmBnrvaJoGVNsqJeeBSj9HFXVrA64q+W9 cXWUBwXSfLwBxwIJcVYd6QLMXrQJS0OZsQ9wDOdw+NnaBI6bJuP923Q5olEdjRvGAQlEOJeWBDE 0cGjY7rpYx4VTKSI X-Google-Smtp-Source: AGHT+IGF1lYlRFxNhIQtUwEY0pqSA8S+Ddg4nfCQ4b41q5oJDp4RLShtNEZzQc0uPW8BibK8F7yT7A== X-Received: by 2002:a5d:5f85:0:b0:386:3213:5b9b with SMTP id ffacd0b85a97d-38a8732c132mr29635959f8f.43.1737025219100; Thu, 16 Jan 2025 03:00:19 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38bf78sm19934562f8f.48.2025.01.16.03.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 03:00:18 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler Subject: [PATCH] staging: gpib: Fix inadvertent negative shift Date: Thu, 16 Jan 2025 12:00:14 +0100 Message-ID: <20250116110014.15577-1-dpenkler@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During the initial checkpatch cleanup, when removing blanks after open parentheses, a minus sign in the argument of a shift operation was deleted by mistake. This transformed a pre-decrement operation into a negation. The result of a negative shift is undefined and a warning was signalled by sparse. Restore the pre-decrement operation. Fixes: 6c52d5e3cde2 ("staging: gpib: Add common include files for GPIB driv= ers") Signed-off-by: Dave Penkler --- drivers/staging/gpib/include/amcc5920.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/include/amcc5920.h b/drivers/staging/gpib= /include/amcc5920.h index 766b3799223f..7a88bd282feb 100644 --- a/drivers/staging/gpib/include/amcc5920.h +++ b/drivers/staging/gpib/include/amcc5920.h @@ -22,7 +22,7 @@ static const int bits_per_region =3D 8; =20 static inline uint32_t amcc_wait_state_bits(unsigned int region, unsigned = int num_wait_states) { - return (num_wait_states & 0x7) << (-region * bits_per_region); + return (num_wait_states & 0x7) << (--region * bits_per_region); }; =20 enum amcc_prefetch_bits { --=20 2.47.1