From nobody Sun Dec 14 13:58:34 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC05EC4 for ; Thu, 16 Jan 2025 04:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737002956; cv=none; b=jTDoFmMAyHZSi92jZVuyN1eqNH8eqWT7yr0ZPwBXt+ckWG996qY262b5tLAM5aFcJN4R1wdYB99JYxKILLlMv9XkGo5m7xLiuZtQKbKutb30yQKRf31hIV82h14CbAmj+c6lNwA51/2s6BG7mYUbyoxQO8rPKbQBRtRrOmV/5P4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737002956; c=relaxed/simple; bh=jSIuVmnCeI9YzpDhji3LrdLpzuDgD048WKzLLeY0zUk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uNzV5RoPyCzQrwPVg2FW0fMnR4wYt3CQcFFg4qeuNDYl9GSv5GvPBnJDhfikLEJdWL5KoYp3YEEm5BfltOsBapjanaEYSy2zOvIPlisI4vDN9BMJCItJLoHKfbvrYp9dmRWBdUEGRSoR6+bmBk0UZfJZhQ5G/1Hrmz0j92gvDKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=pf.is.s.u-tokyo.ac.jp; spf=none smtp.mailfrom=pf.is.s.u-tokyo.ac.jp; dkim=pass (2048-bit key) header.d=pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.i=@pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.b=gIs24NDO; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=pf.is.s.u-tokyo.ac.jp Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pf.is.s.u-tokyo.ac.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.i=@pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com header.b="gIs24NDO" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2163b0c09afso7408775ad.0 for ; Wed, 15 Jan 2025 20:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pf-is-s-u-tokyo-ac-jp.20230601.gappssmtp.com; s=20230601; t=1737002954; x=1737607754; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+oUEeSVLxJyACe9zcGnIcrOr/UNqBupfY9WFzURq6nE=; b=gIs24NDOknr0Qb8FuK/l/kj9h3KSYhF+7f6xj1IgvgMPS1GZtXdvt/Vz1C7gwtmHoF aVs1h3bBMtilx/2D9Rr+logUmSTrQwv+iHko/zA+ZX8dwd9itwBEi6r3ioSt7/gBye2f +a06oyfeObtLws0mR/Sj120fpnGXU3qdm+wOmO9IvXiwCfYrg8dZcd/y4yJjSrQS0hFE ohfVojYiTpYvx1jLhxigLuRIfSASqhWVJzfroylNS4u0LyyXgdlZc8nx2cekpCRFgSbC 8REJTxbkozIYyNaiAvampKjepGZN6TtHmU2hnTfg4Vp2xzoH7pwH46ook+WOoONSgjle VVOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737002954; x=1737607754; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+oUEeSVLxJyACe9zcGnIcrOr/UNqBupfY9WFzURq6nE=; b=Fys+qUqT0MzJmdhQ1c2GAN+c/BXCGK7ReuQGu7D3o9hSIkZSi0v8PsqtLWVBbhjSTO 7IdMnPoa0W9jH9epxhoGMWk109l5q6Z6TfYxFocIWG/6bwMmBrHBHrlYm7rRz7uZ6+2r n0gWM1LMMmsGZ6TH5uTcR44OFIsoDXERBJYCJ2VOP26bDL4+RRQiU0rmAm3hC6LCc7M4 2Xq5XgwPmtfjFqIFKdSIeWAqqs7g8UPAJ7/OgWGC34QrZUsxnImTKCYwbyhqJRhwxOCS Mup+Lv9mf6IiPFwWg5hDs1FLRExbg2tU7MdzcFX3/m5EqYWtWREabtMhzSF/6PXAlloT ctrA== X-Gm-Message-State: AOJu0YwWNClyaihazQdUDrNIRNNObW4aHW+bNIF/Ab4Uc2KBKg26ZUFZ XUzIxTqtXWVKsLrDLCQ709vYvukLZ/U0HbGeMD6hRD3Fna2nTKX35ZAEzlCzVhY= X-Gm-Gg: ASbGncs892JswGq55lcepRgtuQ4lVUbTP/k9YtF0G3momTls/2M4XGCCPVZl2lxwjC9 8LPG+j2jRdPiBlcrycVs91vplGUbx6kMfJ6zGz9A51TOXknuhicRKbM0qE0dFQNwnaG/MZuUKWS 3FsDyn/ebcDBMKWOqpt/3+hQ/DebPoiGdzg5zU+mAESYKX+aSBi9s8S+kp5feDtfDjSpJvHEEEB t7qCC9yY3Zv0ucvRPbg2X7/IRgb3OWRrVKFFtITzc3WlTIzFgDdx0rU5FPbnIqq6/h8AGDUiYUq Kg== X-Google-Smtp-Source: AGHT+IFf9Yb/lV1fMPHGdH6ntBNzqtAAdZrv1z6KXUln4z+2PgGQ1VQ45kPdIH3rvofp3kGQ/N/b7g== X-Received: by 2002:a17:902:e552:b0:215:b5c6:9ee8 with SMTP id d9443c01a7336-21a83f33a44mr397009725ad.7.1737002954438; Wed, 15 Jan 2025 20:49:14 -0800 (PST) Received: from localhost.localdomain ([157.82.204.145]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21ada1sm90516235ad.138.2025.01.15.20.49.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 20:49:14 -0800 (PST) From: Joe Hattori To: mchehab+huawei@kernel.org, sboyd@kernel.org Cc: linux-kernel@vger.kernel.org, konradybcio@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, marijn.suijten@somainline.org, bjorn.andersson@oss.qualcomm.com, abel.vesa@linaro.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Joe Hattori Subject: [PATCH] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe() Date: Thu, 16 Jan 2025 13:49:07 +0900 Message-Id: <20250116044907.2947218-1-joe@pf.is.s.u-tokyo.ac.jp> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" spmi_controller_probe() assigns a parent device and an OF node to an SPMI controller. However, the operations are not needed as they are already assigned in spmi_controller_alloc(). Thus, remove the duplicated assignments. An unnecessary OF node reference acquisition is also dropped by this patch. Signed-off-by: Joe Hattori Suggested-by: Stephen Boyd --- drivers/spmi/hisi-spmi-controller.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-c= ontroller.c index 3cafdf22c909..122140b97579 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_device= *pdev) =20 spin_lock_init(&spmi_controller->lock); =20 - ctrl->dev.parent =3D pdev->dev.parent; - ctrl->dev.of_node =3D of_node_get(pdev->dev.of_node); - /* Callbacks */ ctrl->read_cmd =3D spmi_read_cmd; ctrl->write_cmd =3D spmi_write_cmd; --=20 2.34.1