From nobody Wed Feb 5 14:13:42 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 368A826AEC for ; Thu, 16 Jan 2025 02:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736995829; cv=none; b=Xj5W/pC5eE1z4Vl08fioXYN2XgjY6foUVCLsEPmKwu4WiOcFUtyUz7dfVqFkDg9mk4waz8+GAz4Gcxh7/NzP7HLwjgsNoGdPx2o1t79qrratzlXg5zDtdkN+2nBHGhcQnoItwtt7lStnaRRscom6b+o9JmJJWRWK/DpfGRGa47I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736995829; c=relaxed/simple; bh=CtGZ7cUfbUhRUJaOg+nN5G1/M6kF0KX7TlXDtq77FlM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cW2dsi4V7Thps9GSiG+vyvKUgGyezSgmOC9ysg8+OquB8ipMKTDbi+lGU2x2yzxwmBQgnW/v0B7ShUAfmVbd4iXX5WO/4wViA36UkGYxCs+d7Fc/skXGC8dpv4tlblNLMhwatDctZhke3Tr80NW6kGfwJ4es/f8tTE+09XzNDCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 9a1b603ed3b411efa216b1d71e6e1362-20250116 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_EXISTED, SN_EXISTED SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF GTI_FG_BS, GTI_RG_INFO, GTI_C_BU, AMN_T1, AMN_GOOD AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:786c00f3-2c70-44b2-b5ea-bc536367cd3e,IP:10, URL:0,TC:0,Content:0,EDM:-25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC TION:release,TS:-30 X-CID-INFO: VERSION:1.1.45,REQID:786c00f3-2c70-44b2-b5ea-bc536367cd3e,IP:10,UR L:0,TC:0,Content:0,EDM:-25,RT:0,SF:-15,FILE:0,BULK:0,RULE:EDM_GE969F26,ACT ION:release,TS:-30 X-CID-META: VersionHash:6493067,CLOUDID:ba0b9d03d97d1eb138b6b75429b31a7b,BulkI D:250116105012IRW59DJB,BulkQuantity:0,Recheck:0,SF:17|19|24|38|44|66|78|10 2,TC:nil,Content:0|50,EDM:1,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BE C:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 9a1b603ed3b411efa216b1d71e6e1362-20250116 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.160.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1734857039; Thu, 16 Jan 2025 10:50:10 +0800 From: Liu Ye To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com Cc: jannh@google.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH] mm/vma: Add VM_WARN_ON for commit_merge Date: Thu, 16 Jan 2025 10:50:05 +0800 Message-Id: <20250116025005.55846-1-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add VM_WARN_ON to prevent 'adjust' from accessing NULL pointers when 'adjust' is NULL and 'expanded' is false or 'adj_start' is not zero. Signed-off-by: Liu Ye --- mm/vma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/vma.c b/mm/vma.c index 31c9c6f51c9f..36b5ac675504 100644 --- a/mm/vma.c +++ b/mm/vma.c @@ -641,6 +641,7 @@ static int commit_merge(struct vma_merge_struct *vmg, =20 init_multi_vma_prep(&vp, vmg->vma, adjust, remove, remove2); =20 + VM_WARN_ON(!adjust && (!expanded || adj_start)); VM_WARN_ON(vp.anon_vma && adjust && adjust->anon_vma && vp.anon_vma !=3D adjust->anon_vma); =20 --=20 2.25.1