From nobody Sun Dec 14 21:56:14 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2093.outbound.protection.outlook.com [40.107.93.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B0CB1EEA5F for ; Wed, 15 Jan 2025 11:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736938916; cv=fail; b=NaHkT4QzGyRx4Ooz7UamA792pUG8atGrv2eVxFTaPQm0Dad/XQuETlbzbgV+xjcutJ6qlTaZd6T3MMwSUD1pV+kC7GoV8QJSai/7iSgNWkLijg4jeGdAU+e6Y8W+horybfJxXRqN8ggZEUYESQvYZkfwfvoV3X9/PagruapCsz0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736938916; c=relaxed/simple; bh=VA/329Kg5OBqDCT/he+u+hCnKvh81mUxvSaVLQaKnXg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=MHs3tHE0cValCpCADjt4th94bvVzoCkSoui6DFjv0nRsppwVGmt5sw/IJoxgaUYaeAdyu34Gp8LusWWfcUn2ZwP4H/FCUTcQIHkT9y2j/49J3YBTAvXayuv9r6GbaXbuQ7oh2ujdCMlVT+sZdlEr6zblyxDtBHHeFX/yb7LHVaQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com; spf=pass smtp.mailfrom=inmusicbrands.com; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b=mTWLkIU1; arc=fail smtp.client-ip=40.107.93.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b="mTWLkIU1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UWaMWI+GyTGOgcv31TsdX5uDnZNS85uOu7EwY9nPxOrwNKVGhK4ExNvIeYGf5p0M9+USinQEJWoaPC8SlvBr3MDGn4CbeaqUetAxjXx9h6taPcfJ/itzCdlO1qW16z80f+BssP3GSl3z5jEyTjYrCyPJjZdQwl2Ucd4mXT2HtsNojiUclNzUd2Fn1vNJqDA3Ug0LeSfawYJ1iaQMOY289DCe59ryIBHnby4uM5ByxnE7MWaedXL1IVlvqwTxkHVQQBfE8JM9Uc2/Lf514ezhE5KS9SGnkJsnOII0Cj6dZQFl1hwE8Wwkkj2L5nw7Ty1ECvm2HQNv/lQzIU9kNHvrDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t4dF1/vajZHlStSiQTr9hy92T3CSMv5aH+8yJyR6smc=; b=U8KaiZyy1tND5PbnZM6qeeDBKxuwKtz1UO4ocBOB7PWYnDg8HsJtpSQFzJgtOq46JDUHqnOO6G8dTxJ3FKd9Ak+g+EcIFqwJ7a+f2p3PDdJPXLVnG/PGbdZtFS6JKJ7Q8aQSutw4c/hefjrztocwJ9o2mydN3b+Js6O4TgBUkIGCrsO1yF4BU47HjuoDJg+tBL6qz3tKDrG3EG/Av+Ilj8GELstW09D2UhIo3Sr9YH9u2cySlUlFwpN6Oot7cORRSpNIGUbzn6ENzyGmRFuoIyu3yILzkvS9b8yy4bnHMDefnoMpmdxpC8Ott+PgNn7bUGDZliT/hkUFNOg/sPjeAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=inmusicbrands.com; dmarc=pass action=none header.from=inmusicbrands.com; dkim=pass header.d=inmusicbrands.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inmusicbrands.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4dF1/vajZHlStSiQTr9hy92T3CSMv5aH+8yJyR6smc=; b=mTWLkIU1EsPoccBzAgy8oQoy+kbl+NAyn8wCOiHPyW5eqwhHTWdHYSpBboJoYq0aBDPgic2B0QynYfJ7LgDbBruMq3qaMpgTam6pLVIoYhYwCKsT0843usnbUen5AkjWj+//gxzHLu7XeO/E7+uGo7e54mqkwMPrIERh4JNlxFo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=inmusicbrands.com; Received: from MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) by CH0PR08MB6842.namprd08.prod.outlook.com (2603:10b6:610:c8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Wed, 15 Jan 2025 11:01:53 +0000 Received: from MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401]) by MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401%3]) with mapi id 15.20.8335.015; Wed, 15 Jan 2025 11:01:53 +0000 From: John Keeping To: Javier Martinez Canillas Cc: John Keeping , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] drm/ssd130x: fix ssd132x encoding Date: Wed, 15 Jan 2025 11:01:37 +0000 Message-ID: <20250115110139.1672488-2-jkeeping@inmusicbrands.com> X-Mailer: git-send-email 2.48.0 In-Reply-To: <20250115110139.1672488-1-jkeeping@inmusicbrands.com> References: <20250115110139.1672488-1-jkeeping@inmusicbrands.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0215.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::22) To MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR08MB8282:EE_|CH0PR08MB6842:EE_ X-MS-Office365-Filtering-Correlation-Id: 043542f2-866e-40c2-03de-08dd355404a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|1800799024|38350700014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JKpjA+p5U+Z13092pwJOkLaB11RjO8KyymcTVjWLOaPMM6jAx9xO4tlLdXly?= =?us-ascii?Q?mtClz6J1w1xcU0u1Q375oWKXtUCRbSVBB8hn7ApnukFxn7g1NJl7ZKnGwzL5?= =?us-ascii?Q?WICWdZC5fpZAJfT0oYYFE/cr1Jvvnf+HUyMkcVvdVfKgMid8oNIxomwHIWse?= =?us-ascii?Q?st2Wrxg9lnpBw3lAKdoJ0EfRSqDW1ofRNXheJ+0x9FM+mbdkczGwwMtWqejp?= =?us-ascii?Q?FUgwJihcdWlIqh8YpW/O44uUCQSeNfB3FNP1KafeSbpJuD5bJdY7GSpQ3W8g?= =?us-ascii?Q?xIbPrxD3IamGR+JkjKGiOKRQLmPpDOQ990Whn8txmtC0UV5w9hknAP4fq0J3?= =?us-ascii?Q?UktjQ9OnQC0y0wzTGAFMQZVE7qEfoXlmtYd63ZaXf7k1ujIAgGJrGX8b7ZX3?= =?us-ascii?Q?kbzOnI3SZuZyzqmtli1VOYU1IWXw/oZ+Mhny0M9A5CUkXxiUIjmPx2z+nhhf?= =?us-ascii?Q?3NkOn9tzsthVG6uq9QffsuDkMs1cQCUBUlmwwsBqfl5PxnlyEH7lhwS3Z787?= =?us-ascii?Q?QP4dxh8Ae+SSo7g+Nq8KXDvhpzSZNObtTX4n+u0VmlOUBe5vX6Y7P9dUzTi5?= =?us-ascii?Q?3t1qlXt3JuqrRE3Tg0dIMwWpyzhMQgGCeHIPt2BAU2jU95O9bsFFIdtRLIfb?= =?us-ascii?Q?Ei55p4rBeGDMGWuSiCyNlvRGXtRXrg5kDryrdCgEdxBGJPGZE2FgJ6NfR4dU?= =?us-ascii?Q?g7+7BDz3TjooYo92olwQHlgCSAQ+HycBfgoegXGCs1RjXsmXFAD0Wc1ywrqV?= =?us-ascii?Q?ubyMktHuN+1nYGGES3g99nZonZLTAN8CIAD/0rrsCHetsA86hv127ArKl7xg?= =?us-ascii?Q?xdxvhg9muEn+eXUAfEpvfLu1mQ5sSXdhGNOWgKbnZS4k4dDIJQMDt2ptQNPn?= =?us-ascii?Q?7Shrlac4/5n7WMsjMU9aKb0wq2tdHoCmqcciVDZ5sNsQ1rPVnxKQ35mP5LFQ?= =?us-ascii?Q?UBY6xOnoT6MgtUYGu5/lbQ//kKDFW6OedfMyYR6LCa3M8pLcnMegk3/SKNqG?= =?us-ascii?Q?zLoyFA5ng5l40dEZFUFC8Y+Akli6Nr9Xdv1gPIvggFgeQ2PIDysuNKxF8nh0?= =?us-ascii?Q?IiYqEc0c3hv74XTq9C8sRueXSV9qeNC8JnGVungr9ZYDsHp+jfXrB6MrjIvA?= =?us-ascii?Q?SoTRAQ95kHvyGoMQDmTfKN4VLH+QDU6YP0dPfdfBhq2i9/RkmKLdLFS33bxJ?= =?us-ascii?Q?punICmIjZgSJV7ouQjUJXbhmyKNY65W/aitjLrhrdmkw2XJFb2YrlnMb138f?= =?us-ascii?Q?wrrR8STO/Faw0OGQSCnczG8IFPOUzsVIpRpWm/1/vLpFSDloEFhLVWbD0NHj?= =?us-ascii?Q?pmfetHQ+cR07RvphtvPTkPUQaytfDEvrGxSqZqPnU2aJGKHWS/ZlG2Bq6Shs?= =?us-ascii?Q?QwspSjByXalAWRVCRM8cdJfsW3S0SLMV7sHcefVMFIUKIGqjMbEKh8rq2k9d?= =?us-ascii?Q?I/R5HE7+DIZZph6CoYNK7MkHynYxUqP7?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR08MB8282.namprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QRlSJ8JJuSSufrEJHJ9anfDJrliMxkA52kgs6nrl66XII8HkG66+tPcuX9cM?= =?us-ascii?Q?Kl//gc1n/1DM4/kriuhax4ylq17dADLe9Z/7Pl05NikmOCsec/lQTbRXD5Go?= =?us-ascii?Q?pMggLh0zYqbvXtIvV0f3lB3uaWL/jWZ2N4Yp8N2JflkqLuKRUxc1wxKAMBEd?= =?us-ascii?Q?tom5Q94dsXGa12qyeCvYNavD7AXuEvdp/Iu0Oi+k1sleRo52Y7Fi32f40tju?= =?us-ascii?Q?HbW9/UqCsRzgjrO4SxkPyGc+EKOrDqubHpQ5ZBXvxX9N67EkxPTQinwHldkZ?= =?us-ascii?Q?CcqescIh0C6HF0uOiqEy+wow5U64mSCSooTHBrHc5xXhlpkBcoFOtupKMPSH?= =?us-ascii?Q?8Lyfh7HPSNu4YNN2xc1Ih1iMGAS7zXD6oOno/2u8IfZeR7F8A+Y1qqDbJ7Qk?= =?us-ascii?Q?ceoDq7qUNZ28DqufcHfG1yC7CSBzhMC7hC1mEU2q+WTt+eT7N139847g1t78?= =?us-ascii?Q?9ly7Z8teARrMx069O+RXXpqcP0yFuAjZ7ZdCSDBk43zzNXrJwCfB7Mj7aLAJ?= =?us-ascii?Q?kqownN3ObsB5xJp7TrGviS1SeiZ0VMHIY5z8VKG3lREvB59wzJzLu7vKXdy9?= =?us-ascii?Q?MQRNWf2HELcz3yr7Pq1Mn7+2YxqnPDG8uscUZ3nMvcq0p9KA5DCK4HeA7Ul+?= =?us-ascii?Q?2ovgCw8prn+MR1rUnb6XRLapf2KedaPR9xRqgE+0IT2XgtnEbgjC75KS9ggS?= =?us-ascii?Q?yqjPgwlnd2O/7mvj2XP0zyjgZZB+Ox/IpXWrBTo0kJB3QeU8UKh4cb4fdxPs?= =?us-ascii?Q?h2FDEgtDLdTa0VQJBl4HKBi0tpK4ltWDcUltAQgb51HQkmIKdQ56m00qY7T3?= =?us-ascii?Q?pcpL3BK4ppF599QzpZF4J8g4cCLJcwU4jzjA3j9xW+Iy6UBoScnVY185U25g?= =?us-ascii?Q?coUYtGUBNNM5xr1GqGtAmkDsyUGOVo+FpD2CrVs4Vb94EkBjAnvSSND6oyUR?= =?us-ascii?Q?s9L1KmzmbSwnAkCSFsyy6CwBDWh6wWpT121PvEyTejkGYObd6C+Tmcl0125e?= =?us-ascii?Q?jsvNAjgQPk0H5l/qf0Usg/BMvOSqNBxigXgWFxY84ppi5Vq5uw8wbsOAWyaQ?= =?us-ascii?Q?kuJLMhvk3kPAQxIsMTun/BDhbUGLDOx2ziOEcJQYCDrNyn7LlIK2Le17akEC?= =?us-ascii?Q?7E0bUJqmMroXkcoAdzJTNlL1KPXSODG4ZC/l0LIJMTK4NJf8P9lAFxWHDvBK?= =?us-ascii?Q?4UV5R5RqixyF9PxSftzYOkRy/8cDTVf4KP41Lep9cutenccXGPZcoSYlE/pR?= =?us-ascii?Q?msiD/VvzTGavBeRdkGJ+UDeNauDl52roClsn+Y3bWUh7ndmofYqsCTbq/I9Z?= =?us-ascii?Q?IznM72ZOB4lGon75wKBkCQt53AJ+G1fYXkhvJvc4rqC65wVnGoD30XrgcI+g?= =?us-ascii?Q?DzpJAFmbmGJKSPuTAuzGquoelfRqAziCYAyrizfKP7/57ToxGL8CDwmT7fG8?= =?us-ascii?Q?yLGTaxuU3HPQgGGNuHU7qFx1Owrxt2IbtJsrrT41XCIodNjlg0a8snXYL2G+?= =?us-ascii?Q?iF/muyyIVvwwZRRKy+WN9OAG6bRYYNfBqZl01ephbs+Db1yIaFgjBjlFIYvm?= =?us-ascii?Q?DmyVPmOkibrXs9FXIz4AscRdVfr2q7+0xus0C3mcdCaOmQl4HyziPCYUbc3x?= =?us-ascii?Q?Qw=3D=3D?= X-OriginatorOrg: inmusicbrands.com X-MS-Exchange-CrossTenant-Network-Message-Id: 043542f2-866e-40c2-03de-08dd355404a0 X-MS-Exchange-CrossTenant-AuthSource: MW4PR08MB8282.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 11:01:53.0520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 24507e43-fb7c-4b60-ab03-f78fafaf0a65 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rtbwnNnqWMb5PNDl07rW13+rVhAmeMkVZLisn5SgVQusUpZZbYTTfkdXad0j9+pOVQELvnCwiXncIpShKfg/R1NzK1Z3TuETasYuf88QFH8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR08MB6842 Content-Type: text/plain; charset="utf-8" The ssd132x buffer is encoded one pixel per nibble, with two pixels in each byte. When encoding an 8-bit greyscale input, take the top 4-bits as the value and ensure the two pixels are distinct and do not overwrite each other. Fixes: fdd591e00a9c ("drm/ssd130x: Add support for the SSD132x OLED control= ler family") Signed-off-by: John Keeping Reviewed-by: Javier Martinez Canillas --- Changes since v1: - Correct a typo in the commit message - Add Fixes and Reviewed-by tags (thanks Javier!) drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index b777690fd6607..4bb663f984ce3 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -880,7 +880,7 @@ static int ssd132x_update_rect(struct ssd130x_device *s= sd130x, u8 n1 =3D buf[i * width + j]; u8 n2 =3D buf[i * width + j + 1]; =20 - data_array[array_idx++] =3D (n2 << 4) | n1; + data_array[array_idx++] =3D (n2 & 0xf0) | (n1 >> 4); } } =20 --=20 2.48.0 From nobody Sun Dec 14 21:56:14 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2093.outbound.protection.outlook.com [40.107.93.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B80BE1E98E7 for ; Wed, 15 Jan 2025 11:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736938918; cv=fail; b=cy8+hw18k+UK88lN+g7YfYDhTyGzTc7UlB09o6Ky5qoeBgAz8UcZy0QZVFmEYRvOC5mMxRlOBytdIN+69TDUPpQstOW1wDnNRLL+fu21BdDU5Lg1WCn4ULNnT0DGtn66ku9VjMGCoUac1WQNEorAKuf3i0/wbwqB7RGizhVWPNY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736938918; c=relaxed/simple; bh=Db6d9UQW91qieIRs/BDyswTApqKjnMr9PJHAuS36YEc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=itSK8KaSV8iq4eweS4xBWZUR1kZLWTzPa2G7bXIYIG9X8hIOl3z6q6pJFScvWIJWkI8YIxL2bKQnNobbHYiL2ReZhe7VakyHcd87y5D/ohZrTQe9G3WJZE+HTb9XOzQPJUzvam+20FzDy/GCGnzuGygJ3fZNZzQdC36QtvOJZRc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com; spf=pass smtp.mailfrom=inmusicbrands.com; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b=fbPLGm/R; arc=fail smtp.client-ip=40.107.93.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b="fbPLGm/R" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JGdtDlKKzZLJhE3VQLZnBd/AQGayhKXsgGK38iwee1+ywGZ+fgQ+FNao6N8dkr9Y4Kd+dMqf7NgmK7vikNOta8IydvYOZpETEzDWnip79LjxaCp2TpfahjGYv7L7Y9AA+fmbedndr/6AFl6xSY8+Rh+7a8hMNfIjpnD1zxPwjSk+iTIN6zccv4nYqhiTrRNk3SPgTyE7r7wvUth9VpB005yveF6R8q/fFBK4C3GC2QcgMVmvQdwUHVIeAb/AePouFNx0Ze///JzbgwDanZEF1G2RaAatAkr8HAb9yyQAMHiQsVGQDR6OfMmHXmhiVBIn97o8c7SL1d/aZwxMm3H64g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=exkryPA9kC4YcCxJyZEE8U8u9uu36BXbsDs6dLKoCJI=; b=uZP2gnDMnAq7TgvdmSj+Z+HXy/tJCWPCt7O2oSsqRhT1ySgVBg39/TitdwLWcZGXO4GMKTa3qJIEIAd74HdHQojdin0sWHaNRzP/cAFXcMg7ZeYRtQKaumyVyB3xIMhOcrjORecorRogFq2EDwUTMjgW/OZdrzntK6GsG1+A2/IP6wjyKB/Mp9yqyZDV1Yw03KKH1atrO1z3WuhsrYd83EIeTI67BFOBn+cCRk6DobVwyFIGQePB6k3BhV0utBCpXK41N3aIQoY6vN3g/6Hhtrq+/84ngknPJ8P8yEqlMAV7LeesggBwwSmiXFujpDvt+jO4mzsRT+9HUnA+0YrpTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=inmusicbrands.com; dmarc=pass action=none header.from=inmusicbrands.com; dkim=pass header.d=inmusicbrands.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inmusicbrands.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=exkryPA9kC4YcCxJyZEE8U8u9uu36BXbsDs6dLKoCJI=; b=fbPLGm/RLbhv/S1cluhO5GCcvhLvLw2W2k4z9R6w5eM1yCRUEiKbTWD3Ms0hfFWqjK2i1fu4ITtcWB4gtuwR8HsjDXB6XVDofBxXJnLjHUlxu5GLccRL0TbGcpdtSgte+F+KeDoWbiS4+162nWFS1zIEyW9OKUmD9YoMXwCR83U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=inmusicbrands.com; Received: from MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) by CH0PR08MB6842.namprd08.prod.outlook.com (2603:10b6:610:c8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Wed, 15 Jan 2025 11:01:55 +0000 Received: from MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401]) by MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401%3]) with mapi id 15.20.8335.015; Wed, 15 Jan 2025 11:01:55 +0000 From: John Keeping To: Javier Martinez Canillas Cc: John Keeping , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] drm/ssd130x: ensure ssd132x pitch is correct Date: Wed, 15 Jan 2025 11:01:38 +0000 Message-ID: <20250115110139.1672488-3-jkeeping@inmusicbrands.com> X-Mailer: git-send-email 2.48.0 In-Reply-To: <20250115110139.1672488-1-jkeeping@inmusicbrands.com> References: <20250115110139.1672488-1-jkeeping@inmusicbrands.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0215.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::22) To MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR08MB8282:EE_|CH0PR08MB6842:EE_ X-MS-Office365-Filtering-Correlation-Id: b6fa193c-0f35-405e-c77b-08dd355405f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|1800799024|38350700014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ni0XLmCm6kidoXINeaE0TcffQyA3JFAIN43yOX/kPjmLjSoGVTjyZpTkZJmn?= =?us-ascii?Q?ux1wLxIAieRVBc0d63zP1hA+YKylz/ZKai39rZu0Pjq+uKHAaoraq5Ah+JTo?= =?us-ascii?Q?XkkJcgKSMflNbgkkSlnCC8LPL5zfJXA9noJpz5NC9rcELgHzyThxPc0wHP/q?= =?us-ascii?Q?pSQnpWyAraPnt2+j3IMi2OHSzDxaNKEdUYqG83DGacFlf6nI0/1eIH4aq3sB?= =?us-ascii?Q?VW7FRsCHPuommdGHyxbILtzGft/Bevw0xohl1GNe3k60sU2qcSuO46/rYWm9?= =?us-ascii?Q?hKY88BBlRGa51hWwNM3cIejhfF3meqqsq5NHtdMKaUyIvwopjMwpJcfYbUh+?= =?us-ascii?Q?Sj+uKxZS6f0wUzlJKAXoN3Kowuum8FMQEcAqJJ+stoD5mm9ayKP5CxnaUWnK?= =?us-ascii?Q?aJVjoM4dpVQPFI5AX49p7apkG9WvWhtsDrE1vIarOZPRjKY1B1Ycmr+s90v0?= =?us-ascii?Q?Ao7Mj+e31fpACmJkCLvzYpd6ifufn58BaRt2QyEb6i5cXLoHvRFJWbefeIX/?= =?us-ascii?Q?B9CcKPIm8UYRYf7GBL5NrxoQNHhd5zhVuqdyZwkM9Yj/ig1/9k6ilZTVnP96?= =?us-ascii?Q?KMCKQepi+rkCg+DkQOjAcKGy/X5bWuUq0HajxIasBQa8WPcgBiLtR7SMD/xn?= =?us-ascii?Q?oY4jUrCmsPMzdd2t+orFOn4dN7ALpvcyNPPpV9+7xF1ZVd5cwwLYvfQZaVHB?= =?us-ascii?Q?gi8zkyhMpZmqXN9m0F3DCAPIMVby9YxSmHWngSNHiUulT3f7oOEaRccCEvuC?= =?us-ascii?Q?SZoKctwviaXC3Yy6NmTO/nFskqM9dTxe3xyw4TL7UtVMEy3gaYkOQNIlZi9U?= =?us-ascii?Q?jobv/YTS5SwviPcSwWvG8f7t3WcwIdwSbMXRvXGki13TlJzw+QAZqFKLC/V4?= =?us-ascii?Q?gbV2of6VC+HbjIToxjVCA8+tVYKbPZiUevN0BxqDvUWllIm9/oyAMhTrh748?= =?us-ascii?Q?+zYRTeTvGarYcV2Iroshk6ZGNb7unU7mlIIm39SD54HK8kwHDowHHsDomu6v?= =?us-ascii?Q?IgR1+XzQvKKzkkrfSgmH6/p9urgaoyT0Z6aMp1zlGvND+jfqO66uoAsXjjv3?= =?us-ascii?Q?ccIwdu6EkohtzaL+XsQaGUb5lY8GIuxsJlBbfZCircuOTjtaTH6HIKxgdl4Y?= =?us-ascii?Q?XFYOjyeMa1+hb7nXtnXll0pAcQ3AU+P2kPNjdik61FVK8tdXhBGkbAp+6xQ6?= =?us-ascii?Q?MCqoD9HCH7a+3+WqPYqI6eZnRCA+xYMxAahcrFOmoeFNv/5GGRgpmQtgF7dU?= =?us-ascii?Q?TT7wQgyqDkXKhS/Ck7poWDqUAJT61h9HbUklhSJ9Q0ffnnbMzCtKsJOfgeR5?= =?us-ascii?Q?QuSj2mRxXhS7BsyHQTPruPpfeRnTxQivop2LYvnZt7bkA/ralL9WrYKPPNGq?= =?us-ascii?Q?wgvpV4yjU0JblHo/CEkDkPj8OmEHSvZU6VJW/q2dg2FUIiH/LmE3BMG6SxNT?= =?us-ascii?Q?v5nbbnBsGipAMiA23wpGq+ulR/8d0daj?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR08MB8282.namprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vkKOBRpuZfbnion6+MX2jM9o0AXZKYr1hKPCXSiEqtv7ZHG491hPNDYNWu+9?= =?us-ascii?Q?GqxeT3iqoEYbk3yZLcDkEZYzBXK5fvWrh5dIZV7wmVJ51VD7II4N9zP6sOYf?= =?us-ascii?Q?uT0EXf4yUgKilt0+NqQkZz557+K5SargqMupWY8z62vX9ztRlcpRNRRi56Eo?= =?us-ascii?Q?ghMu3DJbSmaz4whEg+hR1IC+i1oORKrGazqVfbL/096TtUPD2Z3h0da+OmXj?= =?us-ascii?Q?BpsS7KeFw/Ve4uCbrepYFJf0feBSFY8ttNiHMOWuPGTu5jplJfDRIX8w1eQL?= =?us-ascii?Q?DDyD3/Xcwd8dwiuizLprFLtgL1RAHEP1gTSKrujAJfEFhyQh5FC1lX8Rns8i?= =?us-ascii?Q?WaOt8CM645hwTyjU+/NQH861z2lP0fI4Jl6lai0H8iNfCp+qhvz0Mce1Mf5Z?= =?us-ascii?Q?3VSkhoDMw9jvSqJeLuZAAPu9Ld8tMA/SCP4VOfs/id1ndVhFqcp0X5NRp75y?= =?us-ascii?Q?oRNQN8j3nBOLQkBt0fQQ7PwLu+83/L1/kLfJW9DiwbfjLLVwcQmReuCF1qXp?= =?us-ascii?Q?91QdaTwdDyJZEQDH5fJJc8Fw2+AYHurKTuGIK0y0B3p84aGNxa5PCRxAkVEX?= =?us-ascii?Q?tTgh62N2FDwON+GgZ927QirY40I2fm3GyrbS5pRWG5EK6kJDxbT54BHLmRUv?= =?us-ascii?Q?S1TCHssDXeLRv/Bz/uT/FrOa9XEpCJy02VA5wYDDTl/Qrp95ir/Eq5SsSsuu?= =?us-ascii?Q?8BqNJK+/njyoTTU8geHFK7fRc31CcxxPLVDg3jYoKeBoORMf7mj3wdpUtFkJ?= =?us-ascii?Q?FY0dA/YBuK7R1bg668wZhz3OJ/3EDjd8iW2/5TUkHO5MTmXSSaIZd/lbNC4H?= =?us-ascii?Q?ajFj7AWrImtv1pfra+ksWzTVMAqH+apcREDViZ0neu1M32FIqqsq/vm/5bwu?= =?us-ascii?Q?OWNGyO7jC/EjyPEllurdWa/YKoM/7iYCw5nIEe/WaOz0SoAstXX5TJtSFyUs?= =?us-ascii?Q?mEdj5d793Vg9qiX2FDUgRubsao7rSMsSx41EEYrafF6ChG97+LMJSuO/NhuJ?= =?us-ascii?Q?SCwZ32lMiu2Dy9XUOzF4FbjFumudETHgg4skf5Q7XE3mlkDKuFFe0Q7C8bNA?= =?us-ascii?Q?r7tz8B/gcKU79MgZAmsGn0OdyDY3+qtrDtQNe7J7wRdsDQQu8SLMyXEmFqJJ?= =?us-ascii?Q?mR6GL+beIOFIBfxfwU26rb3rLdmpEdPY/3GIyOnkUH/rEZTcudOMH4q7hXCP?= =?us-ascii?Q?m+6pbhAfeUxuGE9ZdxfjbiArX4ln6CyCdvMbJDks6NLG4BnavqH5bh+u5mD5?= =?us-ascii?Q?pY8qXA8Y9cM2H62KdIJ9nZ/gGp6XBKvj+4DXX6TnxP6zeDJCX6JvtlW/CRgD?= =?us-ascii?Q?m9ka/4ys2Rmqqq885gCDFtOtXE+jq5BfHlT1E7x8P0AReCQsZGMToag4Bd14?= =?us-ascii?Q?Fhq21FUJIFxmxjKBETIqzhsDygnyeqnj2dr/BzPofB78jhtYeoHd2eEfTQQX?= =?us-ascii?Q?IYV8KydgnH+8CvD08HoEpqwFVgdGDTz+vdRuKR67HcoP3/ooPR0DRYUn4O1f?= =?us-ascii?Q?OlvnABUKvfCedL4k3+CPScy2xKGirEfZXmaidhreR3YdA5WDGSH9HQUmc+BT?= =?us-ascii?Q?lfshlQR9v6QTvS3xGNVetnWiiGVwRmWDMMamg75rKhNFO09oODAJl6vnOnkV?= =?us-ascii?Q?ew=3D=3D?= X-OriginatorOrg: inmusicbrands.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6fa193c-0f35-405e-c77b-08dd355405f1 X-MS-Exchange-CrossTenant-AuthSource: MW4PR08MB8282.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 11:01:55.0428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 24507e43-fb7c-4b60-ab03-f78fafaf0a65 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sdZBMxAXYR6dck3dM6cF89G4T6SzFGt9VoIrYilqVIAJGzb0XGBqbg3vFVb8kqJFU8/Wpxn5pSljgt92Bz8IZyZAPFX/e9rFxJQZLXVVvG4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR08MB6842 Content-Type: text/plain; charset="utf-8" The bounding rectangle is adjusted to ensure it aligns to SSD132X_SEGMENT_WIDTH, which may adjust the pitch. Calculate the pitch after aligning the left and right edge. Fixes: fdd591e00a9c ("drm/ssd130x: Add support for the SSD132x OLED control= ler family") Signed-off-by: John Keeping Reviewed-by: Javier Martinez Canillas --- Changes since v1: - Correct typos in the commit message - Add Fixes and Reviewed-by tags (thanks Javier!) drivers/gpu/drm/solomon/ssd130x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 4bb663f984ce3..dd2006d51c7a2 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1037,7 +1037,7 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffe= r *fb, struct drm_format_conv_state *fmtcnv_state) { struct ssd130x_device *ssd130x =3D drm_to_ssd130x(fb->dev); - unsigned int dst_pitch =3D drm_rect_width(rect); + unsigned int dst_pitch; struct iosys_map dst; int ret =3D 0; =20 @@ -1046,6 +1046,8 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffe= r *fb, rect->x2 =3D min_t(unsigned int, round_up(rect->x2, SSD132X_SEGMENT_WIDTH= ), ssd130x->width); =20 + dst_pitch =3D drm_rect_width(rect); + ret =3D drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE); if (ret) return ret; --=20 2.48.0