From nobody Thu Dec 18 03:18:25 2025 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AC2D155725 for ; Wed, 15 Jan 2025 04:17:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736914638; cv=none; b=U0HuUXaTKPTRxO4o+M+w/x8YuASLnilurpeNgMi21pxOAQxaqGwljMlOuK+BVS34gfr2N7s6F0Roz7UPAkhdM2FtgbhJvySl/sm75ZpKg5bYNUZ4/eIMy6TrNk7sHe1tjG+uOxqc2wpr0xWNU4MtOAWkRNQ41qVZV47EyYhydJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736914638; c=relaxed/simple; bh=zq5sB8ou4azNt8y6B9SNTXAGr8y1DMajBgLUan03muQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ckIg3BSNEi4oL/jHr4o7TkEH4wlV75LuuFt8W9xvXKKcZJeXCtuL5EQQ0GCBGIbwlNnykzLRK0FSJ7Cg5DgD9QKmqRUiR1eDHJz15Y3RA2scyKd3G0xZp1Cv5oqku0o1cvm6Xj1vK2biYqH+Gp8Pg4buXB+wQSYRPSZv9Xd+mls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=EJGlp4W3; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="EJGlp4W3" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736914634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JdFpeBw9FNCn+nyVTPYmxKLD8Uqyow1gj92jnx8VEF4=; b=EJGlp4W3gaQX9s1GFyLxTHw+NoR5b/SvAPQOrUbSp6ywmEuclSZCUXhmMHPQBFsx1U+wYo WjJSPvtGfpXl6EwMoYv9W816AKhCJdTAr0ez2VG4lPj229SZ+bF6lE0P+6afdDeNxUdEoD mKO9siwGq2sIStKhKhUA5j2e4V8AVL8= From: Yuntao Wang To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yuntao Wang Subject: [PATCH] mm/page_alloc: Remove the incorrect and misleading comment Date: Wed, 15 Jan 2025 12:16:34 +0800 Message-ID: <20250115041634.63387-1-yuntao.wang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" The comment removed in this patch originally belonged to the build_zonelists_in_zone_order() function, which was introduced by commit f0c0b2b808f2 ("change zonelist order: zonelist order selection logic"). Later, commit c9bff3eebc09 ("mm, page_alloc: rip out ZONELIST_ORDER_ZONE") removed build_zonelists_in_zone_order() but left its comment behind. Subsequently, commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization") moved the node_order variable into build_zonelists(), making the comment originally belonged to build_zonelists_in_zone_order() appear as if it were part of build_zonelists(). Remove this misleading comment. Signed-off-by: Yuntao Wang --- mm/page_alloc.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index cae7b93864c2..ff23296e30dc 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5161,13 +5161,6 @@ static void build_thisnode_zonelists(pg_data_t *pgda= t) zonerefs->zone_idx =3D 0; } =20 -/* - * Build zonelists ordered by zone and nodes within zones. - * This results in conserving DMA zone[s] until all Normal memory is - * exhausted, but results in overflowing to remote node while memory - * may still exist in local DMA zone. - */ - static void build_zonelists(pg_data_t *pgdat) { static int node_order[MAX_NUMNODES]; --=20 2.47.0