From nobody Sun Feb 8 20:15:52 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C2071DE4D9 for ; Wed, 15 Jan 2025 21:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736975192; cv=none; b=QeqHo26t/cmSOTTDcvwT7XjTRb4LegcNNK7DVkTO+xqvbJtP9WcpzqkvCJN7FjXrkaDhvsI7q0f5LBZOxdeY9+T7YA+Z8CGL9/606rBHRfgjMjmqwtdqHpOD/Dq7rtmR5TttmOXBdE0e4Ri3ngWaJbHQfX+sXROZru8SoVozLNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736975192; c=relaxed/simple; bh=VbD59Rc/xrLvH8j0QsdsdtGobqdBYrbMJL7Oj4VqEQQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RJLXUGvawURL+YQZ0gjN/jyhOIKIY7l8qr78rEBAqrHw1aiz2veiw8EDBMm4ABGTHwZJ7mRBBW9bHDV3heBBNPgika2dmpOH+LIOT5XmtbkHbNa5nviJwc7Yi8E77M1oQJOsBsZqHf6Okk0dcu16I1UpuOqEYwuAKbThxnSvnuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EXrpd3Z5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EXrpd3Z5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 520ECC4CED1; Wed, 15 Jan 2025 21:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736975191; bh=VbD59Rc/xrLvH8j0QsdsdtGobqdBYrbMJL7Oj4VqEQQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EXrpd3Z5fFIp85nnyGaG57zFGSoPO4vagwMRYfcklq0yN8u/JFXUqYL8gVh6xLB0m rMXAwtCrfssRGoOgYiii/FM9ggEqv6LXUytu5sm5Fv495slBA7sEKKJg/h/k+3e8EF JzlvaEUfKn/yAyMo2+/JiVStEYPJ2q4DVu7hdUe3LMVxjE98vX7mOpwPPHbCGgyhG5 AEJrVd4xQD+iN71uJIvAwzHt5lsI6dBiHiWckbJaHzzqc4/rR3nemCrHr+3f8SBMmL ZG6YhcWDRyUnhULl3v0W0Yn70G+fUYpf7PmL0rzr1jdKFwZn7LlT5WOf9QARpuja/X woVczZp1GBUBg== From: Maxime Ripard Date: Wed, 15 Jan 2025 22:05:25 +0100 Subject: [PATCH 18/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_vblanks() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250115-bridge-connector-v1-18-9a2fecd886a6@kernel.org> References: <20250115-bridge-connector-v1-0-9a2fecd886a6@kernel.org> In-Reply-To: <20250115-bridge-connector-v1-0-9a2fecd886a6@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3197; i=mripard@kernel.org; h=from:subject:message-id; bh=VbD59Rc/xrLvH8j0QsdsdtGobqdBYrbMJL7Oj4VqEQQ=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDOkdyrIhlgvn7NmswNwhlsVa80d8Qi1v8b6cdZvlDV/aF VhM27C4YyoLgzAng6yYIssTmbDTy9sXVznYr/wBM4eVCWQIAxenAEzk3zvGhvmmmgIXmwTr6io7 Y9uW2+XNiz8y0/nH5cNzXdYeNv7nmDgv6ddivanZx6q2rY6/r5CpwNhwWCeY1WnlSmZPcYUrn6e 4PhRa80Vs+fkJgQumiDpYfVu58MGV/jtyb1Qn2KxYckfiXqoSAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D drm_atomic_helper_wait_for_vblanks() waits for vblank events on all the CRTCs affected by a commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_helper.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atom= ic_helper.c index d642bbc074bd364256409c91649f8d8aa10f5023..581fd0f14ba0aa2a9d0334cad49= 575de3fb5fb20 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1656,11 +1656,11 @@ int drm_atomic_helper_wait_for_fences(struct drm_de= vice *dev, EXPORT_SYMBOL(drm_atomic_helper_wait_for_fences); =20 /** * drm_atomic_helper_wait_for_vblanks - wait for vblank on CRTCs * @dev: DRM device - * @old_state: atomic state object with old state structures + * @state: atomic state object being committed * * Helper to, after atomic commit, wait for vblanks on all affected * CRTCs (ie. before cleaning up old framebuffers using * drm_atomic_helper_cleanup_planes()). It will only wait on CRTCs where t= he * framebuffers have actually changed to optimize for the legacy cursor and @@ -1670,44 +1670,44 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_fences); * drm_atomic_helper_setup_commit() should look at * drm_atomic_helper_wait_for_flip_done() as an alternative. */ void drm_atomic_helper_wait_for_vblanks(struct drm_device *dev, - struct drm_atomic_state *old_state) + struct drm_atomic_state *state) { struct drm_crtc *crtc; struct drm_crtc_state *old_crtc_state, *new_crtc_state; int i, ret; unsigned int crtc_mask =3D 0; =20 /* * Legacy cursor ioctls are completely unsynced, and userspace * relies on that (by doing tons of cursor updates). */ - if (old_state->legacy_cursor_update) + if (state->legacy_cursor_update) return; =20 - for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_s= tate, i) { + for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state= , i) { if (!new_crtc_state->active) continue; =20 ret =3D drm_crtc_vblank_get(crtc); if (ret !=3D 0) continue; =20 crtc_mask |=3D drm_crtc_mask(crtc); - old_state->crtcs[i].last_vblank_count =3D drm_crtc_vblank_count(crtc); + state->crtcs[i].last_vblank_count =3D drm_crtc_vblank_count(crtc); } =20 - for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) { + for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) { if (!(crtc_mask & drm_crtc_mask(crtc))) continue; =20 ret =3D wait_event_timeout(dev->vblank[i].queue, - old_state->crtcs[i].last_vblank_count !=3D - drm_crtc_vblank_count(crtc), - msecs_to_jiffies(100)); + state->crtcs[i].last_vblank_count !=3D + drm_crtc_vblank_count(crtc), + msecs_to_jiffies(100)); =20 WARN(!ret, "[CRTC:%d:%s] vblank wait timed out\n", crtc->base.id, crtc->name); =20 drm_crtc_vblank_put(crtc); --=20 2.47.1