From nobody Tue Dec 16 05:58:57 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AE9A20C00A for ; Tue, 14 Jan 2025 20:07:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736885254; cv=none; b=AN+udoQs/ptgUkEAGk4usHB1PXR9x32KRcsHatVAPZRlKB5iHlYMP9jEe2tWtT6Ks7QNWidSLsP14r3tFPEwu3n6yqbZwpA0pcWcoHep4VSXAAqk5zYoNYQLN3tRtJsGBHxjNetQnefItCF5N+e68TjqXa036dWi8EekvQoiVV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736885254; c=relaxed/simple; bh=7B6kyAiupF62kaPfm1JUZNDYqJWr8hGZNAtwxV5qv1g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iWWh27HubzrS19tIqIYhopzY7JblzXoOBjPVNyyhzZkLmpAEdprK+xuGWK2bLmFTtc1S8id3uAA2LV3H+3c5Cl5VHgBy4U3yce9NMsgu5T3Rwv4AdDwGEaJsDxGh7O+vQVeImv0CYErqEoD8tdO/52sZUbZavNyZXpfXi7dkSXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PxZMTOy4; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PxZMTOy4" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-38636875da4so515758f8f.2 for ; Tue, 14 Jan 2025 12:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736885249; x=1737490049; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fk9bg9Fvbyh2/MUDhXbi+FEpTJ36YRKNsAKXHLaeSm0=; b=PxZMTOy4b0iLdPfvJn9B+hi7Z0UjyEymsM7x2v01bB88ulatyLICitrCkO9a2Pc6d1 almIWDkfZLBO0KKfN79tKkjK9NexfimF6LujvP4UEtrYOb2h+A6sMiEfehy/KXUy6aHH D/CBST7KUnfiBFaFHqxIgwf4I0MI7QcGBUyhGTvnUC+E/HL//LPBWJLn1UPizBLwgwVa RWb2lijV4DgA6QAvXWV/mCtdtkL1/YTHr7WwCt0sEvAi81VKmpbkaTs4ztBgCYJvCchr aCTHoqnx9Pa0Hb8SFT9b/iJeDwO+DarNGCILBxs6Au54D2cw2BTcsyHww22h68yVQh5g mc8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736885249; x=1737490049; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fk9bg9Fvbyh2/MUDhXbi+FEpTJ36YRKNsAKXHLaeSm0=; b=sUDw5E5ysXa/F9fhofgpIHCrN1qdfx154uSFEzpaNOy6kWPtYGjFmdQyDctSmczlX3 f41yqKxA+6woRmQNCKT02S+/sjcECuKzErRlgOo2PUwc3Jp2WrKl7/dcwTrg0/0eL2Dl iZU7jrpyXO65bu88OP48SutU+rum5CAUURqxExNEsTfN4+NVX0kLZr77XRztErMPr73f 9AQ+hhCcX+8FJC1L+R0Ao971WR0UDoJHyGClTw00zEAtiyutOcBVi+9B6ubKqOIBwOei QCmctymg3RkT8zZ6E8tKw5SuSM2A2J0J8osrQ5uRXK9Yr8hazhHskmrrlAEvaFanxD21 qANQ== X-Forwarded-Encrypted: i=1; AJvYcCVnuXGlvnx8xrRRd46uyTE8osL2qgNAkCOAesLYpc9Q7TLh1qEJ987tlvKfGYWjeFeulkzGs33bUs3/CyA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz43sPwLecCMS2M7JbDJsxn6GahkGiyz+36iylhYtcBT2vbJkko GCsLmApw2q4v87hW2s4lbKFtDokvedtd0A61t+52P3BC0o3VBNxyho9YN6tZj2I= X-Gm-Gg: ASbGncsYjf+CzLTu2v8P6fRGLCSwAXrOvEMbnoqBOjkLe14myp6mjyWrlxqpCSPTZZj Yau8nNRhwHGhcaa5kJP3023z/m4NeOW4t7i2VnlP8ubuLkxubLbfPBps3zFXgK/b/dPivC+9OWf 4Fw3I7udM9o4koEghkvjpTzFcMpoCsaHpw+JhfSyo0CUJSKnSdeybbPC0lzN8oOrWost2Xv7V6M Q308oC5K8hr0Pzq2hN7AoUxpEv/6gCVT8eIbov3U9QcN3YLeA1d7ADzgLhNFOlGILVICiU= X-Google-Smtp-Source: AGHT+IG4QNSfKEGdbODnRfkgtkES/VQLAMYQWTj1XLLF8uY1GBB4vrLQlygciFe4X+jQEBLErZI9+w== X-Received: by 2002:a05:600c:35c2:b0:434:941c:9df2 with SMTP id 5b1f17b1804b1-436e272c89cmr94469765e9.8.1736885249454; Tue, 14 Jan 2025 12:07:29 -0800 (PST) Received: from krzk-bin.. ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e62333sm183268835e9.36.2025.01.14.12.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 12:07:28 -0800 (PST) From: Krzysztof Kozlowski To: Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] soundwire: Use str_enable_disable-like helpers Date: Tue, 14 Jan 2025 21:07:26 +0100 Message-ID: <20250114200726.969501-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace ternary (condition ? "enable" : "disable") syntax with helpers from string_choices.h because: 1. Simple function call with one argument is easier to read. Ternary operator has three arguments and with wrapping might lead to quite long code. 2. Is slightly shorter thus also easier to read. 3. It brings uniformity in the text - same string. 4. Allows deduping by the linker, which results in a smaller binary file. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bard Liao --- drivers/soundwire/bus.c | 5 +++-- drivers/soundwire/debugfs.c | 3 ++- drivers/soundwire/stream.c | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 9b295fc9acd5..25120aa3bd67 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "bus.h" #include "irq.h" #include "sysfs_local.h" @@ -277,7 +278,7 @@ static int sdw_transfer_unlocked(struct sdw_bus *bus, s= truct sdw_msg *msg) if (ret !=3D 0 && ret !=3D -ENODATA) dev_err(bus->dev, "trf on Slave %d failed:%d %s addr %x count %d\n", msg->dev_num, ret, - (msg->flags & SDW_MSG_FLAG_WRITE) ? "write" : "read", + str_write_read(msg->flags & SDW_MSG_FLAG_WRITE), msg->addr, msg->len); =20 return ret; @@ -1263,7 +1264,7 @@ int sdw_configure_dpn_intr(struct sdw_slave *slave, =20 if (slave->bus->params.s_data_mode !=3D SDW_PORT_DATA_MODE_NORMAL) { dev_dbg(&slave->dev, "TEST FAIL interrupt %s\n", - enable ? "on" : "off"); + str_on_off(enable)); mask |=3D SDW_DPN_INT_TEST_FAIL; } =20 diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c index c30f571934ee..5bf0d9552433 100644 --- a/drivers/soundwire/debugfs.c +++ b/drivers/soundwire/debugfs.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "bus.h" =20 static struct dentry *sdw_debugfs_root; @@ -153,7 +154,7 @@ static int set_command(void *data, u64 value) /* Userspace changed the hardware state behind the kernel's back */ add_taint(TAINT_USER, LOCKDEP_STILL_OK); =20 - dev_dbg(&slave->dev, "command: %s\n", value ? "read" : "write"); + dev_dbg(&slave->dev, "command: %s\n", str_read_write(value)); cmd =3D value; =20 return 0; diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index e9df503332bb..dd8de88d8b46 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include "bus.h" =20 @@ -358,7 +359,7 @@ static int sdw_enable_disable_master_ports(struct sdw_m= aster_runtime *m_rt, } else { dev_err(bus->dev, "dpn_port_enable_ch not supported, %s failed\n", - en ? "enable" : "disable"); + str_enable_disable(en)); return -EINVAL; } =20 --=20 2.43.0