From nobody Tue Dec 16 07:11:40 2025 Received: from mail-io1-f74.google.com (mail-io1-f74.google.com [209.85.166.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF101B85FA for ; Tue, 14 Jan 2025 19:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736881645; cv=none; b=qKKtHIwNP2jLO52zGIGmD/YsFK5F6Db90fLzWohpFbW0FKhxzycGAQuwCnpf4gIV3eBAQg1t9Zj7hcFDVxfA0VtU4rhv/06QVC6J0wCXMxbkU0mBV2z3rPvRT6ppFHQ4lzsPifbXdDYvQ9kJPl3ZG6vpqrwo008zLOx49q37hmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736881645; c=relaxed/simple; bh=S1nW/wv8XIrKVZr0ybBJX26RLNTTI6rSLZ6ETVBXGdw=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=VUCFgzO/FNC9yznydjKYNZQaI9kovHlGB3+zXKudryIGoGr4wbdBMt8DCHVGbdsnUSGHyZc82xBdqVX3PjjR/lQShDrb3+I7Hcsg0oTbJlJisp1gFkNw0ypBg/1iTRpGMgJf6unSdTuXA7AL4WRma00RSDcSlckh6lS0TVY9IN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jdenose.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dXFaRvfC; arc=none smtp.client-ip=209.85.166.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jdenose.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dXFaRvfC" Received: by mail-io1-f74.google.com with SMTP id ca18e2360f4ac-844eac513efso463880939f.2 for ; Tue, 14 Jan 2025 11:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736881643; x=1737486443; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=HkXEGKaHS4Wap2DZ8mnEQl68mT1GrP1ybYkz9IG2DCI=; b=dXFaRvfC14CzXUKL0Zhu6C/ysP2Q1+qQNJxgpQfeUVswbxmdozu2Nt56X4ZXk8/MPe v2YJaRdcb/t0GKz5++8rSeuj6DOhR7vny63PL5xL0ZJo9tpVWRzv52k/LbyWZQ/Ptkqu qssgRwBLFJ/SEkcsg37cXPqTbvbuU5YSAsuUdLVCp8QMmGf3R5oBI2EWmcJekwKND54l PJd4RLd0jriUTll26hlFs5umLSUbIXh+5qtoh+0ckrHu+boT0spwazv9+Uv4IC/nIqMw +3opx5luMysLwNcocNICUQAZoGeBWdBYQGpzhFLotNBmoyRcsUXOhJDKMV6zU6k3/v9r tSRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736881643; x=1737486443; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HkXEGKaHS4Wap2DZ8mnEQl68mT1GrP1ybYkz9IG2DCI=; b=eH8fDTxkFHO+upEDq1C9WYUBn7m8GRE60rCM9Mowi7M9xHrmZkiSUsK7vy3B3uZ33k g9SQxTnwOaCJiooYxYLGYU+BiOkpwnIeXwbQ5QcM71eyYsLVoP/9bC+ScUHuPeyL4Qx5 j6SDE0jn9/SkSXBEtPgHv7aSQrd+I8071zoEiKuj5kdnMxY0mwz2nZZh1VtGTOr2MqBt ynbiNPb7DIDbRjosxDn5puFoigEstq7M8Y88Z5pAT6w9Dz48624CPtyVDsBc933LMxHl hGZ3jnViHJ9LtUaJAVvQePbYNJYtW+Jf4xXMoazlAMErKbZx+WKVxVnyYDW1gWVIQHj9 P8kQ== X-Gm-Message-State: AOJu0YwDnEDXD8aQp9JpVrnkcziqNShyvQlvAY800VZzSK4gRT2Jp/ew ew92niuUYdSmDHuHhR4+/bM/FICjiQYlxmCFWjqWH4+3RkIxwexIZen667AlU5v2W+JURGbp4Ie QQpctwJacQbqmV4FTiwi2uWDj84UweSSG6wg6e6vUG5c/HF6AlAK6kFHekqSB3G6wJPi7Nh3o/M YWsr0sJa6wxWVKBAW7wYtQ+U1yOi5AOpD1d0glliUstHXAwQ== X-Google-Smtp-Source: AGHT+IF2yRCyQfsIAsDtYjVAP2Lbj8881E3+iRCvgYZMjLJcfAwxx4hzxEoI7N0P45DSRRSxwN8MjS/wzzlZ X-Received: from ilbds6.prod.google.com ([2002:a05:6e02:3f86:b0:3a7:8a40:2719]) (user=jdenose job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6e02:1d88:b0:3a7:8720:9e9e with SMTP id e9e14a558f8ab-3ce3a90ef12mr193274515ab.2.1736881642681; Tue, 14 Jan 2025 11:07:22 -0800 (PST) Date: Tue, 14 Jan 2025 19:07:11 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.48.0.rc2.279.g1de40edade-goog Message-ID: <20250114190709.1.Ia17111747d0450169dbe902e5d7ef25912a9338e@changeid> Subject: [PATCH] drm/i915/display: Add skip link check quirk From: Jonathan Denose To: LKML Cc: rodrigo.vivi@intel.com, jani.nikula@linux.intel.com, intel-gfx@lists.freedesktop.org, Jonathan Denose , David Airlie , Joonas Lahtinen , Simona Vetter , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The display on the Advantech UTC124G3PWWW0E-ES worked fine until commit "drm/i915/dp: Recheck link state after modeset" was introduced. After this commit the display flickers intermittently as the driver code initiates the delayed link recheck in an infinite loop. To resolve this issue for the Advantech device, add a quirk to skip over the delayed link recheck. Signed-off-by: Jonathan Denose --- drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 +++- drivers/gpu/drm/i915/display/intel_quirks.c | 8 ++++++++ drivers/gpu/drm/i915/display/intel_quirks.h | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/driver= s/gpu/drm/i915/display/intel_dp_link_training.c index 397cc4ebae526..7804ad38b00cd 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c @@ -32,6 +32,7 @@ #include "intel_encoder.h" #include "intel_hotplug.h" #include "intel_panel.h" +#include "intel_quirks.h" =20 #define LT_MSG_PREFIX "[CONNECTOR:%d:%s][ENCODER:%d:%s][%s] " #define LT_MSG_ARGS(_intel_dp, _dp_phy) (_intel_dp)->attached_connector->b= ase.base.id, \ @@ -1622,7 +1623,8 @@ void intel_dp_start_link_train(struct intel_atomic_st= ate *state, lt_dbg(intel_dp, DP_PHY_DPRX, "Forcing link training failure\n"); } else if (passed) { intel_dp->link.seq_train_failures =3D 0; - intel_encoder_link_check_queue_work(encoder, 2000); + if (!intel_has_quirk(display, QUIRK_SKIP_LINK_CHECK)) + intel_encoder_link_check_queue_work(encoder, 2000); return; } =20 diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/= i915/display/intel_quirks.c index 28f497ae785bb..d472a5f21f8b9 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.c +++ b/drivers/gpu/drm/i915/display/intel_quirks.c @@ -78,6 +78,12 @@ static void quirk_fw_sync_len(struct intel_dp *intel_dp) drm_info(display->drm, "Applying Fast Wake sync pulse count quirk\n"); } =20 +static void quirk_skip_link_check(struct intel_display *display) +{ + intel_set_quirk(display, QUIRK_SKIP_LINK_CHECK); + drm_info(display->drm, "Applying skip link check quirk\n"); +} + struct intel_quirk { int device; int subsystem_vendor; @@ -229,6 +235,8 @@ static struct intel_quirk intel_quirks[] =3D { { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time }, /* HP Notebook - 14-r206nv */ { 0x0f31, 0x103c, 0x220f, quirk_invert_brightness }, + /* Advantech UTC124G3PWWW0E-ES */ + {0x5a85, 0x8086, 0x2212, quirk_skip_link_check}, }; =20 static const struct intel_dpcd_quirk intel_dpcd_quirks[] =3D { diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/drm/= i915/display/intel_quirks.h index cafdebda75354..9e8f2816a4fba 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.h +++ b/drivers/gpu/drm/i915/display/intel_quirks.h @@ -20,6 +20,7 @@ enum intel_quirk_id { QUIRK_LVDS_SSC_DISABLE, QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK, QUIRK_FW_SYNC_LEN, + QUIRK_SKIP_LINK_CHECK, }; =20 void intel_init_quirks(struct intel_display *display); --=20 2.48.0.rc2.279.g1de40edade-goog