From nobody Tue Dec 16 05:58:56 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F28E22DC44 for ; Tue, 14 Jan 2025 10:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736852160; cv=none; b=LrTQixixlPPrWBhY6YWVPUiqN9dQsC1MwVaNnLizwVr3GD3vYDZ3t/lVIUT6AcyJZp6oFeFalq6oRUzboe7mMq6KKR6c5wXSJel1fnbnlpfkv6XzUdY0YPMuawoZaic/iva4sn1cMcq2fOIaouwSOXZ+WNiG8W2YoyLby+fRHtU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736852160; c=relaxed/simple; bh=1v6DstPxyD7TnEAYfKglbDRmrD9xorEGh9RdZ6oKpqI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rtLo3qvzUNAeT4YPDmhBBG4p2tghW5N9CA2bRQPA6x828QlG7GzixIKoS3exjmdP71JZV1tGrcMyaoenOysGPQrCF5TefNxmRM0FWz4JpThzNN0Vb0MZEAoRpVc/2MH/7UCZqUJmSSOa1jTC5jxJRT11sMzWBNd2dvg1EPhX2u8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uGgJqv52; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uGgJqv52" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aaf34ec42a5so76170866b.3 for ; Tue, 14 Jan 2025 02:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736852157; x=1737456957; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6mH6fSABIQjQfrOs63h7SZKqORCSvRUauMFwjb1MJz8=; b=uGgJqv52UhMObE75Jc/fSZRsMgHItR0fFEOX1EIzJw/HKHrbpa3vyH+fEf+Vi9a75P amYch0rMb+SZam4X+Z4IUv9Sklrflb5k3Ls0MzhIgGoKfkRlT9HXtLIypiVDv2deDxk0 Emhl69oDsAoC0/VMw76bPDqyjFyZK8PcrUjifYN4/AClH+OQh6U1coUAf4H1KPgwuoaW hLNkggiVBINCx8ljE2Hmmr+ZzsDilp3vEZ13N/6HQFjqg202u21KfeHWMe5qGQmiTCqP W23NnxodXGuRlwsflHCeuqoApKtZk2duZ2OdB7heODnHC/L9MpE8vPgx0JKFDzJR9qk+ m+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736852157; x=1737456957; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6mH6fSABIQjQfrOs63h7SZKqORCSvRUauMFwjb1MJz8=; b=RT3onM733uVg5Fj8RAEc9PtBLYCNUUSrGWZez345xhYtUQlpY5wAeHnd66MQKPEyx2 kAG2lLJdZW1ZGozrv/joOp+hozagyXcgE9G6qwjHDfBNuBN5xvfS9hg6PVUwjQJEpj9z 52zPvRSCSoJyaAx6FalOeaOzWhdYshKFcFfgb1J6pVCRzMrTjqamlDdA6swJ/mRRR++7 qfloydXA/ISO7TIaoq3bR93v1JFRFclZ4kbQvreu53TGNjo4FhYk0rxQzI70J/ly4AGG xdJpdGSzh2zH0IE3KjO1luhdcrzAljn4YV0U6MbTyaGg/r/ODT2ECKqnJGhCGxyJhytd RGFw== X-Forwarded-Encrypted: i=1; AJvYcCV4DV46fcH1LsYv4lHxD+LQN5LW7FnrlC9KKDt7cLh6gOC5XjKRTmZrG2DjhPbYCijk1GTWMO+4+lAr1Rw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxfl39hKLmFtCRGQvSp0ko61DNpBtqGlvHMXszHcH30qgYrVgXB RGIa9LAKkeb1Fe7avFA1Jzpavrrzl53azt5vCbmmeq4ZSoS7Ck+Txwme31HuzP8= X-Gm-Gg: ASbGncs8f8q46GoukRy4UXU1Ey7BYfFMCtJ8zN7Su+cIX+lzeLHxvisTkOiyYq3FGVu oQuA7LPr3fZ647/hc8Wic7ZzSlGVg1J1q9j1lJxsGy9i6ZMxlvhKmOqu8YDd7EpKqG9YwwQ4YfD /XLbYjqUSJAE1Voj4Ln2a2wuJqk8IciPET7jVDB+HN+IzhshqqRkoden5MWk/xNnhmyvnYj0uqw nq09SpNlHukNmxN1dfp4EGTURYEUL8/XHoAt7eYNoMAeilSQ0DnDhUW8oipRrUhXU1x9SQ= X-Google-Smtp-Source: AGHT+IHbCyEQI2NTIiulDjFObPlITRIekk3IlqsgCYsJ1jdC7IGpxwnbidGWvk7wts9bxMRn/G9I1g== X-Received: by 2002:a17:907:72c7:b0:a9e:c430:713d with SMTP id a640c23a62f3a-ab2aa3fc05cmr848583766b.0.1736852156861; Tue, 14 Jan 2025 02:55:56 -0800 (PST) Received: from krzk-bin.. ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9564848sm608081066b.125.2025.01.14.02.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 02:55:56 -0800 (PST) From: Krzysztof Kozlowski To: Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] gpio: Use str_enable_disable-like helpers Date: Tue, 14 Jan 2025 11:55:53 +0100 Message-ID: <20250114105553.273085-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace ternary (condition ? "enable" : "disable") syntax with helpers from string_choices.h because: 1. Simple function call with one argument is easier to read. Ternary operator has three arguments and with wrapping might lead to quite long code. 2. Is slightly shorter thus also easier to read. 3. It brings uniformity in the text - same string. 4. Allows deduping by the linker, which results in a smaller binary file. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Florian Fainelli --- drivers/gpio/gpio-brcmstb.c | 3 ++- drivers/gpio/gpio-grgpio.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index 491b529d25f8..ca3472977431 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -9,6 +9,7 @@ #include #include #include +#include =20 enum gio_reg_index { GIO_REG_ODEN =3D 0, @@ -224,7 +225,7 @@ static int brcmstb_gpio_priv_set_wake(struct brcmstb_gp= io_priv *priv, ret =3D disable_irq_wake(priv->parent_wake_irq); if (ret) dev_err(&priv->pdev->dev, "failed to %s wake-up interrupt\n", - enable ? "enable" : "disable"); + str_enable_disable(enable)); return ret; } =20 diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c index 169f33c41c59..30a0522ae735 100644 --- a/drivers/gpio/gpio-grgpio.c +++ b/drivers/gpio/gpio-grgpio.c @@ -30,6 +30,7 @@ #include #include #include +#include =20 #define GRGPIO_MAX_NGPIO 32 =20 @@ -438,7 +439,7 @@ static int grgpio_probe(struct platform_device *ofdev) } =20 dev_info(dev, "regs=3D0x%p, base=3D%d, ngpio=3D%d, irqs=3D%s\n", - priv->regs, gc->base, gc->ngpio, priv->domain ? "on" : "off"); + priv->regs, gc->base, gc->ngpio, str_on_off(priv->domain)); =20 return 0; } --=20 2.43.0