From nobody Wed Dec 17 06:35:16 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D6361FBBFB for ; Tue, 14 Jan 2025 06:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736835386; cv=none; b=ssx1T4gDQ1Qij+FNgSS9PrRPgrjS/H4TcLMYqXWJPW9IxPRVmNn3gfI9a64J0AhGGsbtMEPjYKcVRY6K+fvVyjhdcaAmuL5z5t6dYSHrWbodxc1E1uYBgSS4nGZ02Rus9jYlb9LEiXBcoWeI41TB06+AofxZqYSEcboi8DbwZx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736835386; c=relaxed/simple; bh=AVyPdY9rXDEVlHzGIMPuTNfU4B0wipjRbt9rspINQNE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tqsPVns3Po3nt4SqjzmSDun0X18L8NsT8+kTIEuTCFC6e6PrRAuri6sFT5+aZqcYrN1xk7rTFdNWhiKHDLcVPJMuuORNYIGt1v35AyCyYd0IjPfLki5+cTb4lS7NvsPzitakE9dpFCbpesToC5TW0tmMJ9XBew20b+hTtr3G3a4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8CxyuA2AYZnCwtjAA--.62027S3; Tue, 14 Jan 2025 14:16:22 +0800 (CST) Received: from linux.localdomain (unknown [113.200.148.30]) by front1 (Coremail) with SMTP id qMiowMBxjcUyAYZn66EhAA--.1451S2; Tue, 14 Jan 2025 14:16:18 +0800 (CST) From: Tiezhu Yang To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xinhui Pan , Harry Wentland , Leo Li , Rodrigo Siqueira Cc: Nathan Chancellor , Josh Poimboeuf , Peter Zijlstra , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] drm/amd/display: Add SPL_ASSERT_BUG() macro definition Date: Tue, 14 Jan 2025 14:16:17 +0800 Message-ID: <20250114061617.31328-1-yangtiezhu@loongson.cn> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20250114061507.30765-1-yangtiezhu@loongson.cn> References: <20250114061507.30765-1-yangtiezhu@loongson.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowMBxjcUyAYZn66EhAA--.1451S2 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7CryfurW8CF1xWrW3Zr1fuFX_yoW8GFyDpw 1kWrn8uwn8Ja17K343J3W8CFW3Z397JF47X3sIv390va48uan7Zry3Jr4rtrWxWFWSya4r Jrn8WrW2qFsFyrbCm3ZEXasCq-sJn29KB7ZKAUJUUUUx529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUB0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ GcCE3s1ln4kS14v26r126r1DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2 x26I8E6xACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1q6rW5 McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr4 1lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_ Gr1l4IxYO2xFxVAFwI0_JF0_Jw1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67 AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8I cVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI 8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v2 6r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU4YLvDUUUU Content-Type: text/plain; charset="utf-8" In order to keep the current ability for the aim of debugging and avoid printing the warning message twice, add SPL_ASSERT_BUG() macro definition to harden the callers of division functions. Signed-off-by: Tiezhu Yang --- drivers/gpu/drm/amd/display/dc/spl/spl_debug.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/spl/spl_debug.h b/drivers/gpu/d= rm/amd/display/dc/spl/spl_debug.h index a6f6132df241..5677dd6d5408 100644 --- a/drivers/gpu/drm/amd/display/dc/spl/spl_debug.h +++ b/drivers/gpu/drm/amd/display/dc/spl/spl_debug.h @@ -11,18 +11,27 @@ kgdb_breakpoint(); \ } \ } while (0) +#define SPL_ASSERT_EMERGENCY(expr) do { \ + kgdb_breakpoint(); \ + BUG_ON(!(expr)); \ +} while (0) #else #define SPL_ASSERT_CRITICAL(expr) do { \ if (WARN_ON(!(expr))) { \ ; \ } \ } while (0) +#define SPL_ASSERT_EMERGENCY(expr) do { \ + BUG_ON(!(expr)); \ +} while (0) #endif /* CONFIG_HAVE_KGDB || CONFIG_KGDB */ =20 #if defined(CONFIG_DEBUG_KERNEL_DC) #define SPL_ASSERT(expr) SPL_ASSERT_CRITICAL(expr) +#define SPL_ASSERT_BUG(expr) SPL_ASSERT_EMERGENCY(expr) #else #define SPL_ASSERT(expr) WARN_ON(!(expr)) +#define SPL_ASSERT_BUG(expr) BUG_ON(!(expr)) #endif /* CONFIG_DEBUG_KERNEL_DC */ =20 #define SPL_BREAK_TO_DEBUGGER() SPL_ASSERT(0) --=20 2.42.0