From nobody Thu Dec 18 01:54:49 2025 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 179CF168DA for ; Tue, 14 Jan 2025 04:12:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736827974; cv=none; b=rXPAHDiGq2/Qyzo/msCpy/5dKVuwqpk8YIMXYlDMkALKVaWXXCAkeS2He43FHql5VRaBC1MuJPXAyCNMu9oPPmVv0aGzdZnQ64o0TMAstpaBCwSjH99NDXzP9Aosd5VRyoOhseGGqZEXWSR59DYREtHfZiPfMin8uOg9lSNHv/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736827974; c=relaxed/simple; bh=zVYPvjxWmGVnvcz9/+/VXA0hF9y2U8DgZ83GRUUKYkQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bCRwHvPgO34P14ueOtPfIZ2W/g3R1/CH6yljw5jN+cn0CX7zqKsFVEWCXHs+9h4Thods/smdopnFWjSnnCDRBgb+3GTZBWwtnzB9XauDG2ug+yrSxeadeL9APQWcCrSx7rsysxeNc3SPYWtZThPUPvaqncBHEWZcPwqP4f8pIQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=dKNQFSq8; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="dKNQFSq8" Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 18C9E3F118 for ; Tue, 14 Jan 2025 04:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1736827969; bh=ddArwCV9igXh0R+RFa1piEjZtwXPEtuSW/V3PR/z97c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dKNQFSq8uXeAuG0lBOPZOlunz4LZceCEsZ9fQ2ceMHguOJQlsscJWYpMbhfsb0oFc yu/LMnD7vUSrLNLzlalUe/6Xp3L89zcdMcjBX8hW4kwrySqewUGzRYymtP6h9jSHQE cq+Ppw7yi0QDhZOldDyBTEDFMQvC5FqZP97FfONia5Tabo8mANbIroymwz1d0KcXOV FPIEwSMh/t73HB7he1fh7jpte73IauJeUD91xW0D/qk+3PbGUOhkB4XaHHEHMgCM3h DBVDW0F5Ia92jLxUtVBjPSGZVDWK/OCZQzEcOuNGmcZ+d++yvpwiH8mKR4KCbPH+j3 FBhhRFh5xlLHg== Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2ee5668e09bso9134042a91.3 for ; Mon, 13 Jan 2025 20:12:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736827967; x=1737432767; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ddArwCV9igXh0R+RFa1piEjZtwXPEtuSW/V3PR/z97c=; b=eW1HZw7/h/GSVJ6jG91dhgnKLCAj+FX/cSQg0QWaBgJ0Gvb9DJDF4zlvNdZg88Lclu 6KSoTyv6r8Zt7Rx4vvjQA5G4QLp4kpt6RxZEgGC7XOva5X6LE2C4AkyqyjXaH8rRRRol hdyU7L2pynmy52lYDNfhgLNmrc7Jd7CM/GE7Fw0sZIBAwIDz1WmyoU9DcqD6FTDL0okk J34CIsom9f/zjr9rW62TNDC617RGt1sFA0tQ3cVr3hc1vSDn4YvfQgahDOOOWMZ8rSJA 3z4APcfWlScGG5H7AEtcbMKiuz2gYsFKYG//LyjoBxYjuLU3uDILvRX4GYLBvOtqRjL1 UHDg== X-Forwarded-Encrypted: i=1; AJvYcCVmHkEE9wMV7dus41wOUmCIbUih6XnIg4DcmB5/hpXXn2+wmevrOyYeWbjvLJWZf19VZ8OM41cV9A/0My8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6lsPt4Fdk0uU4n0SvGT0KXfI83G1yx6Viy16rEfX/cyGWpDhB vOkT/WRVUMXhdZYtnRFxBPpjraneAiRNBf8bTzZ5XrxCPx5y87GMbrNI34PO9C5Fp26M20SJL7S I3KKXEr8GPQ1v9rput18yDc3aLSBtX+ukPNAboI03WaxYQrHdVE4Mw41/41mGdTFVo+c+MPXIap Dt8k+qYiATqw== X-Gm-Gg: ASbGnctb9kxIbCqmSKQjNPV9St+xYj1vv+tVI6fwElZ899ELQ67DZ0zBiAwjsncjI8J SQ3rCBnS1wLkXodbg+0OCRzIvWNJ5OGtjc0tryDye5THy3zVFFZoWA81rRkg8uXXLsKY/pwe4Il EUZZUjmGVZqVKAfn7fytzrbm1mgiAfN9MMcvCzQ+MUSRITE80C5IbvhLmGJQNrPpRDIhL0XAJ/n 38tyB2W0/Z3qWUDdHIihAQRHvLWHODAQl6nUMVE41GXGv3S2hpEdeYDgdprj6iH9wnRCFtwJQkj YOgwAl1d6OqghJOcBLs+56s= X-Received: by 2002:a17:90a:f94b:b0:2f6:d266:f45e with SMTP id 98e67ed59e1d1-2f6d266fa49mr16044563a91.2.1736827966703; Mon, 13 Jan 2025 20:12:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmV8IcRs6T68Dl3Ba7F4dliWkYRFwDOz0jSpGgx7eIVTXHMHspMLan48ASzAKsmrOgnMaOqA== X-Received: by 2002:a17:90a:f94b:b0:2f6:d266:f45e with SMTP id 98e67ed59e1d1-2f6d266fa49mr16044538a91.2.1736827966384; Mon, 13 Jan 2025 20:12:46 -0800 (PST) Received: from chengendu.. (118-163-61-247.hinet-ip.hinet.net. [118.163.61.247]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f5593feaebsm8630578a91.13.2025.01.13.20.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 20:12:46 -0800 (PST) From: Chengen Du To: pjones@redhat.com Cc: konrad@kernel.org, linux-kernel@vger.kernel.org, Chengen Du Subject: [PATCH v2] iscsi_ibft: Fix UBSAN shift-out-of-bounds warning in ibft_attr_show_nic() Date: Tue, 14 Jan 2025 12:12:34 +0800 Message-ID: <20250114041234.3132563-1-chengen.du@canonical.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When performing an iSCSI boot using IPv6, iscsistart still reads the /sys/firmware/ibft/ethernetX/subnet-mask entry. Since the IPv6 prefix length is 64, this causes the shift exponent to become negative, triggering a UBSAN warning. As the concept of a subnet mask does not apply to IPv6, the value is set to ~0 to suppress the warning message. Signed-off-by: Chengen Du --- V1 -> V2: Address build warnings reported by the kernel test robot drivers/firmware/iscsi_ibft.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 6e9788324fea..371f24569b3b 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -310,7 +310,10 @@ static ssize_t ibft_attr_show_nic(void *data, int type= , char *buf) str +=3D sprintf_ipaddr(str, nic->ip_addr); break; case ISCSI_BOOT_ETH_SUBNET_MASK: - val =3D cpu_to_be32(~((1 << (32-nic->subnet_mask_prefix))-1)); + if (nic->subnet_mask_prefix > 32) + val =3D cpu_to_be32(~0); + else + val =3D cpu_to_be32(~((1 << (32-nic->subnet_mask_prefix))-1)); str +=3D sprintf(str, "%pI4", &val); break; case ISCSI_BOOT_ETH_PREFIX_LEN: --=20 2.43.0