From nobody Tue Dec 16 10:35:08 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0243C157A55 for ; Tue, 14 Jan 2025 15:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736868710; cv=none; b=q3Ml1rBnw0nlSsJ6SlpVlTuqaJA1ETunB3KJDZXFhtqUOYDik5l8Rb0o1YxditP8FULgbKFgvvUWK9DU50VsA2Q2iBLtKj1cBRQ5o7JlVMrM8RXknxiHLT1itdme9YEObGdGsFrS69pS801anXusU6kQ0kwy4Wpm5MfR2MYBRVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736868710; c=relaxed/simple; bh=WwKlVxTv7Oeh09OXx+DvjZEFIeEypUPrgYxitxNiF28=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JxQ43snqW+DlfV1MvyTUCjny5H8br/1DNJvAMQR6vWrp019jmuVwzU9+jGcu53r4JGjEwCJ5YforNY6FsI1pVheU1Szpx9gMuBrbBckcCJ11ZG5dkVfDT5Ti7T+zrEPwxkoxnx85kscH5wPteqxvF0eiha4tmQo5khkOMx/vFTU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Rww4GutW; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Rww4GutW" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3862d6d5765so3024004f8f.3 for ; Tue, 14 Jan 2025 07:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736868707; x=1737473507; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RmYlx/En2aqqfgAz0OoSAfJ3wizK8wbnQXwhJAWjCCw=; b=Rww4GutWC7vy+903fwKqVbdjh7ptEPyodeJR5ErcStemSSqLhX1SPTCJ9FrsFAXgZ2 HnKPqTawsKKkS9U8f+bZalPWMEIKAvvcjoKx3DCW3ev3UjQZ6IQYWQ3zewrLJ9htH89U 9Kdp/tt73zZn/hHuk3jkghWjMz+ygMu1bUR+93m1cGxnZES6GF/L5gKFCV6SCR2XSK1d ua93ucYSPIWCFbLl/E4Eh5M9f0lGe9o1i51+V2N/Zszcxcq+110hnNyXbfTtcH+jyg7G b+n9j7auq9rX858JGzkeYR4ezqHSxQtTLLahC8Q8/U2GdJa2u4OxGODu2iipikWArtUl 8cFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736868707; x=1737473507; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RmYlx/En2aqqfgAz0OoSAfJ3wizK8wbnQXwhJAWjCCw=; b=k6YcQ+o+ihwCqBvogiax37P5ipfmlP0GuiuXU2rLAcZ2Uq6qBtXjM2beSD8O/1ay3P 65hn0BkPhsDApfknLRTsFkGNp3PXSFrCTrE7ZzAyTqbM4YEOOh0YNEFJjSqysht6w88E SakrB29NJSKgBQZi9yZPAoicQMP889C0gCYs1q0ttcCO6zOXNu5qY8QSZwMseTLl/oXK 9931TM3NfeghHjBEeOkulrijhom6loD7Vud0d0/hVipllH/9STOQWAFBF6rE0eO0cSAt QK/TRMuYdnb3MslxC1uu3TH5QlDNOWQZhKQWE4DkawqRc+0mOTYCJsBl/frMhgtpKxFN sZjw== X-Forwarded-Encrypted: i=1; AJvYcCVKYAU+byoGEOWBaJKj7KuRvPFkmsZTE6zsxNXQogRN7Djk5P268G3KRUfBCJUoa+G25LSj8Y+n3FcW1JM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3hhfpzvGPx3TWfWmna7L9YsosmnM8Qksqp/zVe5I/ZnGQwFwR sAkITwEoP9odlX5P4Mtr7G3s7kBK6KZZH5HGg5aAXpwkc4WJSvDSeMFcSlYzvBk= X-Gm-Gg: ASbGnctC+TX0hj7UkrCm6Riym2kJcgm3SuyGtd5ZU7vHFxQRBeOaqWo6lxnFNhP6ujV 3SGKg0MgqbRfzYFRZKjrzkr6VkNy8+aP/5GucWlWQopf0oFxQJbsEMLSc6z543kekLbQkoPrD5Y fNKqz9pqE2wogmE8KiuFXgSgx4wK0PhLv8QBVyd9RYbaBmcAmDm+z2P9IFJxG6ru+5xJnsoueLf XwRWXpqaR+MpNY/7S8W6zeVSIbeIpuDy6I2IIWHPOO4NfMODh+MXx6cYeo= X-Google-Smtp-Source: AGHT+IGTfu68TjbqpJhz91FbPuANOfke+PQV/4PPq6Ra3BMMNeQguSEVyw6KgI7jOnEtN3nP89YzHg== X-Received: by 2002:a5d:6d0e:0:b0:38a:a117:3da1 with SMTP id ffacd0b85a97d-38aa1173f70mr10969153f8f.5.1736868705806; Tue, 14 Jan 2025 07:31:45 -0800 (PST) Received: from [127.0.1.1] ([87.13.70.66]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4b8116sm15049907f8f.79.2025.01.14.07.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 07:31:45 -0800 (PST) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Tue, 14 Jan 2025 16:30:11 +0100 Subject: [PATCH v4 2/9] iio: dac: ad3552r-hs: clear reset status flag Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250114-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v4-2-979402e33545@baylibre.com> References: <20250114-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v4-0-979402e33545@baylibre.com> In-Reply-To: <20250114-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v4-0-979402e33545@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno Sa Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.1 From: Angelo Dureghello Clear reset status flag, to keep error status register clean after reset (ad3552r manual, rev B table 38). Reset error flag was left to 1, so debugging registers, the "Error Status Register" was dirty (0x01). It is important to clear this bit, so if there is any reset event over normal working mode, it is possible to detect it. Fixes: 0b4d9fe58be8 ("iio: dac: ad3552r: add high-speed platform driver") Reviewed-by: Nuno Sa Reviewed-by: David Lechner Signed-off-by: Angelo Dureghello --- drivers/iio/dac/ad3552r-hs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c index 216c634f3eaf..8974df625670 100644 --- a/drivers/iio/dac/ad3552r-hs.c +++ b/drivers/iio/dac/ad3552r-hs.c @@ -329,6 +329,12 @@ static int ad3552r_hs_setup(struct ad3552r_hs_state *s= t) dev_info(st->dev, "Chip ID error. Expected 0x%x, Read 0x%x\n", AD3552R_ID, id); =20 + /* Clear reset error flag, see ad3552r manual, rev B table 38. */ + ret =3D st->data->bus_reg_write(st->back, AD3552R_REG_ADDR_ERR_STATUS, + AD3552R_MASK_RESET_STATUS, 1); + if (ret) + return ret; + ret =3D st->data->bus_reg_write(st->back, AD3552R_REG_ADDR_SH_REFERENCE_CONFIG, 0, 1); --=20 2.47.0