From nobody Tue Dec 16 05:43:02 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F347C1FDA73 for ; Tue, 14 Jan 2025 19:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736883364; cv=none; b=am9yZ7+bsOxQpW6qt3bX9yvgfIpSkqnAMnEKeQiL/x47/IQNyhGfciNgVvgk2N1Bk+m5FF4wVehTOxWQ87KmeRYhOH1v9wHDTin+oqHoETGodabL8rsfVp1/cv7kni3+xbb9wKvT+PVvRvj0ws9VeJkkyvlHEBoPnEoRME0KVzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736883364; c=relaxed/simple; bh=O+yA0BcFooderA43nycapEcPhnF2b5ugZ03N5RSt6H4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=GRHDH1Bn6iaYre2ch7I0fiYUQOpPf9dIyG+mZmbeETt4U3h5hdneAlu4EqKmyyAVvl+Xaf0BjO9zza6kDjPom2MNo+6nGpJSYegvK7SAIaqxlpv9nIP0aiTKMRolEbbvKCk4XV8NN71m8eGWNM/R1NBuVuekEAa/j19TcKbMjTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=vnHolxqZ; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="vnHolxqZ" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2165448243fso127901735ad.1 for ; Tue, 14 Jan 2025 11:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1736883360; x=1737488160; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=zjPSmGagsH0v8BRh7RqgTWU2umihKyaeHVzwlH5BliU=; b=vnHolxqZ9jeF61pO1uWeVOg4BGtxYyb5DJiTacoIEuqoIOqxokhMyb5N+ck9pER4Bl fSZBSUGYB1JMxV0ONIc3OZhZ5e9QtFeUlsO2u0GI7Ys8aS1fJblDvrTdce9eJ+6oZPEM yII4Ax12G2H73uXHOQIyY5RU5gDJZxNt2h7fgnlEsSnXuZzfr0QeGvXZEK1XAFfwCi3u ckR92YkjFwJ14B3bJD+Y7inj9Wrz6cS3p4f06iRJI0ZDbP/GXqx2IXvkxbLpsxHzEPJi ulAxerP18nPgGxiTsNegJwhUWWtuFF6V2hlsfGdeEzlPOTdGwniD6uS/HOlz84nNAUMQ 6q7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736883360; x=1737488160; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zjPSmGagsH0v8BRh7RqgTWU2umihKyaeHVzwlH5BliU=; b=gRBY3drJlR4rDHnxtGbJBN0ENW3P8tNGerP1jd3Vv6ElvmAwh5RMSH6JnsBw33Iw/W ObUdgXhXfzKUcNLYlt5tmF2XEFV7dQR/blYCtgJ6H69x/7qT5X7bgWeQZDI8jwo7aqpg Uz1c8T8v9v3bBlT6ftVvdUGZiA0nf31c2sA0efPpJRql/YpxS2k3PiW9usvn55E8X12G YejaCA6AkZJlNS7zkxGp/KMJv7DpWjA78oFp4kcmhtv6TJBtaPAxd+gu9/BkKmETuWY/ 02KHe/qbMAa09Pokzx0LCKbaJSxkpGfRs+2hHBZelT/KSLDTaPFkUzLzuAy3PNVo28hG LaAA== X-Gm-Message-State: AOJu0YyZgYmX6bX/WKQRlGSk40pG65V349kSkpWH9iL9ewSnzA6cElx2 AvPYmVdcB9aka0wXdeg+WSreqFs3hQpsyoG+k/jKUxRfN8udwqvKiPCzqSYTqX0= X-Gm-Gg: ASbGnctyQR+gOcoiVSdbwDndZ+toR8AqHKU8677GZaE3Sw0+7U8QIyntlmLIt+eDvhP mtAqr4c+AFylI1EQgmsTqjBy4w50Zfak95ZVLlBvhJJgmBsn/U4KONnzk+b506pnkoxhWujLN9L vlpFs4MFvYCojuynBH5iEHeE7bXEfPVpFk3G92rpLICUZAIcNBcrTeLTJW0cseaV9KJEdAzA3rS zDP0Vi/Yw7+v1/OYQgnhdHeqlXYxdUwPVCpX9M2T+J49lbvdqMg1T8AqHJZF9iCP+B3BE2n X-Google-Smtp-Source: AGHT+IEgEQ10/D4X/vMFHIRsZzWMSEwp0cQc4L0bKoR1oseHYe1ipJQlzxnnAZuOmG10fkB2fgzL1g== X-Received: by 2002:a05:6a20:c89b:b0:1e1:aef4:9cd0 with SMTP id adf61e73a8af0-1e88d139b44mr40009862637.3.1736883360270; Tue, 14 Jan 2025 11:36:00 -0800 (PST) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-a317a07c769sm8491598a12.7.2025.01.14.11.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 11:35:58 -0800 (PST) From: Charlie Jenkins Date: Tue, 14 Jan 2025 11:35:44 -0800 Subject: [PATCH FOR-NEXT] perf tools: Expose quiet/verbose variables in Makefile.perf Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250114-perf_make_test-v1-1-decc1c517b11@rivosinc.com> X-B4-Tracking: v=1; b=H4sIAI+8hmcC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1MDQ0MT3YLUorT43MTs1PiS1OISXaCQYYpJYoqFhbm5ElBTQVFqWmYF2MB oJTf/IF0/14gQpdjaWgCHfi1magAAAA== X-Change-ID: 20250114-perf_make_test-1141d4ad8877 To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , James Clark Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo , Charlie Jenkins X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4609; i=charlie@rivosinc.com; h=from:subject:message-id; bh=O+yA0BcFooderA43nycapEcPhnF2b5ugZ03N5RSt6H4=; b=owGbwMvMwCHWx5hUnlvL8Y3xtFoSQ3rbnqnejl0F6ecsvs39q3Ts5bNnu7cvFnvp+oZNc4vm5 V7n/u8nOkpZGMQ4GGTFFFl4rjUwt97RLzsqWjYBZg4rE8gQBi5OAZjI7Y0M/33Xrl5X5eh0cIFq UJt83mrJvXmVV1i51kZYiin3vmNZvZORYcvzKPOOdemOtbvtu16f1bfbHZ4exGB+qGziPcb3O/P imQE= X-Developer-Key: i=charlie@rivosinc.com; a=openpgp; fpr=7D834FF11B1D8387E61C776FFB10D1F27D6B1354 The variables to make builds silent/verbose live inside tools/build/Makefile.build. Move those variables to the top-level Makefile.perf to be generally available. Committer testing: See the SYSCALL lines, now they are consistent with the other operations in other lines: SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscall= s_32.h SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscall= s_64.h GEN /tmp/build/perf-tools-next/common-cmds.h GEN /tmp/build/perf-tools-next/arch/arm64/include/generated/asm/sysre= g-defs.h PERF_VERSION =3D 6.13.rc2.g3d94bb6ed1d0 GEN perf-archive MKDIR /tmp/build/perf-tools-next/jvmti/ MKDIR /tmp/build/perf-tools-next/jvmti/ MKDIR /tmp/build/perf-tools-next/jvmti/ MKDIR /tmp/build/perf-tools-next/jvmti/ GEN perf-iostat CC /tmp/build/perf-tools-next/jvmti/libjvmti.o Reported-by: Arnaldo Carvalho de Melo Signed-off-by: Charlie Jenkins Tested-by: Arnaldo Carvalho de Melo --- tools/build/Makefile.build | 20 ----------------- tools/perf/Makefile.perf | 37 +++++++++++++++++++++++++++= +++- tools/perf/tests/shell/coresight/Makefile | 2 +- 3 files changed, 37 insertions(+), 22 deletions(-) diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build index 5fb3fb3d97e0fd114e245805809e4fc926b4343e..e710ed67a1b49d9fda11db02821= bbd8d36066b44 100644 --- a/tools/build/Makefile.build +++ b/tools/build/Makefile.build @@ -12,26 +12,6 @@ PHONY :=3D __build __build: =20 -ifeq ($(V),1) - quiet =3D - Q =3D -else - quiet=3Dquiet_ - Q=3D@ -endif - -# If the user is running make -s (silent mode), suppress echoing of comman= ds -# make-4.0 (and later) keep single letter options in the 1st word of MAKEF= LAGS. -ifeq ($(filter 3.%,$(MAKE_VERSION)),) -short-opts :=3D $(firstword -$(MAKEFLAGS)) -else -short-opts :=3D $(filter-out --%,$(MAKEFLAGS)) -endif - -ifneq ($(findstring s,$(short-opts)),) - quiet=3Dsilent_ -endif - build-dir :=3D $(srctree)/tools/build =20 # Define $(fixdep) for dep-cmd function diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index a449d0015536442273a9268b37be34e4757f577a..55d6ce9ea52fb2a57b8632cc6d0= ddc501e29cbfc 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -161,12 +161,47 @@ export VPATH SOURCE :=3D $(shell ln -sf $(srctree)/tools/perf $(OUTPUT)/source) endif =20 +# Beautify output +# ------------------------------------------------------------------------= --- +# +# Most of build commands in Kbuild start with "cmd_". You can optionally d= efine +# "quiet_cmd_*". If defined, the short log is printed. Otherwise, no log f= rom +# that command is printed by default. +# +# e.g.) +# quiet_cmd_depmod =3D DEPMOD $(MODLIB) +# cmd_depmod =3D $(srctree)/scripts/depmod.sh $(DEPMOD) $(KERNELR= ELEASE) +# +# A simple variant is to prefix commands with $(Q) - that's useful +# for commands that shall be hidden in non-verbose mode. +# +# $(Q)$(MAKE) $(build)=3Dscripts/basic +# +# To put more focus on warnings, be less verbose as default +# Use 'make V=3D1' to see the full commands + ifeq ($(V),1) + quiet =3D Q =3D else - Q =3D @ + quiet=3Dquiet_ + Q=3D@ endif =20 +# If the user is running make -s (silent mode), suppress echoing of comman= ds +# make-4.0 (and later) keep single letter options in the 1st word of MAKEF= LAGS. +ifeq ($(filter 3.%,$(MAKE_VERSION)),) +short-opts :=3D $(firstword -$(MAKEFLAGS)) +else +short-opts :=3D $(filter-out --%,$(MAKEFLAGS)) +endif + +ifneq ($(findstring s,$(short-opts)),) + quiet=3Dsilent_ +endif + +export quiet Q + # Do not use make's built-in rules # (this improves performance and avoids hard-to-debug behaviour); MAKEFLAGS +=3D -r diff --git a/tools/perf/tests/shell/coresight/Makefile b/tools/perf/tests/s= hell/coresight/Makefile index b070e779703e9fbd70f88c826172b2150ee3d302..fa08fd9a5991dd889583edc1afe= 8304e72278f64 100644 --- a/tools/perf/tests/shell/coresight/Makefile +++ b/tools/perf/tests/shell/coresight/Makefile @@ -24,6 +24,6 @@ CLEANDIRS =3D $(SUBDIRS:%=3Dclean-%) =20 clean: $(CLEANDIRS) $(CLEANDIRS): - $(call QUIET_CLEAN, test-$(@:clean-%=3D%)) $(Q)$(MAKE) -C $(@:clean-%=3D%= ) clean >/dev/null + $(call QUIET_CLEAN, test-$(@:clean-%=3D%)) $(MAKE) -C $(@:clean-%=3D%) cl= ean >/dev/null =20 .PHONY: all clean $(SUBDIRS) $(CLEANDIRS) $(INSTALLDIRS) --- base-commit: e9cbc854d8b148e3491291fb615e94261970fb54 change-id: 20250114-perf_make_test-1141d4ad8877 --=20 - Charlie