From nobody Thu Dec 18 09:59:11 2025 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CDDE1C1F15 for ; Mon, 13 Jan 2025 21:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736802125; cv=none; b=gkgeq9lnQo6+T4s3lzNjtvCiXlwp6Z6Ao5gjO9pOpRk9VusSwWWge0uGX857yPum4bIzprPAktU6Mln5ao0GVjovCbtOXd39Nf0J5TIgT3t6bBjm/aY3Mney8WLn5FG6+3YUYvdl/yyROZexiyZlmUERwqlng5L2WogNvqL/A1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736802125; c=relaxed/simple; bh=+JSsTP8kIMKWtfZFJUavv4mn5IpfuVorZIJsToS7o4k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GnyGaApzzD3H670pfJhOeuuT5GpXvkS5yX8kgJPGRIab93y1ZgP3F2L1sWOUAVQBCdlngbmbU2+B7kHzj+dVMsHy0HFjOa96zI1O+gE7zk2b6SdMMSshhvNLV2ZGCDYvohsmy1j0CcxzbCeqt5kXQEoEWArvI9TV7ll6IbYZ4zY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b2zoeqYW; arc=none smtp.client-ip=209.85.219.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b2zoeqYW" Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-e3983f8ff40so6860569276.1 for ; Mon, 13 Jan 2025 13:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736802122; x=1737406922; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CsPltl3rf+aszSkn/zoUX72WoPGcRbYKILIx7PZGqT0=; b=b2zoeqYWFHS23JJsWZUXrUpB6H0VhbRX04vRG09q6NAUXWGylPafqBqq8RV6Lqz3yo D/I6dA32sHNFYNFQhDgVALvQQvt/KrFOy+Tyj2oAXxbwIr91taNE7Vk0yJwP5Sl42PXu 2QEB7hoTx9B0XzFPGpDr6clJd2kxI47PhMufdHwAPqDTojrrH0UGqmrLBYxEEJhive6q rcXYa4o0dkYWetfYYJJf9aSxwtv9lyck3P0+K04EUhMEAj9nPM4rqLQrwxVQDy+YZGzl CuLUUC331gsPd98jioK04PHFrbqwI2iOIoCmofQ2JvmiCz07qevNkf5TyjeNqdQV5gow 2Omw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736802122; x=1737406922; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CsPltl3rf+aszSkn/zoUX72WoPGcRbYKILIx7PZGqT0=; b=T0VVx95+c9XcIHWixQ8XVa8O5ylZkQ7Kx5QV/R8yfliSHrsEkDW8MLB8ksg8oMcPT4 y/Tceq2PPVAoP6pn5KVIE6LBlelIqauumi42QWOPHp2gGIEwMTjYPdtdahctcpyIIxx4 aJuf5YmF1hNFQLNBdnqEdYosDiIeUNpjhLfwBbLeEua86wsp2n1eDtMfZCgP7S7A/MW3 kMSwnXiVNkek99Xb2kw8lG8Re6RNVPmVpHKm02CQ0a5qVtnE+hQMaJM78j/dgKTt2Z2j QTEg0wa9wtniS8GisbuoVLtiIPLCzJ5wuv0f8Z7GiCjpv2uPS0w2dYCOskxln1SlBLTW oZtA== X-Forwarded-Encrypted: i=1; AJvYcCWpKDavThwhi147E4pd6Avf726fe2Rjcmr6hNOWvLnQtSIfZKQGmasBGibiPpL9sSYJgsxfMT6O86Lru98=@vger.kernel.org X-Gm-Message-State: AOJu0YxpR9bBVgcpZjBdgIvuAWV4G5tFrsdW1JTdxjStoDsuGTLoxVCg egyW5hNUCTdccQqaP4oPP6GDbQ763nNU1tWhYtg8nBwkl77x3RK3QjcNqg== X-Gm-Gg: ASbGnctkMSA6TAHTa7fEXeWHEL52+JFjrSuoblZrx7mx+g/d931FCZHNk0C3Rxrh0mp LOkDq2hsGqvq9G3XWrWbmayubh1KfctIQ3M0n6ja8SWNHkBI271C7Rv647SqT38lVD9x5K/ck6K bbtGMnGipIBHRQ4SKe40hn1uwvNerLEI7/ySCn1qUj7sgR93e+wSuT/3+75gY1jgDfAiKSz/2a/ ciTmoyYkTF+wzIvMdKsUXGSujKB2uP3ZuCkorKLawmvt+iL1J4X+4M= X-Google-Smtp-Source: AGHT+IHOKnrP82pMHAmLLLzeNGP7pn9YOeeAXy8YQYQKgmKSgDo3F2kKkmQdnSrnETBO2gkxIwwfJQ== X-Received: by 2002:a05:690c:680d:b0:6ef:61b9:dfca with SMTP id 00721157ae682-6f53125c889mr189473677b3.20.1736802122470; Mon, 13 Jan 2025 13:02:02 -0800 (PST) Received: from localhost ([2a03:2880:25ff:9::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6f67c99c9d7sm10281607b3.47.2025.01.13.13.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 13:02:02 -0800 (PST) From: Joshua Hahn To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: [PATCH] mm/damon/paddr: Improve readability of damon_pa_stat Date: Mon, 13 Jan 2025 13:01:56 -0800 Message-ID: <20250113210201.446051-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.43.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" damon_pa_stat contains an unnecessary goto statement, and the if/else can be re-written to be more readable. This patch is written on top of SJ's patch series [1], which in turn is written on top of another one of his series [2]. Signed-off-by: Joshua Hahn [1] https://lore.kernel.org/all/20241219040327.61902-1-sj@kernel.org/ [2] https://lore.kernel.org/all/20241213215306.54778-1-sj@kernel.org/ Reviewed-by: SeongJae Park --- mm/damon/paddr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index b0c283808ba6..8cdf8320f9a5 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -509,11 +509,8 @@ static unsigned long damon_pa_stat(struct damon_region= *r, struct damos *s, if (!folio) continue; =20 - if (damos_pa_filter_out(s, folio)) - goto put_folio; - else + if (!damos_pa_filter_out(s, folio)) *sz_filter_passed +=3D folio_size(folio); -put_folio: folio_put(folio); } return 0; base-commit: 2c0573ae5b4c9c0f9d81fa0138ed0014e1baf41b --=20 2.43.5