From nobody Thu Dec 18 10:03:39 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 013451BD9C6 for ; Mon, 13 Jan 2025 17:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790293; cv=none; b=KVfNIj/y4S2F6HO6X+X9fvom8XBtyxfXWjP19qzIcDB5+wJomYSpvvwGd4CbyFeQVA7Jfi54d0zZohKNNVmZWUI4ApdB5HxOKn1xSmsRnoePbkWUraERqOJ9hyHm8Yl12nUWb4qG+x+LYwB7q4l278LcKR9+SSWPWA5L5Ue5V0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790293; c=relaxed/simple; bh=F2KZg16EBTp92ge3DrBqc9jy1V79LKncQdKxeIVxUOg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DIA6bdctMcmUQmgzBE3XW7CqvIKviB5knFtrkeuX4vxaKyI2pyeRtInQ0m1wICdwze15NmyrW9pNV+eOi6WQDQnZJ2X33ZFeu2tR6pQNf0UDBPypzXHMynsHLVSXSxvzWPRLzon7VgfL4gOXb2aXoUVxCmBTomKP+h6CnUDok0E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=jpABpXlW; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="jpABpXlW" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7b9bc648736so409886285a.1 for ; Mon, 13 Jan 2025 09:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736790291; x=1737395091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5lYIOjwVOiyZSO9nrORqGYqQ+1pRAYOeyq4Co+ahKG0=; b=jpABpXlW3rerS4GsjVOihPJsh35EflWQAd+8/TNnwQZ8/sX9dn0HFUdIQRnOXsLpuR Da6G2ChDus8OxbgIaIQfNbOvMTFgUOgpFsHktPuVXkppHjxu5v9xOi2fW1+l1rNbKjuq 8MRqeqz0IgLv41kLCmu9I/+5grrB+D0nLwMn0Pdc+c9IoMvuwRudqwdIOyENL2VwWfEY 0VB0cT4ALEkxOxGmgPZWDVW8HkRuDlZDG4azcDwhTr4dOyV14OpGuC2YsK0f8PEGWUN+ Dfgq+mx8SFh+jPrPY056TRNlzSQRhkCU6WkShXZv1ecp3Hm/8i2+pzuVI3W28N2egMx+ MT6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790291; x=1737395091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5lYIOjwVOiyZSO9nrORqGYqQ+1pRAYOeyq4Co+ahKG0=; b=SIa7dWzYDSZbMJ/WX99js5zDsaNMDQK4YnBF0XiWg3XJVNegYxc0QQ+SSTRdJTEHkA 6grEHNWnO6gjgDCSXu9y5P0P4K60DYndpruL9xtJKgpwcjLxEay5I2KCWvo9Tc4xH+ad 0XiQwVkRYEHTn3t8J9q62A93RJ4+lbyGvCopK0E9KZJ14fFLbNFDlRV3vHWlUTkKd8hz 4YCPRKyat3ILtnSW/T4A1P6aqoh0RFqIpD0YyhpVpAj9CALEknBrxgdPkbZblIdIiez4 I8OyI9vHsROXgwuZw+3/hci1Su5T1Yb94GZbuClFpZNUalqgtaI7QleYQcdKkhdyBIYo w7EQ== X-Forwarded-Encrypted: i=1; AJvYcCU5jDGp9oyd56SOU+/XVaRL7Vzy4dUYSXzFGhSiHJMSUMCtkSJWpY7wMHGVIp6YEykLsYE7r6jcBU9zrfY=@vger.kernel.org X-Gm-Message-State: AOJu0YxXV/+1huVKXfYJKUgOZEcFaQFCj/huvihr9FoklAR8N08pq4Pe h0A8sM6We2EgFdUYgTCqXimRNuE6cC/Na0hA4uGl4MUKgWyzpAouxnaqDAt+lZo= X-Gm-Gg: ASbGncsiU5lQaGpDw95Q0oyyn+ko9P0wGBVCyUt0emWMZo63MBpKVnAsoM8SFB1eqDq BseHDoxgqqiKHw3qNgVMz2p5d55fYAjHCr97cMTmSMi2GjI286j/I71wDlCL8k2Vwv3fzlY9Bha V1XyYfdXOS8i+j62Vcc2+vpM6x0tu9PHvmyny94gauSxm6eZipJwDSBm4n0/0LWL5VuyLp5n5ht xxQxuYfeZbl8Da80hdAJN5b0xQhN5hS5m6AKwAH5pFvc+zGUxOCoYwF3CH+HWrl5QD3VvyFoY+T RfxtQODS7LoHZd5FQfSA3ZFGObwlpZqZZqeXlKPJL0DG X-Google-Smtp-Source: AGHT+IGji/zdVSjj+QKuBorX8KRhL5U0vYxcdcXprimxamnxuQtc2su0NPyPj8UIhAzTvvuSrnfbyg== X-Received: by 2002:a05:620a:460f:b0:7b1:1d91:5d06 with SMTP id af79cd13be357-7bcd9759e0amr3397038585a.46.1736790290892; Mon, 13 Jan 2025 09:44:50 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3248c80sm511214185a.49.2025.01.13.09.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 09:44:50 -0800 (PST) From: Gregory Price To: linux-mm@kvack.org, linux-acpi@vger.kernel.org Cc: kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, gourry@gourry.net, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Ira Weiny , Fan Ni Subject: [RESEND v7 1/3] memory: implement memory_block_advise/probe_max_size Date: Mon, 13 Jan 2025 12:44:37 -0500 Message-ID: <20250113174439.1965168-2-gourry@gourry.net> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113174439.1965168-1-gourry@gourry.net> References: <20250113174439.1965168-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hotplug memory sources may have opinions on what the memblock size should be - usually for alignment purposes. For example, CXL memory extents can be 256MB with a matching alignment. If this size/alignment is smaller than the block size, it can result in stranded capacity. Implement memory_block_advise_max_size for use prior to allocator init, for software to advise the system on the max block size. Implement memory_block_probe_max_size for use by arch init code to calculate the best block size. Use of advice is architecture defined. The probe value can never change after first probe. Calls to advise after probe will return -EBUSY to aid debugging. On systems without hotplug, always return -ENODEV and 0 respectively. Suggested-by: Ira Weiny Signed-off-by: Gregory Price Acked-by: David Hildenbrand Acked-by: Mike Rapoport (Microsoft) Acked-by: Dan Williams Tested-by: Fan Ni Acked-by: Dave Hansen Reviewed-by: Ira Weiny Suggested-by: Dan Williams Suggested-by: David Hildenbrand --- drivers/base/memory.c | 53 ++++++++++++++++++++++++++++++++++++++++++ include/linux/memory.h | 10 ++++++++ 2 files changed, 63 insertions(+) diff --git a/drivers/base/memory.c b/drivers/base/memory.c index 348c5dbbfa68..e59378ec5b00 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -110,6 +110,59 @@ static void memory_block_release(struct device *dev) kfree(mem); } =20 + +/* Max block size to be set by memory_block_advise_max_size */ +static unsigned long memory_block_advised_size; +static bool memory_block_advised_size_queried; + +/** + * memory_block_advise_max_size() - advise memory hotplug on the max sugge= sted + * block size, usually for alignment. + * @size: suggestion for maximum block size. must be aligned on power of 2. + * + * Early boot software (pre-allocator init) may advise archs on the max bl= ock + * size. This value can only decrease after initialization, as the intent = is + * to identify the largest supported alignment for all sources. + * + * Use of this value is arch-defined, as is min/max block size. + * + * Return: 0 on success + * -EINVAL if size is 0 or not pow2 aligned + * -EBUSY if value has already been probed + */ +int __init memory_block_advise_max_size(unsigned long size) +{ + if (!size || !is_power_of_2(size)) + return -EINVAL; + + if (memory_block_advised_size_queried) + return -EBUSY; + + if (memory_block_advised_size) { + memory_block_advised_size =3D min(memory_block_advised_size, + size); + } else { + memory_block_advised_size =3D size; + } + + return 0; +} + +/** + * memory_block_advised_max_size() - query advised max hotplug block size. + * + * After the first call, the value can never change. Callers looking for t= he + * actual block size should use memory_block_size_bytes. This interface is + * intended for use by arch-init when initializing the hotplug block size. + * + * Return: advised size in bytes, or 0 if never set. + */ +unsigned long memory_block_advised_max_size(void) +{ + memory_block_advised_size_queried =3D true; + return memory_block_advised_size; +} + unsigned long __weak memory_block_size_bytes(void) { return MIN_MEMORY_BLOCK_SIZE; diff --git a/include/linux/memory.h b/include/linux/memory.h index c0afee5d126e..8202d0efbf46 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -149,6 +149,14 @@ static inline int hotplug_memory_notifier(notifier_fn_= t fn, int pri) { return 0; } +static inline int memory_block_advise_max_size(unsigned long size) +{ + return -ENODEV; +} +static inline unsigned long memory_block_advised_max_size(void) +{ + return 0; +} #else /* CONFIG_MEMORY_HOTPLUG */ extern int register_memory_notifier(struct notifier_block *nb); extern void unregister_memory_notifier(struct notifier_block *nb); @@ -181,6 +189,8 @@ int walk_dynamic_memory_groups(int nid, walk_memory_gro= ups_func_t func, void memory_block_add_nid(struct memory_block *mem, int nid, enum meminit_context context); #endif /* CONFIG_NUMA */ +int memory_block_advise_max_size(unsigned long size); +unsigned long memory_block_advised_max_size(void); #endif /* CONFIG_MEMORY_HOTPLUG */ =20 /* --=20 2.47.1 From nobody Thu Dec 18 10:03:39 2025 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B021BD9FB for ; Mon, 13 Jan 2025 17:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790296; cv=none; b=i5O6bnC0UP6e6ZTSBlQMAKZ45o3+tfivLAONQctMBzbjBLLNDMHq4z0bTjFBs/jkEDPev2WcEZA69xEdyRQQDNJHM8ZXQpnE4WC7Aeet9Li24EgNWLbNWY10up7b1zVmFSQWUHpdih9pimR1Sd2tuvZyHroxDKUkC4mD17AeGWs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790296; c=relaxed/simple; bh=Z6hmuojvYtXTroj1JJWHKwTtvZg1ohkoBA7CDtsjZso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oIUWjA/FcofcjoXjsx0FFRb0hNiLKxloCQn8PrxmE7oLDJfiAVpjqYBUbieWCC1vQ2lNAAG8GOM503v+T9m98oogji9nKKsyBNkzWjx/EEzrNp6omEcQsiB55SpTELZl1O+V6S6IfRCtMzV277EeTiPUZD2e81NIQ53CB5JfKl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=cDLsdk0w; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="cDLsdk0w" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7b6c3629816so260199985a.1 for ; Mon, 13 Jan 2025 09:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736790292; x=1737395092; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xZSM7cd0rzVSNSrAghH4+54a5vGC27L1Y4nGLMrRkSY=; b=cDLsdk0wSNVC6HsXeucUQLdvPy3zy9q05WcNaAUzzEnlg8Cxf8l0nVVrDC/i6zRhCy 2Jxx1UmKL6UgEv2mXTz71gQb9puPzYSiiJ2ifHX4jBL7h/uFy9LuLKOKSbd5i0iLBQds YYRrbIKgJdvYyJwHaT5omy8i3fWcDoc+gfHVBq7O9QGfaLosivCDBlNCiPEy2xwFQ8Fs JdqBC3vleqV4naM5YGU8N148XpoB1d6LcUzM9YkAV/4jnTHmwA5q7gHR4yKnKOzD7Zo1 ZEhU1knkgyTRDbjnofPWcew3JFYvKZ8LB/Z3TnAPMTh52lC7BTUfVFGGOENOO2dnpKlK u43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790292; x=1737395092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xZSM7cd0rzVSNSrAghH4+54a5vGC27L1Y4nGLMrRkSY=; b=Qd34hKoFWUmxDvXr4HQh10RPs7r/uwNLqgO77L6zaRqYlPccPM2srpuqo0z11f4lkg PSSGWUgMzQ6Kgw12mflL5BKNiaYejKwaYZmoVo8F5oyewZH0iQfNejAEsCMMTle/hRYh cs2f2nqNhHcTB9+ACQlqMRA+9Fce7SxKjwVlsdrk7VlznV8YbpO2wZXDWjOZY4a3wejp zNzxRmTOv12E+b+KJj+xgL2/Le+Dssf08WhZoQ+0KrJAVsIncxAYeHvhqLSuXLqKsALJ eLVbKvsawKKpucKN7bBCrmWuPXHPsfl2BatTI1DOlVfQeTxQhvLc+n3CQ4nizKlkBs03 Kfuw== X-Forwarded-Encrypted: i=1; AJvYcCVWIeBRT1W/oNXYcGwBohUWVxeNcY5YNqa9gkj8yDKuZw3YU0y+WyH8GqTyzQvPb18q4rrcpncxTGl0CAA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2xKEk0nYz37hcQsF6vZKWdl4xbY88JBOOrlv06joERJQ/c+Jl 5wgf4QGFcYYiaiOOn4Mlwk5r7qwMfkAkF+s+E/4BDrCQUNmu3bz5JwrE6XO03mg= X-Gm-Gg: ASbGncsE1VJjmTTncJmUoK4JprNTnbJUcOgBmWY3o1mDj/t39BBiwI6q5V3lSH/MPcR tjd3VVyFrIABBoVFk4XX8z4hRnmoTVefmnShGGIxaW0b50Pr3749dQXBItfh9h1JPBxoOL9gNrP ZXAldIydbgQA6uMxOsZWfP+pPHiM16wXQpp6CPK0sPY7dP5o+VSSiHOsYEd8knTsWhRxuhXu3yP nTHuK2+dqIjDqbO17BT9UOMIdf33RkLI5jXzLynC9ixKYxVoIPKS4AaDfaEjjTDmfBZmGg5yLFr N4n9uSwrOgC7jv8Fy9HePg3OLezYmFqS83FbX3+asrSx X-Google-Smtp-Source: AGHT+IF+IF6Rv5no47DpWYrkZUPK0sDnR8tgi7nlXfUyokU9C1+7BbgLKk1J4eOLXpCwFls4u2oImw== X-Received: by 2002:a05:620a:2697:b0:7b7:24b:dc58 with SMTP id af79cd13be357-7bcd97627d1mr3005432485a.43.1736790292471; Mon, 13 Jan 2025 09:44:52 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3248c80sm511214185a.49.2025.01.13.09.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 09:44:52 -0800 (PST) From: Gregory Price To: linux-mm@kvack.org, linux-acpi@vger.kernel.org Cc: kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, gourry@gourry.net, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Fan Ni Subject: [RESEND v7 2/3] x86: probe memory block size advisement value during mm init Date: Mon, 13 Jan 2025 12:44:38 -0500 Message-ID: <20250113174439.1965168-3-gourry@gourry.net> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113174439.1965168-1-gourry@gourry.net> References: <20250113174439.1965168-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Systems with hotplug may provide an advisement value on what the memblock size should be. Probe this value when the rest of the configuration values are considered. The new heuristic is as follows 1) set_memory_block_size_order value if already set (cmdline param) 2) minimum block size if memory is less than large block limit 3) if no hotplug advice: Max block size if system is bare-metal, otherwise use end of memory alignment. 4) if hotplug advice: lesser of advice and end of memory alignment. Convert to cpu_feature_enabled() while at it.[1] [1] https://lore.kernel.org/all/20241031103401.GBZyNdGQ-ZyXKyzC_z@fat_crate= .local/ Suggested-by: Borislav Petkov Suggested-by: David Hildenbrand Signed-off-by: Gregory Price Acked-by: David Hildenbrand Acked-by: Dave Hansen Acked-by: Mike Rapoport (Microsoft) Acked-by: Dan Williams Tested-by: Fan Ni Reviewed-by: Ira Weiny Suggested-by: Dan Williams Suggested-by: Ira Weiny --- arch/x86/mm/init_64.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 01ea7c6df303..58ace82874eb 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1462,16 +1462,21 @@ static unsigned long probe_memory_block_size(void) } =20 /* - * Use max block size to minimize overhead on bare metal, where - * alignment for memory hotplug isn't a concern. + * When hotplug alignment is not a concern, maximize blocksize + * to minimize overhead. Otherwise, align to the lesser of advice + * alignment and end of memory alignment. */ - if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) { + bz =3D memory_block_advised_max_size(); + if (!bz) { bz =3D MAX_BLOCK_SIZE; - goto done; + if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) + goto done; + } else { + bz =3D max(min(bz, MAX_BLOCK_SIZE), MIN_MEMORY_BLOCK_SIZE); } =20 /* Find the largest allowed block size that aligns to memory end */ - for (bz =3D MAX_BLOCK_SIZE; bz > MIN_MEMORY_BLOCK_SIZE; bz >>=3D 1) { + for (; bz > MIN_MEMORY_BLOCK_SIZE; bz >>=3D 1) { if (IS_ALIGNED(boot_mem_end, bz)) break; } --=20 2.47.1 From nobody Thu Dec 18 10:03:39 2025 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A3A51C2324 for ; Mon, 13 Jan 2025 17:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790297; cv=none; b=c78nPoFaoCLe3vX3/pSpo0yUM4DTgXZLruob6GKOLRCuGsjc5r7FuW4aEDEnU6cI1yioxqpHSG9Fv24rZCEQUb4jsi/X9rjzWi45epgq3KAUlfS8R+arPFGHgqi3KuyrGgmsu1K5/l9ZYbzpwjvgWuhvV6kC0QpJpn8wL0mlGB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736790297; c=relaxed/simple; bh=SitMIzrEMABnbqzeLxJFSLv+X+tguAv/sqKQ/L0nmKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WGYlrzp0o66VDKm43AkYooJm443i7KHOyUqLsgISrBlZ2MkBh/hj2YSmAJ39u8wynakgjYQ4f5LS9S+0kZ0tkCWo4ZySuOzi6Otqh5/a8untL0aDjuOyDQyHxYoz7EEsKBw8xfffh0RpRhm1zhdlbQTt1dk8iDa2sNCRbwW39RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=LNAylknn; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="LNAylknn" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7b6c3629816so260203785a.1 for ; Mon, 13 Jan 2025 09:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736790294; x=1737395094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yl2EwUT2VKVvGiWjqp0to7EI8yUq6Zt171XOZkuZj5A=; b=LNAylknnjFzNU9MVUCWp3UGc2ajCWX5qmD9y0ccgh2fX7Rfgs4g2D2PhiJXfSIIGnX 4ZV0fDcpJH9wS1pOws5mqBZdZ74hlkXPWVwSi4FuvVP/jWdWPv2AoPGnPSkLDgeBGmvf qyp7Fjk88zLExKFNhRoDTHWGJmNeiToG8GfU6wpBAWwTFJEzyBn7YlNg3/CmUEF8NbP+ g/Hl6nnHlbrCcP2EkuHCDFOMAo+0w8hmDmJDZb310vklVIRI0vklsNJvnQheJfy6ynai Bx/vaoZoT30X/GLzzHQEtvOQyCVpQSdSqhIb6EkKW8jwT7+HwxGvWx93iz26//dIZ19F 4Hlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736790294; x=1737395094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yl2EwUT2VKVvGiWjqp0to7EI8yUq6Zt171XOZkuZj5A=; b=FBRwmvaPGZoSBH20nmQQ/k/Xed5dVpMz3nCmzOVveegsWi41evT96WsWfKqzUwXu2i w5QZpw0J+JRDeXooaJUsozLDtFDqPO99PHzn7YcZGl9W5I70LvzUPXcCY58gtc5DOo7t bkN/uokNHL860ac7RV4Ekipkdv8HA1Acv2kHViQ7RHAorgYTmxkHVOrQ8Xr5eg/6CD19 ENgVLMIfYIE0H+J+zlYC4UW4QpjyQ43k8oQlVXve5XDQo3HWdQbNZ9rykYAAyFGfGKmv XKwTTKmWlN0lV0hd4a2Xkbg1fE+ugiGdtSUSDQ/CBFoe0AHkHcF09Vf96Xe14m0BdFZG qMbA== X-Forwarded-Encrypted: i=1; AJvYcCULBP0jXYqqa83q4u21L10SmuDK8lZ74r0aUx16YPmtqGoaXzC1Ds+bx/vnok0sMuYM7Z4AtyCHkHdUCzI=@vger.kernel.org X-Gm-Message-State: AOJu0YwHv+B7CBoeuyrKo4uW30MxzhehHPOOIMmnvodHw0yShMbgpRxu 12CcnwLuBHXHib0kiJNiwWOxtSzQBDamhfBHKERaXYkMWm/LMLB60ACvXGi9eas= X-Gm-Gg: ASbGnctm4uk+C4TsU44maH3Thoz5oIr/780gwya3PQIaLFlGFpBr4RUEvPCGIy0ULrc r7VZYLPcAbGg7dvcSodMrZn0LLQeUHNOFKrRcRpzJr+4l+gma0fbrqJXPgX9FZdISRyG5mDmahQ h2TpZRjcDV6isCqo4NzZfCQ4ovnd1ZcEmCuix8XB3ybGxViWAhjWVitlY+LUqSn1K62m3bL+Bpm ekg9nnE9Uagjn+qNkEahOWdCWNLcUrA5QR1zV28FhxSSgX5MLWbxExgCMeQhW81XRJZNAs4HX9W /3DXk976uVQu6piP2375LHViyLNBexWbT+2DMhe0sbkb X-Google-Smtp-Source: AGHT+IHjZNO++490q5I1chUVLoFtrxzaVQ8wh+7ZzlHK7PMYF+bXoOp6mvzhXoNAdBo9KngXvoeIQg== X-Received: by 2002:a05:620a:4095:b0:7b6:6b88:cc00 with SMTP id af79cd13be357-7bcd96e8d37mr3639424985a.5.1736790294598; Mon, 13 Jan 2025 09:44:54 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3248c80sm511214185a.49.2025.01.13.09.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 09:44:53 -0800 (PST) From: Gregory Price To: linux-mm@kvack.org, linux-acpi@vger.kernel.org Cc: kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, gourry@gourry.net, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Fan Ni Subject: [RESEND v7 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Date: Mon, 13 Jan 2025 12:44:39 -0500 Message-ID: <20250113174439.1965168-4-gourry@gourry.net> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113174439.1965168-1-gourry@gourry.net> References: <20250113174439.1965168-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Capacity is stranded when CFMWS regions are not aligned to block size. On x86, block size increases with capacity (2G blocks @ 64G capacity). Use CFMWS base/size to report memory block size alignment advice. Suggested-by: Dan Williams Signed-off-by: Gregory Price Acked-by: Mike Rapoport (Microsoft) Acked-by: David Hildenbrand Acked-by: Dan Williams Tested-by: Fan Ni Acked-by: Dave Hansen Acked-by: Rafael J. Wysocki Reviewed-by: Ira Weiny Suggested-by: David Hildenbrand Suggested-by: Ira Weiny --- drivers/acpi/numa/srat.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c index 59fffe34c9d0..7526119fe945 100644 --- a/drivers/acpi/numa/srat.c +++ b/drivers/acpi/numa/srat.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -425,13 +426,22 @@ static int __init acpi_parse_cfmws(union acpi_subtabl= e_headers *header, { struct acpi_cedt_cfmws *cfmws; int *fake_pxm =3D arg; - u64 start, end; + u64 start, end, align; int node; =20 cfmws =3D (struct acpi_cedt_cfmws *)header; start =3D cfmws->base_hpa; end =3D cfmws->base_hpa + cfmws->window_size; =20 + /* Align memblock size to CFMW regions if possible */ + align =3D 1UL << __ffs(start | end); + if (align >=3D SZ_256M) { + if (memory_block_advise_max_size(align) < 0) + pr_warn("CFMWS: memblock size advise failed\n"); + } else { + pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n"); + } + /* * The SRAT may have already described NUMA details for all, * or a portion of, this CFMWS HPA range. Extend the memblks --=20 2.47.1