From nobody Thu Dec 18 10:03:42 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2094.outbound.protection.outlook.com [40.107.220.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4BF1240233 for ; Mon, 13 Jan 2025 15:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.94 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782094; cv=fail; b=efB/MCc8/5cBosFeLnzxmr+H264Y5zFZ8yHdu87vQvmnX8+ZDwPWoHV3yh6Q0z2lsXKec7kRQCbkpiBl9AmnAZ6urSECDvjsvEY5dG6RPfKjYBy13R0X7Nkb5Vps+nJoGudYhQi2mZkL+OxxvFGKO4U1Db/A7+ylCic6p3VvlBs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782094; c=relaxed/simple; bh=FpjJSmi4r/y0SbUO5x7S4BLFYZPkqkrwkxT5dZ+7F68=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=g37mHwTE3kVx0bzuAijwKVUQX1bGAAcrv66EaqlP2Z33Xb5n9ltCGyfAZt06E9lM+RpySQfRnAoA41AHKiBXdrHlM1kCfOOcFi6dfF9CI4fCYVXt6xXN4DdPrL/cxTdrI3QoICHgnrbI6vnbT7bBpS+oG5vwraxG68sVfwBEu5Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com; spf=pass smtp.mailfrom=inmusicbrands.com; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b=U5XS0AZl; arc=fail smtp.client-ip=40.107.220.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b="U5XS0AZl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xHXgW84EEPtFTfhjq16unnvH1B4tj8rpEFXoPqVTKz+WyCTHx5eMvKZUUzdLY7es9dkGWWsPueni46lCXqEwLUl2e9RzgvrTg/6NzLpVbDHLMSh2bGbIbYFKWeyX+aj1AxLdArbe2H493lPRPTX6UXDRFWByHsO4ab0SQXYtvIrQLLoQ+SXZGezu+tCREmdGutMnhwWlA/67Oe8tY5KYfs3Nacw+SzVi474uHJN+Zs8qOyunYC3mqgPc3GQ4aRJ/40g7/2bYlLF8i8L+QsHjtZFaOTWeOp9FYOKdQyzDHOcWk9kvqlTHc1S5DyRAbJIu4wB+2K8RgplGcS91uZxEcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tsgt/pjIHXHX/3g25D/d6wzDbwkP6JsSbrSvcEOgSUY=; b=Qnc+nU4SnW41hMYkZDZpwwpO8ac4mBNSzRzc01cGCBOIl8/a0WOp4vsUZ7b5EFGYGcos+orFDB8X3AU0PM1ZU/DeEpV0Pom4xtsS55J2w2uvRcTwcGieVf+AUi947ZfWJDqENXeejFVbLRo0TewFLmwmN6jnH3kuC8MzHtxYiP84zmIQiRW6bSFTYEOA/U68uUUC2AzUR2x9+ab4aEL7ngMShrrsI4W19Vj/75ya3o8hh5gV0jrJ3AZbODAK1jMk3bG+6yRhrDnoycpXsPiyhQDF/VvTB7pv/o6oNeK+HRJo2ZIxfDjtXBx4wmeX8OskqiCVHDmYp0pp/lfI2OJHRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=inmusicbrands.com; dmarc=pass action=none header.from=inmusicbrands.com; dkim=pass header.d=inmusicbrands.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inmusicbrands.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tsgt/pjIHXHX/3g25D/d6wzDbwkP6JsSbrSvcEOgSUY=; b=U5XS0AZlVPuMwr7wstoVcgVl/zQWuXR/kjV7RW1ek5bZoD40w/5vTd07gxb9jF5IBXmqhkJYYpNDbCZ6HmnErqHWKf860GPY8mRA9kYo2UPU+vn9FbdBnvsb3Lrai9nrDAZpcnLutlyoGbqYHps6+VeemkOIMHggWtUjfMqLQ4M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=inmusicbrands.com; Received: from MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) by CH3PR08MB9065.namprd08.prod.outlook.com (2603:10b6:610:1c9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Mon, 13 Jan 2025 15:28:07 +0000 Received: from MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401]) by MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401%3]) with mapi id 15.20.8335.015; Mon, 13 Jan 2025 15:28:07 +0000 From: John Keeping To: Javier Martinez Canillas Cc: John Keeping , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] drm/ssd130x: Fix reset timing for ssd132x Date: Mon, 13 Jan 2025 15:27:49 +0000 Message-ID: <20250113152752.3369731-2-jkeeping@inmusicbrands.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> References: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO3P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::20) To MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR08MB8282:EE_|CH3PR08MB9065:EE_ X-MS-Office365-Filtering-Correlation-Id: e6fb6594-5004-41b1-e0b0-08dd33e6e171 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DK6erbnwaY0El1S7LaaL5Zu38irs7kCDch2Kw9YF+R+7Ul2gKtOHQBdufXOR?= =?us-ascii?Q?wNVIdEJ2ydG6tdVYhDYaYy29/K80hKBBg0db4NWocZkn16jrSXGoja5Ty2J6?= =?us-ascii?Q?nCdgVcAvYfFmwuDvGrNtJ1HE0Cv+WwBNeFVAmQZSaBQA6UAqoZsscw5bVblP?= =?us-ascii?Q?p4qkr9JUPVgH9Ek/f3uOEA0/6q/BFUSXXHtCa0ssVzTE5LdDDW88OqBmL7IL?= =?us-ascii?Q?En8xCux+AVu5+P/E4qDyv2UkPF1RnwPLGWOZk3jytsE7r7N+WvyU1VD47Pav?= =?us-ascii?Q?LJgCfVN3qGda51w0yBL5JEhIrx/YBxVZeJyVytxGzGA/SVBtiRHcWy3EJmPu?= =?us-ascii?Q?p+X96R/XRV/+xfJV3yn/h1VlnpkJtk9RBsNo/cxqq3MzAznS2wB/TpWcdraE?= =?us-ascii?Q?TUMz3ZlsAVfdznnIWahyu3bv64tu96utvHhBodO2i96oGC7Df2lmzhmQfXED?= =?us-ascii?Q?7/GhZRo7DXTI7QZFliuwb4aPNWc7STUFEpApzySgO/9YPo64rFEzPHrfeaze?= =?us-ascii?Q?S7mvBozW8EfmV+1gWW5QjTvVO6g2GeWmClCGBtFWF3w25Cmm7CmtQvojKloe?= =?us-ascii?Q?wPj/QGJPGJ1Iy1UKm4u/alh8vTY1CAW5lVWPoxYPqQPv2fAC7Ek5rYPwdOb5?= =?us-ascii?Q?M9kat8HKhmxMl2BGUr75ouz/mcVi+PCsuW1K9Nxk/wyt1EGixgSR4QGez8xd?= =?us-ascii?Q?LVJYYPytK1NLISS4kEwTM7dt2u7Ln6T5jw49vuQvMesKEMpQX8iyFNOHni5e?= =?us-ascii?Q?U2aotswnKFHiaO1BXfoCkqLWDv15tVyDiUkhXTfPS/ccM33TMjnHWwLaW9pB?= =?us-ascii?Q?LCfUJ2RQjmKGZmNGwMiL2ZKUgqcdXgrindBRUeNsQafUCpJMvnHxgcu4yg32?= =?us-ascii?Q?rsv3pajEzR10XdlN27QrtiHvHuaSv+R4CIsPuhi21fl4HOs0Gq9eOV3ZzZI9?= =?us-ascii?Q?6zOUAJHxv9BrzbZh19TSt6bHSo6wTtwuwggwtRA1ipyVIU6HJZLbPxXsWoF1?= =?us-ascii?Q?cCd54gz6VIIMvSvgVfOr6u12Y2iDSmJSjycqu1TTrPZbAs+UadYxCSwO0Q02?= =?us-ascii?Q?F2YtQ2LcuWBILwSz3toSltr4cxjSpJX7htIv19QxbruXIfXgHnRWOd7iJv6F?= =?us-ascii?Q?xVppYvbv2/KU+nli/HvZ2iu/Qmr3e6j8ARm7UKNjFPdQR0rUNmvRndrGb5Bs?= =?us-ascii?Q?fgXiv3hGrEfHjagtLXMZgjzcUFsmj1LuccE1G4XU/IGC8jord7TFX/3rAkDi?= =?us-ascii?Q?R3dIHxcjexPgwzZ1aLkq3KROiA0i5EU7oElXkFmC097qDkY7pjxP+RMZJKMj?= =?us-ascii?Q?9dGVYj6eXPaKYnOuWmXj+KtNR/JnXWMSn/guzGg/f6/4Jp2WKUapGqN3KT8C?= =?us-ascii?Q?+90JdDVNrgd4ipCZkdVIQC9ElsnlieE7rYiJOKYW64eIUr0WEyAxJ2QZfKqj?= =?us-ascii?Q?JbjOpP0TDBa1wEwxsiP5ZVV/Jp3LD7Vy?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR08MB8282.namprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+bQh10O1esLEWjLqnMUGDezU7ToG9qFt5MiuFUgOeNy8cpUmKeetZLSW59hI?= =?us-ascii?Q?jgpyKixHrTjAWQStcKx0PwzrgHP15jTteKL7XL5wND3/d3S0MWJ/iTZBq6Wa?= =?us-ascii?Q?2NCmzpCq6lWzMl5SMXIExJH0BPb6DNxb6F4hyhGbJGllMH0uClYuzan1kVRt?= =?us-ascii?Q?Lrrz5a+qYgEQHEtjUjmzq3BnP737Q46df/RphCPTK1rRaD6wU5mrVHpw2AZ5?= =?us-ascii?Q?8Za2xcJ7339M4Koymkid8bkzt0gH4RqhT4dpZBHKOmqtMB6tOp0SNKSOKgwl?= =?us-ascii?Q?pmTiYvrf8/IYMVimHRLrNLpLCN6/PcSTGNcsUlmppW7wa6sD18r9EjZ6psUi?= =?us-ascii?Q?n7g+BT6vOBkFmk2V/LNoGqfXa03Og0sJSNRyp7evxwRRwG7SdtlKYrerQzRP?= =?us-ascii?Q?ozWfBl6P4dlrEn1o0/wVYZMcD5+VZTstdC7hn8lYXnSha9kgVf3GKYae30NL?= =?us-ascii?Q?1NwsgO2/5ttLXiueqpHyb3ujVhTRL1FUM/C3kRTNhIngiQh3H6sT976cnsrr?= =?us-ascii?Q?fMMtcWAYC15dbJItn6hzkAhwCJit7UC/OpWrC8LEBrl7pjMZ96AVcslfpGfA?= =?us-ascii?Q?udcWiUI3S+CibXP6jwsyiT30r3WS7jfRn2VDbOwmgkvPLOQsRYoLDeUAIwXP?= =?us-ascii?Q?V/AXffF8d4T+fhepFqWYO6ZN8DjpRPad1c5ZpwwlbfUonUHSFlblxsTvjHnF?= =?us-ascii?Q?+B/hJbm578EkphOPz/QCvUFKhgZdZCtARTzX5YUKimSsyTpHf9BR2B32EJ2/?= =?us-ascii?Q?c5AV6gYxSuXZM/QqamHeAHyVgOwzzxCsOTSlYDGpkX+kTnjuD6ct8FivI/wy?= =?us-ascii?Q?MUsacUO3pLyDO09zV2XXTEq6JNUANZkqNuymCpvnjquAYHGS05MM2vNNgxbx?= =?us-ascii?Q?NDYvAhj4ygSEzc0iXls4pVJ/nwZVeT/yf9iyVHHTbbR0Kfm1JEr6iyJ8Jguh?= =?us-ascii?Q?prbgyLt3V05wpKmhEPSpLFVSRJXtive7hcY3GRJhCsdLXsmi/DoqD0ne6+CG?= =?us-ascii?Q?2oiW1zcz4/f+oy1ps6EVPcsRU3ttMTah3Bx3ZEXjrlERkJ8K2CjvlS4vNBca?= =?us-ascii?Q?NPuGqxaYE0XAWcnZ/Uc+2v9x3mZ2aLgmX1n4L9MVycOoUBhVmpL49j1xNLTV?= =?us-ascii?Q?SesRk8DtCnweLTk0cShyGMr1yH6JtsIVcSK7BxMsp/Mf1zOB6VvJgmw/s0EC?= =?us-ascii?Q?9rX9rzyP8xHMvTS+yzEfDhccJyCpYjegp3OMSqYmnmCAQWi69or9p5H/yNzJ?= =?us-ascii?Q?z1EzNhyphRxrMCRbf/06Z2nOkcKIriK3+5Hw3EVudnbALCAb9GrMrniqRKAN?= =?us-ascii?Q?b2DqjyA+Ik950bjIf5aBEd2oibHP1HFLnZnnXT/ACjsShoGDrY8oa67CHyPT?= =?us-ascii?Q?Qt9rV3eOPOoR4Ui3PPk7FN+2LHUfmDuWuRjduB/lHi/9tvRvgHr4PNZ0vzS6?= =?us-ascii?Q?tum3vX7Yl5Xg72JNCd3a4yZiatLb9tQI4u66uA+fcLqPb8gvjnUqxVxY+A4Z?= =?us-ascii?Q?/KI0TzqEecX4kU5fsl0niWz/6zIjcI45hvNEfz+ChHiMxxGDYN5vhLeyK0PX?= =?us-ascii?Q?YDqDgM12keguzJvdx821ZRTapaujVFFZ//yzDZTn5km832D5TLYJ2HZJfGEr?= =?us-ascii?Q?bQ=3D=3D?= X-OriginatorOrg: inmusicbrands.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6fb6594-5004-41b1-e0b0-08dd33e6e171 X-MS-Exchange-CrossTenant-AuthSource: MW4PR08MB8282.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2025 15:28:07.7138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 24507e43-fb7c-4b60-ab03-f78fafaf0a65 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NOtP2Xyi1U763F4PYOmVH0A9gZBvhQILuI9iZZF7AHIwAB+hcLHR/CtG167hx+iwtoMlwyVsBuRxFgE/h6qqLwdfceFtpGXGYBH0kBq7gx4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR08MB9065 Content-Type: text/plain; charset="utf-8" The ssd132x family of chips require the result pulse to be at least 100us in length. Increase the reset time to meet this requirement. Signed-off-by: John Keeping --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index b777690fd6607..2622172228361 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -363,7 +363,7 @@ static void ssd130x_reset(struct ssd130x_device *ssd130= x) =20 /* Reset the screen */ gpiod_set_value_cansleep(ssd130x->reset, 1); - udelay(4); + usleep_range(100, 1000); gpiod_set_value_cansleep(ssd130x->reset, 0); udelay(4); } --=20 2.47.1 From nobody Thu Dec 18 10:03:42 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2094.outbound.protection.outlook.com [40.107.220.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78FE31C5D58 for ; Mon, 13 Jan 2025 15:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.94 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782097; cv=fail; b=mzoR78tIEp357MVb5EL5oVomOdXfXIuBUvGRSS4TjgntI01KbWOMRbA6s/k2fV0Ac2cvdGP7eoXvdN0vuTSH+QL54YDQOpsYSi5qwTNvMkIoeZP6DBUDNBuONafCsXKx8scuwWnFCuzGSfOMBpsCRCQmXpFqEChcdlzzgTTkU+4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782097; c=relaxed/simple; bh=/9C63fSgIShhpXItvX6JGA5u9cYTgVPHitTU52hx5w0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=UboBrNmCNTKIW50aJOA9llpvgPM1JNEZgGUZvr1mCMNtn58xBEBfxWBdE8gU2XSliSm65vFTIdMnGK2zXro+dhGOL0wP9uTv7mlSgk9f1I9ce7T9cGYZ00LujEs73/vJB8KGggKcHblIXNUjhXL2oRUDlsLLhdIM11vWdRst04k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com; spf=pass smtp.mailfrom=inmusicbrands.com; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b=cTbdG2LS; arc=fail smtp.client-ip=40.107.220.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b="cTbdG2LS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p8b8kRkgIRGTc4i3gMO8UdI/STn4irVoAu40JA5i3VapYK9Xv3qgRqjSZ32SPRz30r60Y75vZ9kVcPrC2rxjOWDekS9UeLEV1A/oaIUUUqyKj2O77DY4x4GHkBfEkOF5q9G22WMLH8t+tIWuK5KhOtGMgpZvVJeHszcHxbGH8U0ZKBVREiEzA4IKYQXMYNf9lF1iQHhwtYPxTGqLtN6Wt0qsJNMh0Oerp6eFCIstAXOaxs+SycS0lcsAiFmQcte9b0Tbhckb0tQ/fE08EvmluksTMnNUPoydN8oP4vu3bXFDKYWP9qYGd+/p8UvtN9Y5JFX7ZeJpG4I62VRH2ALqKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r3JVBf06rT6OZJlPNsZPT+2+04Zi3Zhs3/v+TZCc6e4=; b=S3qt/UhtA9cGqQEux1qtGee9XVJ9zxHXtg0w+UbwKOiB6Xsr8SVa0s3bki20oiK7L5sc1E9ZA9LFg+UaMQyJa0fDURq23XjM76V78lJ7KBjQMhw0TsF99yJIsRYEcn/FMGlHQ3AETR2tZHuR+xZUqZOJLxyZA1YLtGuyRxM4kYKcIamiNZVRjRByXBU89PmvFfjb0bSutlzXNY0KP1xQLdNByFXyjhSsLfA0nh6k9MZXNna7Eai6MQs+UfGpb9NlKyo8Dqt3L4ZmbCeiIYZntm7VZtIzqPqZ0t93fdD+xz2pFpeAK4PCit3ujdrZKJFF+tTQSOwrdrhDp2/s4lQpiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=inmusicbrands.com; dmarc=pass action=none header.from=inmusicbrands.com; dkim=pass header.d=inmusicbrands.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inmusicbrands.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3JVBf06rT6OZJlPNsZPT+2+04Zi3Zhs3/v+TZCc6e4=; b=cTbdG2LSU6cP0QjJRnMu/IdDre528b2cNSE4PxafRQbIM3BSYRSqjaH/t9/Wsgt+I7v3SK8rdpR4yCXXgdnhejDTHnnVq5SAP7p9lo2rKYaJirVPI2+h/IgKsm8KmGQ6/Gr30w9MDUPYGuk25FAaWX142k2nhz9msunG618m4hE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=inmusicbrands.com; Received: from MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) by CH3PR08MB9065.namprd08.prod.outlook.com (2603:10b6:610:1c9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Mon, 13 Jan 2025 15:28:10 +0000 Received: from MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401]) by MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401%3]) with mapi id 15.20.8335.015; Mon, 13 Jan 2025 15:28:10 +0000 From: John Keeping To: Javier Martinez Canillas Cc: John Keeping , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] drm/ssd130x: fix ssd132x encoding Date: Mon, 13 Jan 2025 15:27:50 +0000 Message-ID: <20250113152752.3369731-3-jkeeping@inmusicbrands.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> References: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO3P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::20) To MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR08MB8282:EE_|CH3PR08MB9065:EE_ X-MS-Office365-Filtering-Correlation-Id: ea36fb3f-9650-4d2a-1c9c-08dd33e6e307 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9ltebddyMWGSv6asHPe715TDv3eoEW+vrarFWGZgeRSi8yZJiKu+EHvaWfte?= =?us-ascii?Q?PM7xAUYTYo76l9rpaGFJwXCPyTv+cTCzmIZCsB1GxDsOYjesQiqXmZhhXOih?= =?us-ascii?Q?hvvrcdUoUA8jorDp4OYuF4evs5D/OOBEnIE03HOz2TgpYMI1y4OWjS7jDYuy?= =?us-ascii?Q?CnByN/L0DMDPEnkS7JGDs+woRsj/SNsxROaUGeyVAR5wWiif/JEoTa9HN3xq?= =?us-ascii?Q?u2flF2H6f8KH3Z9gBFKOJ7ZMzZk1WUT9LzPL4UtD5dD2mUYhNdPrJSz7bgb7?= =?us-ascii?Q?D9MyXjARuOdhiYzv4fYKOl5ln0muP+sy0H/Wmq9dA17cGwXwEE2g6zpB5S27?= =?us-ascii?Q?aNYZKTY9f6yEfhx9NHPv9qXEdbRgcZR/7eTt1OwPv63lAcYNKtBYaZIhZfgG?= =?us-ascii?Q?zyCibXmYZ6V06a08hCyEGiFJNd6q3h4zL9sixWmuOUhT81Sl6zmNz5armRnx?= =?us-ascii?Q?0t7qt1c1g1YtyLkHFZLStGwBND0P8NXb0zEdtuTXTWeFgQzL26DD4ngrCMwI?= =?us-ascii?Q?zWcjs7nDvDM7IA1lJowmAPF7EjiDKBKH9Ag1CmD9WYbsd/LF2tUndLiMmF7t?= =?us-ascii?Q?8VjlYI6ZKJZ1in1NTHWlkNXcdEPODCwERDJbssx57qzoHMFbUCWxtLjxXETk?= =?us-ascii?Q?7Rsy3G3EQI7GUcuFpHY2gI7uP9+5okY2N+LWAzs/M3rCptaWPnrUfBbHg5KD?= =?us-ascii?Q?4QHM8ac5KAi9/LGK4SnaenE0jxs/+G3EumIg4MhfpwBdQIM2uvd6B2ULfbRh?= =?us-ascii?Q?60D1WSJUXX0u6rQeLol0pGdMc9CKIZclnZs4PTnNLYU6yCFmBoiwhIvB6gLB?= =?us-ascii?Q?Fu5EE9hks5EbmXlugiUnsWTJgFm03WLV7dX3tKFSg+eUYbKTrRh0MIM5wxWt?= =?us-ascii?Q?041DXdpglcQWU+f3hNMNcRNz63mZKGlJ/f8pR/+nh/g9VGqtRZk19oTYhNfh?= =?us-ascii?Q?8M7QECnDlv5EAMibTwnFlSpKxFXUAJbo9eZXtWifws5v9/09gMkm2+gut2on?= =?us-ascii?Q?sn76Pv8qnrJ/PJT7jhRQo//TIA98uwxG1KFRt5vhlAHf0XYdJy+5ns70WdfE?= =?us-ascii?Q?5XRaW3ErgXwqJDnPa6TXhTVqx22KVL1dH2cCnnPUN3ReGYlOpExq9HKUko2W?= =?us-ascii?Q?So//jOymrcjzcc0++O8SIn0yocaXOHaMh9h9XxyVzBZfdHksrt5NQefPqpif?= =?us-ascii?Q?TAmERXhSVWf3ZA10igXh7FBd3EY03bP3etftzMSNaQbnA02zs5Xx3SRbBGKf?= =?us-ascii?Q?Jy8gNubWcN75V6ir9MIfjCKuuAXkTbR/h44Lxa9JWwjEYk/Q5bK6NcOk+LGM?= =?us-ascii?Q?ReFj6n1K/4rqkfrGB8liumPe654up6kq2I+izhiW/Kl8oKqdQElgc9sRaHlW?= =?us-ascii?Q?IFMH1IQFhsK/lufTjFj6PKiRCGQUOzfNiFP10NSjAOuzHCUfTq6p18v6gI+U?= =?us-ascii?Q?OfMT1RUtHVerE95ZK0zw5DITXs40MJcc?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR08MB8282.namprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n/OZ1D3Hz9rcFegNEv0SjYK9D1p5pE9TW05KgFKW2MrlIYO6kvd9DKG4xRTu?= =?us-ascii?Q?8yAcRluUhQkukE2CSBPscisktSaF996NBPjcfwUlOekTT7H2LlV+E27UNMJe?= =?us-ascii?Q?lUpcQKFUGRXk61RH+m5trofxUrHhvqzRbx0Y10vFm2VmQuqXqNaN+g/JXa1X?= =?us-ascii?Q?cCkekXAE6+2wAU5Csx0mxZbBGlbpS5jQjozoqHdcAyLMpq6oJrAPZAQceg/H?= =?us-ascii?Q?OMNdUZxr404CRYtx6jNpVGDuep/84URwYFjPwyeahO9PcgZMBfNYeuj+nHho?= =?us-ascii?Q?/QUqOz9XUVW0Jw/PMytnXOGBwh3unzca0PG8IHkMbEHk8Up4of8wgweBq1Wd?= =?us-ascii?Q?4Hsk2m7XQa/4EpfwOyw+uCOLlUJFpq+jr+rkMWaJPJmPjIx10s5hhPC4ISxu?= =?us-ascii?Q?TEhSQAiVtcejlKdhsscQ9jfWKiBh2Ha9VCm5km6/56/3CIkh+lRWunqxrfD3?= =?us-ascii?Q?EVf990F9mqvYNL9u2Y+Qt6SGxYV/eW2JGxEhB7yuxnuCwRVURYKShJFP7Hhy?= =?us-ascii?Q?abfsv2s38hMHZsRYF1pmwbQhNuvtbJ8izNW5U+bT96RlLHw6MdBRm1Rr73HF?= =?us-ascii?Q?9lFFOKsaOifZafKRQIAh0EO//cFTvMNYbmH2OGDWVmdQl0pvgVeq5dXx06n8?= =?us-ascii?Q?mDP8ACVbnoEgTAyQMgoxj61G0XN14OjehxQlmf/Cge1mpiunAWtJfO3nusgL?= =?us-ascii?Q?0BgTuW0EDNywJXjloBMC9rSuPe2h4bJ/9eZ7TamcCf6yJGztyihI2meF3Yiv?= =?us-ascii?Q?EEqvI6puR02xad+4K6r5YjevONwi5amT/OBM2sQHaqVLYcmBMsernVkdAMlW?= =?us-ascii?Q?GNkfFUVLx//dZW9fhSlaQtcrFytI4uum7+WqIzWRBjCF3ST/p+xxa/z1HQq9?= =?us-ascii?Q?gozShFyNC+wGx3wrLRfVn0I+azT5E8/3seqoMwuBdk5nFkwPRdmU5CzxB/UH?= =?us-ascii?Q?sNbyLkF8l7kLdThCVLwcSKJKP3OVBXUnpN//WQHQXJJSU6lt+VnEjhal/Yuu?= =?us-ascii?Q?mqlHtH8aJais32TYwzxLS9ICePPaUt83OjdkFY0oG2dxPCPSZZu2TcQBIafT?= =?us-ascii?Q?feS1xwbLHIPqJ2KVNoCu9/2nVtdK1Znwbk7uplgD0qPd8xvo/fN5JRC9aJXm?= =?us-ascii?Q?fx6q2NZ74NIlc6cCiQsMnJM2VcU0PHASz/wHEKcFCPksOe54skk85FJjGlbQ?= =?us-ascii?Q?HMgYvyIhijryPXUy0LZZzBVHqY7VVaDBRg2XDHnmuoa/+jZSjTxobOyJQnhR?= =?us-ascii?Q?DjviSypuesH1SJLrVRKCrBS6MRyweTpd8dl5alYikOM5ADvYxX0cJZG7aylm?= =?us-ascii?Q?eIcXP/S6ktbBfH7B0Ks7twdMWby7N1eC5BfkZAHOkxiwlROdGthq7vIV3X4r?= =?us-ascii?Q?5YekGkFEvtAWKUGobzYTKB5PNWYMygPFWFS/hDoju8JYIEACj2naR3uGcG0g?= =?us-ascii?Q?B8mym0jagElQr1VxuTCXgHyUPLJFDl5TY0wY9t6IToK1z2j/pKN1fAatU4qD?= =?us-ascii?Q?8qIyZ5D9y3GNoDQN4fpgOf5+W/3XHrXojfiLbvhiQYYQXLskYQTAK7BY3Ah0?= =?us-ascii?Q?VRV7GhwYQ+O9KGxe1ObkVJZVCIfPrXhTqx98U4eoQxp7ay9cFSYzda1zfk5s?= =?us-ascii?Q?cA=3D=3D?= X-OriginatorOrg: inmusicbrands.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea36fb3f-9650-4d2a-1c9c-08dd33e6e307 X-MS-Exchange-CrossTenant-AuthSource: MW4PR08MB8282.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2025 15:28:10.3428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 24507e43-fb7c-4b60-ab03-f78fafaf0a65 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zip10aXRCHB3C8z4PJVOiW/+lE+k9u2GSypOGq35E8jep9o1nlULFGF8iNjC8qxBT+LbNtDVVnTGjj7eIvfRBu1noIbDQSI11/DbMoHD7vQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR08MB9065 Content-Type: text/plain; charset="utf-8" The ssd132x buffer is encoded one pixel per nibble, with two pixels in each byte. When encoding and 8-bit greyscale input, take the top 4-bits as the value and ensure the two pixels are distinct and do not overwrite each other. Signed-off-by: John Keeping Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 2622172228361..64f1123080996 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -880,7 +880,7 @@ static int ssd132x_update_rect(struct ssd130x_device *s= sd130x, u8 n1 =3D buf[i * width + j]; u8 n2 =3D buf[i * width + j + 1]; =20 - data_array[array_idx++] =3D (n2 << 4) | n1; + data_array[array_idx++] =3D (n2 & 0xf0) | (n1 >> 4); } } =20 --=20 2.47.1 From nobody Thu Dec 18 10:03:42 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2094.outbound.protection.outlook.com [40.107.220.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32AD81C5D7D for ; Mon, 13 Jan 2025 15:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.94 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782098; cv=fail; b=ENB2wUU0u32yZGR0LoV7j7pegDkYtyAx1nwsL5s2iBglyXUgjvrhm1ZFyw/3jCE3cr047Mb4R7Xqm09MIHgEIjngQZF9ayDrYuxDghfK0C8ImZE007xC8ErHq9i86xBwrJ33b3BkbQk8Ha+m5m6TUIfREpj7vEyrivBDUWLqioc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782098; c=relaxed/simple; bh=MDq7P97qkI0mrXm+IA7PHgMxgaH2qBRAGVV8MMNUDJw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=njm33x39XjlSukoYBoglL+7s662omjiv3kzjnxJOwPZzoyt50j/4BdPHyKxoLAnVjCxMPlVlbj7euUj+CgQcGD/LUeSt3q386zrYqciDXzINf229un/v4KhpiCBaAiA6PemgRn6XAtLU4yWxeiFUQPImWDXQtgHZDkanKs9yviI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com; spf=pass smtp.mailfrom=inmusicbrands.com; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b=bpnelLRd; arc=fail smtp.client-ip=40.107.220.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b="bpnelLRd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yd9mOUNjn7xulFbPh1jvwvVvVmGSlmEAS2XXiCdASVVT4VuU5lgs42/9N+aoA1wUVqaVPTFO6GOL5ZTjPTaTrbiWfVPj6Nw1/Rrl8kdbB5p8ehxeWVqLfgOzWrVO5WCagOsqvSnvXFOyKoZMWTmDhSbjhQWNLEJT1Ge+lfFW9idXXU1N5y3TVTuL/07CSCw88NneDBXNvi8qLmn7dRkburiNnNXn5NuzpuG4M6KIssFIYggO0HSqSIv/ZEwNp/Kh8KYCxJ3dCf5qiDTRygHkcAYi4ZsTncb+EnA25ZgJBaxxWzFwXczsGoy12raOqOe3oDeBwyGC01eb3jIDlP46kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U8oV6gs0Gn9i42Ohy+HtPGWy/FPOVrO/IdVHIU1gJM8=; b=X2mJnb2+Yppeu07u+K3bNTEdDQQBOvOpxnbqRj5AlhgjB7yMz85DbGL/luoSmtzdLZ8HkNjd15RDaQLNdwso32MxWYO3QQ/1FvKH4xcEHeZrh6TBuaCzaPK3UbQ+IvYD8gz97bQmTW3wHEZ1FnF6UVCWzjsv5bUqPdrNndtIxLDoRVLD/DwM0Znbd9vaDHLynfpVaEo4ohP77YxY6r3iC5vH3bWvVytGwa8ZRx/4zT2uN/xJEXK83d06KbSk64MF63bpwn4l50cUG/qWaUnJFH0J9X0Q80UjrADZoA/5sKKpS8YpKPetv1ebUKvDvvtCgrZEu5TDIfto6d9IrCqIKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=inmusicbrands.com; dmarc=pass action=none header.from=inmusicbrands.com; dkim=pass header.d=inmusicbrands.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inmusicbrands.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U8oV6gs0Gn9i42Ohy+HtPGWy/FPOVrO/IdVHIU1gJM8=; b=bpnelLRdEAti5tkKp/LC0ASRi9/fm3HIzWdvsVJhY6rf6vyFMi7JFr8xQhOGXTIuLARJTTUmUoIzFcjZJiwamJlHy66cUqqNn2Gwv4YLQkvhGDQf0T1oETEoCB9opQe0CXJaxz0fxGxqMtrm7usw/PdlaNGIWZsoXNjEH6+Wnio= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=inmusicbrands.com; Received: from MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) by CH3PR08MB9065.namprd08.prod.outlook.com (2603:10b6:610:1c9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Mon, 13 Jan 2025 15:28:12 +0000 Received: from MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401]) by MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401%3]) with mapi id 15.20.8335.015; Mon, 13 Jan 2025 15:28:12 +0000 From: John Keeping To: Javier Martinez Canillas Cc: John Keeping , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] drm/ssd130x: ensure ssd132x pitch is correct Date: Mon, 13 Jan 2025 15:27:51 +0000 Message-ID: <20250113152752.3369731-4-jkeeping@inmusicbrands.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> References: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO3P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::20) To MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR08MB8282:EE_|CH3PR08MB9065:EE_ X-MS-Office365-Filtering-Correlation-Id: f3d6f105-b322-483e-2f20-08dd33e6e444 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KQpB/zFhpH8hcSw+qvJ2yC3B3sxaNpJu4CAdK1xQA85ZHkYx4dyFMH8d0+HP?= =?us-ascii?Q?K6mu3Qa7NEsXnnC8F6zroOctMq84VB3rbRD+P+vmYIB/5PpUYXisYuGWebmx?= =?us-ascii?Q?oLGhMyM8onOXAl8kU/Ifgm6OLHKpIvfFzkfWVk+GC01LSsI0fuEs5Feup5Pu?= =?us-ascii?Q?VNgZH+BgGnCGE8TWyrgdW3zKiUb3mT+WEAnkHC5me/9zxTYFKVH9j1EUOTxy?= =?us-ascii?Q?gDErvhu8DA7aMVhuhXWYgWSYO8stK0B/jEeNnsOEaNQxVnWYB1QuSUTEJZW1?= =?us-ascii?Q?8VEViGHsLcEiAfVrccA+PtOlKINhNlvtYmBc4X5uB9+Deq0XMdcR2AeC6lmE?= =?us-ascii?Q?avQefGD9Kr+yDNqlG7ZeKGzOpEnwTpok7nQ/BjwWowQQYanC8t6fpq2VMnwv?= =?us-ascii?Q?Aey522ZoCzr0UaM2rGbYlt/ZzJ7rtGWES1c/vnux1vq4XQpl+w5iZaQnkXHg?= =?us-ascii?Q?MQwNs3lLRK1/V3fvc98UKBVps2uGwYqGm9ashR5PT1fi5Yt8PUniT7nZA9H1?= =?us-ascii?Q?QSweXwAh/+dKN2LgwpwNnJPkeB6Pmtdj8oXXoUcLpoE5FN6Lo8tT847TDXZg?= =?us-ascii?Q?lMb/IfyVuJEVflcnCCtySnA6a895IMi2nybYGhNPfmPtTrE2SKyjbsqMMrLr?= =?us-ascii?Q?VEEAFd+mJhOcXkVimLzRSqJnvLp/UNmIjxrV/lNm/7qmQ+VpRSsYKMjz+xeR?= =?us-ascii?Q?MTpXKHvTvMZLfr6ztv/SbBp1hG3xxdhRQ7F7Kr15D3cWECCmdJ7aObN2ahnu?= =?us-ascii?Q?xrNF89cf9Y09pSc8SYcLGO/D7YCuG4BYuaREcN1TbB2G1SzQLSGg+iR9vpU1?= =?us-ascii?Q?X1ZKYVUuHdbW6TDpOdW4L1Sneml0l3C0l5e+5lQfA6k/cl8WhJMdEfXFzm8S?= =?us-ascii?Q?9iWBQB/Eg3zOtvF4dO9NVgHvwgPNRyRSc1QskZxOejakRIbyZo/EUoeBTJhC?= =?us-ascii?Q?tFKVOS2WCOEdfiXJlqgq0QYlQVB4emIWj9OtTa5puKN3LKo1BRZ5numUNGvh?= =?us-ascii?Q?ALyQDoEar2LtkHMgq1A3hDsaVE1//Gp8XGoD7h/3gcpSxS8B9p4eZB5eCLYo?= =?us-ascii?Q?X6KTXuokidHbLI92EdKrAuh2g8PvdvXBsjhFkWBoV4f/nCPusN75hL61/biL?= =?us-ascii?Q?dGiFWVYjjLxvb8gdf3LYpS4qu2x3zwo46AjoNNyPEbHuTOu4LyhdhyXYlMWQ?= =?us-ascii?Q?qb79wCCgirTX//Q9oGFXE3Ajwi0H6BdGs1CpbGTAMWgMgsyDpN7lkLTKvO7s?= =?us-ascii?Q?BvbUKGxXNtWcFIcE++9bHxO4i7eNmJYpLISGzGaPcwRmo7zfK5V7fBz7/yVb?= =?us-ascii?Q?ulmyyqKbIjoQQP1RxZbjTdbQ1OBLCdGobTWGPf54G4ymPkJg+OQWbQtcDjaw?= =?us-ascii?Q?2y+XpnDVrcdxIxuI0/9u63eZN7ucwq3zQXp2aOoKPq0IUC3apXxY3/UOwSpR?= =?us-ascii?Q?cQKfs95eujn1NlZGZT4X8yv0YVKUGKX8?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR08MB8282.namprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LcTXT3BPM76oGgVOUFRu+IV1sk0t6NN0h2Yl5urPPaJo8zTW6MpT1VJCw7Hq?= =?us-ascii?Q?YQCZfiEaaALtnEO6fk79CM0IBTyRE7DVOM/eLCl0poI5Lo3akEVRcGDjMVGE?= =?us-ascii?Q?h5Ugwv81uGNtOfB3GfgBcLZT3usapx73AyT7mtDHb5iC/2QjNMmKFLAVoDQF?= =?us-ascii?Q?gBq1yOgxlVDFOsKBvNAq23nKWvWJevEr53c6XNCyfuoCx1vm3bZea0+1k5Ga?= =?us-ascii?Q?RJrCGnNa6wmO2xCxlmdg69nhaX6xfxq49ew4xLb+GonmSwqiKu5Ehq3idyT0?= =?us-ascii?Q?cpTylruHmfjrU6CfI9+m+gzrqC1VSdWJJGvWaCeCw8gtusLrNftiAOPCBeji?= =?us-ascii?Q?OBBVdndgJgTYeQBJK8/rvcE+KyBMJPUR4SsE7uUHMtgmA3YxWfg4NiH1N1ba?= =?us-ascii?Q?Xi0Th75khSz55ZXSDlXzloFtFXdwBAyF+IfxX71SzQRsV5VgNQll6MSjqfNE?= =?us-ascii?Q?+nZFgdCSdG4z1j3wUi8WK9tuYw80Yjsw50t4LmHVY8BCJ1HFUvrQBLyMpERU?= =?us-ascii?Q?DscVmO9P5KK0FA7I5rYB/vR5/jCSCVsX4vvJLnp/UnAfNzpyVAnnckhRur9c?= =?us-ascii?Q?N9qjdoQDlLv2RtxBA93f0Pmh9nzCcMTXZmURStpcpZEHQH0xetTKPvZ3eCGI?= =?us-ascii?Q?85Baa6sM1FQSpo/9VahwzpE4QnmB9Rd4fWoQ3iifC3ISiP79VaIQX5oeQQIL?= =?us-ascii?Q?kxoEbm2T04EuFvEq2tJT3s//jwvH1y2OHCIphNBJ9W2Yl52AJhCl1ZShZoki?= =?us-ascii?Q?5ukwY8W9EKxYkkeq28q6HtfBk6DqGaCM5UKez6uu2nwxP7Zjn5SV7eShPOr2?= =?us-ascii?Q?GN91Z9uQFhaahub7AkQGJT8fMouYVwSq3nRH0Qlka8tOcoiIvPyqszBH0ebR?= =?us-ascii?Q?UP08lEUuUlh4CJqFSU4KvJ/egQwH6DfUX2VMcycsPoE/CgUTvJdS/ZY4Bv1w?= =?us-ascii?Q?nkdYugAJL1GNwBxiPuoKWFI/rP5YmN/Kzn2zP1ZGEuq+LHh6UJbexJAqPatd?= =?us-ascii?Q?zfRJ6uW4uJwWB3jdK4H49fmfz0Qf92Vlz+/VCzkthw2lRVx8TR9onnE7CvGP?= =?us-ascii?Q?eqKDCMeXmzb4p0A62yiJ7w1vUT+YvbSAHUHm2PJ3f3t6xBqzlKMoyueA6P25?= =?us-ascii?Q?dT9X0wRyIi1M3dHReRKudESgVJ3LhJr23pOZKHJBqtOLBGPxLDftN8UWlQvb?= =?us-ascii?Q?tpHQ9AZ5Hz8+RZAUwKaVeAQ0CxrA9tOKyIhGCl2r/64UIAXN0Ir5f6hLqalq?= =?us-ascii?Q?9KdWvFesqSJcT4DwcbsZ5khDH/Atr6+oJgf1ppKG0YhFik0124KCOhzjPNOG?= =?us-ascii?Q?vSV/SGBbY9OpZnkr7eYsuI0xRbm4svsXpKykxLfCS/3NO7+MErQQi91Dj3C0?= =?us-ascii?Q?pkijpCSkbrbRLT7D7dmFV/zR07BlhypFH5qykz17Vh7qLmbWQyu/IvGHQM/y?= =?us-ascii?Q?ae3i19uV5/pgtiOnpjbMKWIQc0+JSuYYa99c5vYdQ2z6qmNbaj0XdUEb7ink?= =?us-ascii?Q?Y6k6RYexxO+14ieoOyLUZayOw5fBKfFdgh0Fi5fr1dBt2M6sGAvL71ygWiDA?= =?us-ascii?Q?zFzZ5G0nDOq2mKeoTkmO7Almtga00wASN0QpmRR04Dkq9gncgHCmOJAOdFWX?= =?us-ascii?Q?PA=3D=3D?= X-OriginatorOrg: inmusicbrands.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3d6f105-b322-483e-2f20-08dd33e6e444 X-MS-Exchange-CrossTenant-AuthSource: MW4PR08MB8282.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2025 15:28:12.4532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 24507e43-fb7c-4b60-ab03-f78fafaf0a65 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HOMvMiF+T9FzPRWcd64kILYGzRUhU+QQSnJepwFlx6GuhDanUH4dwbg8KTxVr0vWd1xXCyn/zVjrM2riR3mXOnL2fCzAZ3ml/dqyTTR5tgo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR08MB9065 Content-Type: text/plain; charset="utf-8" The bounding rectangle is adjusted to ensure it aligns to SSD132X_SEGMENT_WIDTH, which may adjust the pitch. Calcuate the pitch after alighting the left and right edge. Signed-off-by: John Keeping Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 64f1123080996..38f31c3624062 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1037,7 +1037,7 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffe= r *fb, struct drm_format_conv_state *fmtcnv_state) { struct ssd130x_device *ssd130x =3D drm_to_ssd130x(fb->dev); - unsigned int dst_pitch =3D drm_rect_width(rect); + unsigned int dst_pitch; struct iosys_map dst; int ret =3D 0; =20 @@ -1046,6 +1046,8 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffe= r *fb, rect->x2 =3D min_t(unsigned int, round_up(rect->x2, SSD132X_SEGMENT_WIDTH= ), ssd130x->width); =20 + dst_pitch =3D drm_rect_width(rect); + ret =3D drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE); if (ret) return ret; --=20 2.47.1