From nobody Thu Dec 18 20:36:38 2025 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 860DF22F847 for ; Mon, 13 Jan 2025 15:09:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736780993; cv=none; b=e+ym3hHsJ43oamiG4jjV5z6PrFeuW3VyyoYNHeZTby98t0mrtOjhQxVI4Pb+XGVgiEY9idL03D5UwHNHpFSH/gLbqmrcSrma88lZt2UFhS+q6UUfZ5wpUOfwDJhMsBRIRurJ8T1TEV23loQj9ZPNsKXZBjNIiyz1/uUFfg8jaq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736780993; c=relaxed/simple; bh=svpsi6G/323ku0y6vvG5MDIhfh6VxvDJC0PYBDJt5gs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AJNk8x52kf4S4bhifFZ0NeuKm3xaTGx499h9IqjQ24NN04XRqHXY+33+tXgz+fFjp5MZffR61UdLZaxxEzMl4GpDUe9yWwszp6A54wjvqGbxawenBbM9/+V/hFe4VJEsEzKrA1UGsBhFTTZ44yfNA3MZ8ADyxNjYkG5dilwhRcE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=T7jk1RJs; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="T7jk1RJs" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2f43da61ba9so5839186a91.2 for ; Mon, 13 Jan 2025 07:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736780991; x=1737385791; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6tAG6GJW3MF21Mh57oZZANqeC7wGfZvAtMDVyVUp1HU=; b=T7jk1RJsd8gEF2868qah6uEa0Gbq2K1jj7lJ7pMzk/iPpXJsdL3Kcoz+QguvRq+VI6 PqfAasQPpdYVc4E5b/HiAS8VRHNDShj0ojf/PJV5DzNfflcC7FRbq/5vGmaDaimzn137 HsKhoOUXDHaHSFehobAqkl5Lqn3ewK4x/PnjawmOQDT7hCeKBRiWVksPvxsDxZUPQD6v jz91rGyV7wJiqze5WwAUMlRvlgqQs8Ez349kqMRgfOO55903cK5lpZd0a/hJCHo661Xd kviQwbnsPtGB1V7XlTckcvobgcevmwfFHKvSirnxJG1i7e9na98Np7fUPNrce55BPunn QI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736780991; x=1737385791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6tAG6GJW3MF21Mh57oZZANqeC7wGfZvAtMDVyVUp1HU=; b=WkB4HUyy3oyEKrhCft1llc/2BHmK5GjWeHi0gzeZEGamrYz8pX29xG4oHBK3b+GPzM YNET1fyRsL8eW5a0OMNJ6bytkprzDlcJWHS8RC50G3JobDPfQuSlgy/VMOACpmeTTl7H VIgGYhT/8IT4FWuDptfjQ3vFkYR5IbMPCU2hurY1jAIJIfNh2Yxrny6gq+XVXnguDMXf /L0Q5GgVC/J1GJOKDJNvJehSNuUDurDu5Bzha01nRH4QQADDmHkO1NLDZu292JeV6CpH UxxGASmVgHd04ZGSCmixC7uuwPBDuEWh0LDlBmt76CYdc+t33V9iR+Q1FEi978X3glY2 0myw== X-Forwarded-Encrypted: i=1; AJvYcCV+4OMJWOivz83GkgS49ZQcaSH1GPONBoltd2HLGxMRCxn5K6e87oe5nikpM1nx7wAq6FoPJQqXE6Q/XiE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt8fdE2luJmHK+YFcVeMTdB8mLZWbLUrnendk+eW9llwV8vCCr 6+t6gu10ldBFZNggEg9Q1Fk7jfjB0xWfBBir/SWwuafuDzpUAqes/tGu8RtxAEHjuINEtfV1Den K0ZY= X-Gm-Gg: ASbGncvni9baietgWH1p337+vxHSupEtp5gXSB15G3Mnz0qKhxgHXAdq7+gDu+ZczIQ tXUDx4KlCKLALWC+tYedSITptKc2XNc8DLHvprdFG9oS3ZmT8XfELPfhTDPqQnK6BI6onnemOLh ooedkMsiiRura5Dc74DJYOE5YbvMyrIsFmWlF/VmgA196CcsoAAku1W5I/x20FGDpYppmpbSabM vmEqao3jVqO5EP+YjsN26egRFyzIsD8Af4cf3eJiTGsAJ0CXQt9zDY2spg32nCj7lQ5FKUqmzt4 u6YUM4z+Tfx3/4wEFtnRaK/Fe1ywtxirt5YhGzs= X-Google-Smtp-Source: AGHT+IGkg/B5xoLgr4lXkJUxodnWnKzHEdv4YVq9gdKarJbd4P8kwx5YFz8lMmYv1IPj3sNvze9Thw== X-Received: by 2002:a17:90b:3bc3:b0:2ee:d024:e4e2 with SMTP id 98e67ed59e1d1-2f548f0feffmr32200664a91.7.1736780990816; Mon, 13 Jan 2025 07:09:50 -0800 (PST) Received: from J9GPGXL7NT.bytedance.net ([61.213.176.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f54a26ae2fsm10193120a91.9.2025.01.13.07.09.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Jan 2025 07:09:50 -0800 (PST) From: Xu Lu To: daniel.lezcano@linaro.org, tglx@linutronix.de, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com Cc: lihangjing@bytedance.com, xieyongji@bytedance.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Xu Lu Subject: [PATCH 2/5] irqchip/riscv-imsic: Add a threshold to ext irq handling times Date: Mon, 13 Jan 2025 23:09:30 +0800 Message-Id: <20250113150933.65121-3-luxu.kernel@bytedance.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250113150933.65121-1-luxu.kernel@bytedance.com> References: <20250113150933.65121-1-luxu.kernel@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" RISC-V's external irq has higher priority than software irq, timer irq and pmu overflow irq. In existing implementation of IMSIC driver, If external irqs keep arriving within a certain period of time, no other interrupt will get a chance to be handled. This commit solves this problem by introducing a threshold to the number of times imsic interrupts can be processed in each round. Signed-off-by: Xu Lu --- drivers/irqchip/irq-riscv-imsic-early.c | 31 ++++++++++++++----------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/irqchip/irq-riscv-imsic-early.c b/drivers/irqchip/irq-= riscv-imsic-early.c index c5c2e6929a2f..63097f2bbadf 100644 --- a/drivers/irqchip/irq-riscv-imsic-early.c +++ b/drivers/irqchip/irq-riscv-imsic-early.c @@ -20,6 +20,8 @@ =20 #include "irq-riscv-imsic-state.h" =20 +#define IMSIC_HANDLE_THRESHOLD 20 + static int imsic_parent_irq; =20 #ifdef CONFIG_SMP @@ -76,6 +78,7 @@ static void imsic_handle_irq(struct irq_desc *desc) int err, cpu =3D smp_processor_id(); struct imsic_vector *vec; unsigned long local_id; + unsigned int handled =3D 0; =20 chained_irq_enter(chip, desc); =20 @@ -85,21 +88,23 @@ static void imsic_handle_irq(struct irq_desc *desc) if (local_id =3D=3D IMSIC_IPI_ID) { if (IS_ENABLED(CONFIG_SMP)) ipi_mux_process(); - continue; - } - - if (unlikely(!imsic->base_domain)) - continue; - - vec =3D imsic_vector_from_local_id(cpu, local_id); - if (!vec) { - pr_warn_ratelimited("vector not found for local ID 0x%lx\n", local_id); - continue; + } else if (likely(imsic->base_domain)) { + vec =3D imsic_vector_from_local_id(cpu, local_id); + + if (unlikely(!vec)) + pr_warn_ratelimited("vector not found for local ID 0x%lx\n", + local_id); + else { + err =3D generic_handle_domain_irq(imsic->base_domain, vec->hwirq); + + if (unlikely(err)) + pr_warn_ratelimited("hwirq 0x%x mapping not found\n", + vec->hwirq); + } } =20 - err =3D generic_handle_domain_irq(imsic->base_domain, vec->hwirq); - if (unlikely(err)) - pr_warn_ratelimited("hwirq 0x%x mapping not found\n", vec->hwirq); + if (handled++ >=3D IMSIC_HANDLE_THRESHOLD) + break; } =20 chained_irq_exit(chip, desc); --=20 2.20.1