From nobody Thu Dec 18 20:41:31 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B099520F066; Mon, 13 Jan 2025 14:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736780003; cv=none; b=Wc/8PlnI0zvfzbpACWRW+VzyDIFS+N85p5f8FdP8C+gLuQKNVMGt+vZPPGtasvtPhEypFJTJ7uass9aArxYjCx+QsYRax/Ie8CTV4qYuoppmVFiMYh/YBMeygytQtUcHdKG3tm6u6grOykQMSKpchK07iCW1Xxx1mqOPEARalT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736780003; c=relaxed/simple; bh=lpu3fq6y4OeyvvRDRzBGh41kTIwgycVL+HU/+dI1B6k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e0zgV5mPkyPycasHxdFaXbE5rOez3YrrQCobq1MDAUIIKgn5N+2CcGcjRSrm70F9CRl+cUhIDGBNOJA18t5x4DZwxcLk/UFkkeaFYK8epaBw2ScDQnQGnTasqnYiM8uk+lvkXZTsBVnX1QsFA/ddl4x2Zo+jcPuxbxsAgcKzjGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Yec7eTHM; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Yec7eTHM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736779999; bh=lpu3fq6y4OeyvvRDRzBGh41kTIwgycVL+HU/+dI1B6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yec7eTHMsY7/QAj6Nqyz84LQqPAUnRCDHzlPoLNHdk5DbazNkyrvEDdVEMGs8w5rV QJ/CWib3A+QuTM9caLESRzhzCaK1Y2XiX+cpQZUcntPmFjLLzUMSFMU1B56Go2paU6 eR223mSBVcYq/jwkBYBsxGlYcsBdSwEV4RuX2dg0y/dBQm2ruqS8orzsNt6EIEXpRt R6OrX3QltP//ozGyVt1K1wmCkVYwadW9TJyrBdIirFKFfePeQY6J9G7aPHTblir+sG OQc2gzmiUjhjhvsQJ9SE+GT5osg6fOzlu1ehc9GMgsgYXLCFShkGhKlBAyZUbLwW+b FmEeTUXgrzOeg== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id A78F617E0F9F; Mon, 13 Jan 2025 15:53:17 +0100 (CET) From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, jie.qiu@mediatek.com, junzhi.zhao@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, dmitry.baryshkov@linaro.org, lewis.liao@mediatek.com, ives.chenjh@mediatek.com, tommyyl.chen@mediatek.com, jason-jh.lin@mediatek.com Subject: [PATCH v5 28/34] drm/mediatek: mtk_hdmi: Improve mtk_hdmi_get_all_clk() flexibility Date: Mon, 13 Jan 2025 15:52:26 +0100 Message-ID: <20250113145232.227674-29-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250113145232.227674-1-angelogioacchino.delregno@collabora.com> References: <20250113145232.227674-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for splitting common bits of this driver and for introducing a new version of the MediaTek HDMI Encoder IP, improve the flexibility of function mtk_hdmi_get_all_clk() by adding a pointer to the clock names array and size of it to its parameters. Also change the array of struct clock pointers in the mtk_hdmi structure to be dynamically allocated, and allocate it in probe. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek= /mtk_hdmi.c index c5431f160fe4..138c6283c038 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -159,7 +159,7 @@ struct mtk_hdmi { struct phy *phy; struct device *cec_dev; struct i2c_adapter *ddc_adpt; - struct clk *clk[MTK_HDMI_CLK_COUNT]; + struct clk **clk; struct drm_display_mode mode; bool dvi_mode; struct regmap *sys_regmap; @@ -1072,17 +1072,18 @@ static const char * const mtk_hdmi_clk_names[MTK_HD= MI_CLK_COUNT] =3D { [MTK_HDMI_CLK_AUD_SPDIF] =3D "spdif", }; =20 -static int mtk_hdmi_get_all_clk(struct mtk_hdmi *hdmi, - struct device_node *np) +static int mtk_hdmi_get_all_clk(struct mtk_hdmi *hdmi, struct device_node = *np, + const char * const *clock_names, size_t num_clocks) { int i; =20 - for (i =3D 0; i < ARRAY_SIZE(mtk_hdmi_clk_names); i++) { - hdmi->clk[i] =3D of_clk_get_by_name(np, - mtk_hdmi_clk_names[i]); + for (i =3D 0; i < num_clocks; i++) { + hdmi->clk[i] =3D of_clk_get_by_name(np, clock_names[i]); + if (IS_ERR(hdmi->clk[i])) return PTR_ERR(hdmi->clk[i]); } + return 0; } =20 @@ -1381,15 +1382,15 @@ static int mtk_hdmi_get_cec_dev(struct mtk_hdmi *hd= mi, struct device *dev, struc return 0; } =20 -static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, - struct platform_device *pdev) +static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, struct platform_= device *pdev, + const char * const *clk_names, size_t num_clocks) { struct device *dev =3D &pdev->dev; struct device_node *np =3D dev->of_node; struct device_node *remote, *i2c_np; int ret; =20 - ret =3D mtk_hdmi_get_all_clk(hdmi, np); + ret =3D mtk_hdmi_get_all_clk(hdmi, np, clk_names, num_clocks); if (ret) return dev_err_probe(dev, ret, "Failed to get clocks\n"); =20 @@ -1638,6 +1639,7 @@ static int mtk_hdmi_probe(struct platform_device *pde= v) { struct mtk_hdmi *hdmi; struct device *dev =3D &pdev->dev; + const int num_clocks =3D MTK_HDMI_CLK_COUNT; int ret; =20 hdmi =3D devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL); @@ -1647,7 +1649,11 @@ static int mtk_hdmi_probe(struct platform_device *pd= ev) hdmi->dev =3D dev; hdmi->conf =3D of_device_get_match_data(dev); =20 - ret =3D mtk_hdmi_dt_parse_pdata(hdmi, pdev); + hdmi->clk =3D devm_kcalloc(dev, num_clocks, sizeof(*hdmi->clk), GFP_KERNE= L); + if (!hdmi->clk) + return -ENOMEM; + + ret =3D mtk_hdmi_dt_parse_pdata(hdmi, pdev, mtk_hdmi_clk_names, num_clock= s); if (ret) return ret; =20 --=20 2.47.0