From nobody Thu Dec 18 20:41:37 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099AF28EC64; Mon, 13 Jan 2025 14:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736779997; cv=none; b=NTNR9PynjRqWVaZ5vBNXCnDYq9Q15e0mZAwW4PbEcDFCxT9IkvGAmAQHnFkt4VSoYkMMRXDJJU8f+vIXJ7DWvi372Fs/E8p0brDUW3DBclPjnVpUly4toTi8Jib6qmexVpAMwAS9bIPamD327XN9kOJhCfkVkgGo+q019Pj6uaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736779997; c=relaxed/simple; bh=9kOtEXm03vIhlFmSQDgGMXPOuJMWf8LRw+vSYi8aVAI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lKAMleioVaItKZ+lbXAhLJnY81paweWpjvdd6lvOe0VaAOZyVmXJ9SwrJHFUvLIGNrn5sESbuPTXUpqVW/vFwwvzpc2mDoGnQ6A4a3t5QJRs/0jKKCfeC+xBBETnf56iU17esO2+BTW4UmgvS/dUyzViO6r1fZggJiu/KEFi99Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=l696MmhD; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="l696MmhD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736779994; bh=9kOtEXm03vIhlFmSQDgGMXPOuJMWf8LRw+vSYi8aVAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l696MmhDOHVIc1f0wyA3kisSNyrx+LcNSbByqHTDSkOda+56WD+lfuXNKQxopXepw R2wIYE3xqWB0z0INpBRBXpZ5fzd3Hq2gbg9N9DYW/lDO0PsHrhqOiOPUzmivL4GX8k KdtBhYg5BcBlt2AKTrUgR91pHpFslcOe73olW/aRwCjuv5R5/RZjfSEqEyvzbaTVMO zaYBhzs67edGvFtH6UM+pc86GT6xFrpo/U8aFrqyFOhMVhG8lauCbZWrTOOjVtPAIJ T4iKdGxNih1/xvqt4jVNgF4mo1vSbMzU16jtjg8ER4o81vOLwO3N8/L5onCZYL11Mc tjgVSF7+bZ88w== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3CAD717E0F6B; Mon, 13 Jan 2025 15:53:13 +0100 (CET) From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, jie.qiu@mediatek.com, junzhi.zhao@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, dmitry.baryshkov@linaro.org, lewis.liao@mediatek.com, ives.chenjh@mediatek.com, tommyyl.chen@mediatek.com, jason-jh.lin@mediatek.com Subject: [PATCH v5 25/34] drm/mediatek: mtk_hdmi: Remove ifdef for CONFIG_PM_SLEEP Date: Mon, 13 Jan 2025 15:52:23 +0100 Message-ID: <20250113145232.227674-26-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250113145232.227674-1-angelogioacchino.delregno@collabora.com> References: <20250113145232.227674-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since the SIMPLE_DEV_PM_OPS macro and the pm pointer are anyway defined when CONFIG_PM_SLEEP is not set, remove the ifdef for it and indicate that the mtk_hdmi_{remove,suspend} functions may be unused (as they are, in case PM support is not built-in). While at it, to improve readability, also compress the SIMPLE_DEV_PM_OPS declaration as it even fits in less than 80 columns. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek= /mtk_hdmi.c index 0ec3bfe528f8..f6b463aaba47 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1692,8 +1692,7 @@ static void mtk_hdmi_remove(struct platform_device *p= dev) mtk_hdmi_clk_disable_audio(hdmi); } =20 -#ifdef CONFIG_PM_SLEEP -static int mtk_hdmi_suspend(struct device *dev) +static __maybe_unused int mtk_hdmi_suspend(struct device *dev) { struct mtk_hdmi *hdmi =3D dev_get_drvdata(dev); =20 @@ -1702,7 +1701,7 @@ static int mtk_hdmi_suspend(struct device *dev) return 0; } =20 -static int mtk_hdmi_resume(struct device *dev) +static __maybe_unused int mtk_hdmi_resume(struct device *dev) { struct mtk_hdmi *hdmi =3D dev_get_drvdata(dev); int ret =3D 0; @@ -1715,9 +1714,8 @@ static int mtk_hdmi_resume(struct device *dev) =20 return 0; } -#endif -static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, - mtk_hdmi_suspend, mtk_hdmi_resume); + +static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resum= e); =20 static const struct mtk_hdmi_conf mtk_hdmi_conf_mt2701 =3D { .tz_disabled =3D true, --=20 2.47.0