From nobody Thu Dec 18 20:41:31 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 872EF284A5E; Mon, 13 Jan 2025 14:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736779996; cv=none; b=ewKu7U1dg+esECmXnzQfsPGow4+4yiFn9lWDt+4DfVM+FxhmhOk1uHZ8cgjk8QdrwGxuYkbE2sgt/2ZfsoT7Nr5xgulnzVW+46rkx8PerGe5YkLPrutyQSGmUWrNWdoTjlUonFdlp4WbrKgKxI0hRteijUUwen3B9nHtYnBkynQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736779996; c=relaxed/simple; bh=RNWJUSizF5rQD/eeXWuW2FSlygMlwq9QCxXSRVJ6M6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kC8s6VC0L7z+B+sZGhFvJIbf7ClAc5de2LuaQbqPso0sgrGNZSM4G0NcN1d1dpGdLqYP+t9jvmm9vzmv30cuLgZg8HR28xRXAGZupEyhdbCjRpAqWM2R9NgeTTa7B01SjZlmEIPGkFkUh8rscNvDFlmmz9mbONjZlsk/lvlUMK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=UjLyGuAE; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="UjLyGuAE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736779993; bh=RNWJUSizF5rQD/eeXWuW2FSlygMlwq9QCxXSRVJ6M6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UjLyGuAEbsdQHXS8SzIRMg6R8q4+jE3pS3Dm2g4afswy25FMIbZqRppejEx7baq6D VVI6vNJwmRhEiqOeUzb8xesXYaZYK/G6NuQntvb3mIRig58hrM6Meux0HQgo4nrRWl bZDrx7TNYWk1T+d6Su5u/F6VythxFBhjKp+HOU3nioVHlvZ/K4P+nymMcQ0BzbkAin YZUJdT7Yz4YGg/1JwghFKwJ6etkai1JsAztXj7ZXUu9haOihRoROgUgls+gfGX1wur RHAN8kJuvuM5idqBFEG3VZUzu/kDWFNoR44WYxK0oErwFkYqGRXwyxWTAI4w91mMyN B7r8nQtZ4pFcQ== Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id BC78E17E0D9D; Mon, 13 Jan 2025 15:53:11 +0100 (CET) From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, jitao.shi@mediatek.com, jie.qiu@mediatek.com, junzhi.zhao@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, dmitry.baryshkov@linaro.org, lewis.liao@mediatek.com, ives.chenjh@mediatek.com, tommyyl.chen@mediatek.com, jason-jh.lin@mediatek.com Subject: [PATCH v5 24/34] drm/mediatek: mtk_hdmi: Use devm managed version of drm_bridge_add Date: Mon, 13 Jan 2025 15:52:22 +0100 Message-ID: <20250113145232.227674-25-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250113145232.227674-1-angelogioacchino.delregno@collabora.com> References: <20250113145232.227674-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify the probe/remove functions by using devm_drm_bridge_add() as now there is no more need to manually remove the bridge. Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek= /mtk_hdmi.c index 4345c91e92e7..0ec3bfe528f8 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1672,14 +1672,15 @@ static int mtk_hdmi_probe(struct platform_device *p= dev) hdmi->bridge.type =3D DRM_MODE_CONNECTOR_HDMIA; hdmi->bridge.vendor =3D "MediaTek"; hdmi->bridge.product =3D "On-Chip HDMI"; - drm_bridge_add(&hdmi->bridge); + + ret =3D devm_drm_bridge_add(dev, &hdmi->bridge); + if (ret) + return dev_err_probe(dev, ret, "Failed to add bridge\n"); =20 ret =3D mtk_hdmi_clk_enable_audio(hdmi); - if (ret) { - drm_bridge_remove(&hdmi->bridge); + if (ret) return dev_err_probe(dev, ret, "Failed to enable audio clocks\n"); - } =20 return 0; } @@ -1688,7 +1689,6 @@ static void mtk_hdmi_remove(struct platform_device *p= dev) { struct mtk_hdmi *hdmi =3D platform_get_drvdata(pdev); =20 - drm_bridge_remove(&hdmi->bridge); mtk_hdmi_clk_disable_audio(hdmi); } =20 --=20 2.47.0