From nobody Sat Feb 7 15:40:19 2026 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 143FB522F for ; Sun, 12 Jan 2025 01:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736644859; cv=none; b=shUtk6+0PxF/2Gdd0bdM34l8IMCgYev+jkq5gt2DBwlBM+TyCF6qOG/R4sDegKx+/q8AYmZ8U/njZk7IDmAJ/MaNDVhD755zeKW3ZdXtl/77BaqFpfWqTD6ZCV2AOXf1j6k34hOLjiFr2sv+ZfYeO+e18phBWEI/4jwCmueaxf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736644859; c=relaxed/simple; bh=VdTmlW4LiMCnoB+8jO/9KlMONycSbWE1kWAWEi+kKoc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=s3f6ps4r2h3ooyPWpER66uVb3JjHBgPXi12MWnnoexRANkfPvVM1dqmCQatI4GiiILC8uMaVuOcvKuBsT1WWkHOx2Z/TCKJhJA5bJwXZxyWjJztG5tuzVAFYUZiXlr9cY71r1yORThxsr7mNzH/dPJpCLF2aLeGvwjoNB61oTjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=Drh+ptzz; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="Drh+ptzz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=X2Q9I2GWhO5Ck5EdBlh8PgJHpHNeUDvasJu1b1ghGQY=; b=Drh+ptzze/twUexF AJeJQhkY/JO32pnsx+w6C2SMFXjdHJWsrRs+0qmp54y8tGYE2zi/WPyj/J+Hxx8yGR0Jq1jz3Gmgc pGQtYQbjQzav4gOuABr6TmQ+0wOg2pesyIbRcl/7pIvotDcJzauqD9SK2ExqwlvJSHwP/HpJ+uDar 1KNHurVNKNhympgn7RksIrEuF3I3W4KFSd9CBLUvjN+tbOPkpWKId0FuA/sY33gUusFqf5xOsooET pNvV6RiYohCbyXs9zla9jC46u/yleZt6oM834lqpmRYUKUZApjIOA1kwgISMuKzPM2UgPJpA3Pu+d 6Qn2LZx7oOmMIgyKIg==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1tWmeo-009gu5-07; Sun, 12 Jan 2025 01:20:50 +0000 From: linux@treblig.org To: jason.wessel@windriver.com, danielt@kernel.org, dianders@chromium.org Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH] kdb: Remove unused flags stack Date: Sun, 12 Jan 2025 01:20:49 +0000 Message-ID: <20250112012049.319515-1-linux@treblig.org> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" kdb_restore_flags() and kdb_save_flags() were added in 2010 by commit 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)") but have remained unused. Remove them, and their associated storage. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Douglas Anderson --- include/linux/kdb.h | 3 --- kernel/debug/kdb/kdb_support.c | 18 ------------------ 2 files changed, 21 deletions(-) diff --git a/include/linux/kdb.h b/include/linux/kdb.h index f6c2ddb16b95..905a2e2f45f6 100644 --- a/include/linux/kdb.h +++ b/include/linux/kdb.h @@ -140,9 +140,6 @@ extern const char *kdb_diemsg; =20 extern unsigned int kdb_flags; /* Global flags, see kdb_state for per cpu = state */ =20 -extern void kdb_save_flags(void); -extern void kdb_restore_flags(void); - #define KDB_FLAG(flag) (kdb_flags & KDB_FLAG_##flag) #define KDB_FLAG_SET(flag) ((void)(kdb_flags |=3D KDB_FLAG_##flag)) #define KDB_FLAG_CLEAR(flag) ((void)(kdb_flags &=3D ~KDB_FLAG_##flag)) diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c index 0a39497140bf..4c545c658659 100644 --- a/kernel/debug/kdb/kdb_support.c +++ b/kernel/debug/kdb/kdb_support.c @@ -536,21 +536,3 @@ bool kdb_task_state(const struct task_struct *p, const= char *mask) =20 return strchr(mask, state); } - -/* Maintain a small stack of kdb_flags to allow recursion without disturbi= ng - * the global kdb state. - */ - -static int kdb_flags_stack[4], kdb_flags_index; - -void kdb_save_flags(void) -{ - BUG_ON(kdb_flags_index >=3D ARRAY_SIZE(kdb_flags_stack)); - kdb_flags_stack[kdb_flags_index++] =3D kdb_flags; -} - -void kdb_restore_flags(void) -{ - BUG_ON(kdb_flags_index <=3D 0); - kdb_flags =3D kdb_flags_stack[--kdb_flags_index]; -} --=20 2.47.1