From nobody Sat Feb 7 14:16:39 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993752563 for ; Sun, 12 Jan 2025 09:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736672737; cv=none; b=TDKvKhHiX9qAscSa8eJdfxUUOWe0kW7MdskheS/QbZVqQkpOngSNbnZ35RkDQsgwGzaAy866CcvO4xv7BqTj3hbT+Mc0MBKvSp6lTA1W1TMrn2de1hrhhzFWbXtDmwVgmrgMw3Ki8kc/Tk9gD6youzx7hMVLKMh3kjNn9vdHjxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736672737; c=relaxed/simple; bh=iKs2YT/O6O3hI6dqcd/Y4shirDLatC1bZ5lLLSgXYAk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=RHSMFcOGFmeZ/wFEcEes16M29cz/Yi39i+84KzBc3K6NcxuOZgvFl2ka47n2pRNuZ+O6UMAFrPs15LG4QgANWeV4ITw+Jnbw0zZNfJPShSuRP41JVgxCfex+DF9p7GwHb54wKaRkQMaR+Cs2Ymk7VUGt+T4tFPO1CX5U5BzDaR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HpvRZGBw; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HpvRZGBw" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2162c0f6a39so77375165ad.0 for ; Sun, 12 Jan 2025 01:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736672735; x=1737277535; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=DeWY5GrZ+oUsk5L6PZfCgkhib35kaMkIvOwfSxSW9Qs=; b=HpvRZGBw9NbZiGfq5fUqXVQ5lEp2Rhxhwpdr/g73pU4Vo28Z0fD/F4dkGn0HnlYyWu R2MAdbusronRoeQABLxoKQKNYxHDpqLczXY1xRBkR18WASrzgk9MJSpR+OnnRFLHbhn6 uUzXbbtFjhWCfoGMnPYNCW9S2C0Bed/oaBqNrdaIV+NzwZjFkZ+vTraOJx541unEqMrL r2G9aoO5FEORAafNVMMIhwsxAIUCbpwfzCJ43qveQqEc9QW1XaTmEGFFNxiqCzHQ3NgR 57uYzhbcgJRHquaMH327OhRJRQ0moMoDoM2CKoacUVER7mwz7RjB9gSbgdSqL1xJLQiL s1gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736672735; x=1737277535; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DeWY5GrZ+oUsk5L6PZfCgkhib35kaMkIvOwfSxSW9Qs=; b=IN80S3sAQTJN8zer3Ndx/JN4o1ut9zEyPhPnIFkm9765JxyoC7409R5dU+cUlxLPB8 uBLVSZVq354QBJTjSCNpdDMHwWzrFEQbsaiu6SsBRs3Ru8gNJCgFYq4C+aS0/MCuOd97 MgoNetW+QsZRvoMUI6TLSydtR9l8CXufFZG78awSqKjIOZk+rX7T1cNwYiUM/gbOHQMR XqW0a9lV4C1KpOxJ4/qtE/hkJ+JniDNrI2xS/OEb0qb84retPAzbnym1L54H6g7AQVHx qYcHt/D1lvnwQCPnIn1lsw0OPI9OOWNa1e06tybsBGGKzDidzXvhKBI8YTM0z+Mee10G kXpQ== X-Forwarded-Encrypted: i=1; AJvYcCXYaOmQo9J1pVqMr5dsNGiUDcxOeEATlpaMde4RW9ZHFfFqI8wE74YMhm0JELABOeq8G8uhH96q+UUG7Xg=@vger.kernel.org X-Gm-Message-State: AOJu0YytYsXe8pgpG8hH0YLxts+/DVhoowYo3NBCte+a8nSy20uBZDk2 svTjH1hr9nbyKhGAki3v3f4tgWZfIWPYGO28PmQK3d03o72FoOW8 X-Gm-Gg: ASbGncufWXUWd+CMohTIBkNd1s8nCCg3o8pf1kPzy1nFQnK+UWBlLiqbHzkRsVAJsyd YMi//lQ6eV2GRRTLI7jR8/wfn+dEjoEhPLVdD1kUPm1k9Aiycun1YxZXIrR4WB5cG1puLdgX3WC 8Q0IcUJUXNR5Nh6ypyndNuDeSUD2bBv9zUVTi8jK27UaBHkh9nryLpLAQsFgwi/ssgKsW7DbZIe XSIdV6BUHsMoxnP1gOy27kDgkSUjIqjbR+Tys5S4yPn116kAIurfCA= X-Google-Smtp-Source: AGHT+IHu/GMQyrHeXHhW2IHCjlqDAL093DtUlydQHsY2SPkxdzqmE4DrqTy4VxiKykzwhI1RLWLgdA== X-Received: by 2002:a05:6a00:3910:b0:725:41c4:dbc7 with SMTP id d2e1a72fcca58-72d324bedf7mr19906933b3a.4.1736672734679; Sun, 12 Jan 2025 01:05:34 -0800 (PST) Received: from Emma ([2401:4900:1c96:bd6b:5054:ff:fe53:2787]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4059485bsm3950996b3a.83.2025.01.12.01.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jan 2025 01:05:34 -0800 (PST) From: Karan Sanghavi Date: Sun, 12 Jan 2025 09:05:30 +0000 Subject: [PATCH v2] drm/mediatek: Initialize pointer to avoid undefined behavior Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250112-uninitializedpointer1601557-v2-1-61ac4c80b76d@gmail.com> X-B4-Tracking: v=1; b=H4sIANmFg2cC/42NQQ6CMBBFr0JmbU2nQEFX3sOwADrCJNCSFolKe ncrJ/Dv3l+8t0MgzxTgmu3gaePAziZQpwz6sbUDCTaJQUlVYJp4Wra8cjvxh8zi2K7kUUssy0p capl3lSo73RlIhsXTg1+H/d4kHjmszr+P2Ia/9z/vhgJFZWSudU01Fngb5panc+9maGKMX9SW+ yrGAAAA To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Alexandre Mergnat , Sui Jingfeng , CK Hu Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shuah Khan , Karan Sanghavi X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1736672731; l=1803; i=karansanghvi98@gmail.com; s=20241017; h=from:subject:message-id; bh=iKs2YT/O6O3hI6dqcd/Y4shirDLatC1bZ5lLLSgXYAk=; b=lVFZMQ2xtvXWpRGLSvR+s3AhcVB23qGM6qUFxsgC7Lmm1L3bGimUR3y+L/VRjXJNE1G5+XN7A bfG6MOMZjtdAmYBZBCgSTZnzk8UpmSGnoyrhrJcnCUjRhYr5KxeLxN1 X-Developer-Key: i=karansanghvi98@gmail.com; a=ed25519; pk=UAcbefT1C06npNVDJHdgpPqTm4WE9IhaA1fmJb3A37Y= Initialize the `next` pointer with NULL as the function `mtk_drm_of_get_ddp_ep_cid` might return early without assigning a value to `next`. Dereferencing an uninitialized pointer can lead to undefined behavior, as it might point to an invalid memory location. Coverity CID: 1601557 Fixes: 4c932840db1d ("drm/mediatek: Implement OF graphs support for display= paths") Signed-off-by: Karan Sanghavi --- Coverity Message: CID 1601557: (#1 of 1): Uninitialized pointer read (UNINIT) 3. uninit_use: Using uninitialized value next. Coverity Link: https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=3D= 1601557 --- Changes in v2: - Updated the patch subject and summary log - Link to v1: https://lore.kernel.org/r/20241111-uninitializedpointer160155= 7-v1-1-7d03668e8141@gmail.com --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/media= tek/mtk_drm_drv.c index 9a8ef8558da9..bc06c664e80f 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -900,7 +900,7 @@ static int mtk_drm_of_ddp_path_build_one(struct device = *dev, enum mtk_crtc_path const unsigned int **out_path, unsigned int *out_path_len) { - struct device_node *next, *prev, *vdo =3D dev->parent->of_node; + struct device_node *next =3D NULL, *prev, *vdo =3D dev->parent->of_node; unsigned int temp_path[DDP_COMPONENT_DRM_ID_MAX] =3D { 0 }; unsigned int *final_ddp_path; unsigned short int idx =3D 0; --- base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2 change-id: 20241111-uninitializedpointer1601557-9803b725b6bd Best regards, --=20 Karan Sanghavi